Received-SPF: pass (google.com: domain of linux-kernel+bounces-153592-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 22 Apr 2024 17:02:18 +0200
From: Jiri Pirko <jiri@resnulli.us>
To: "Kory Maincent (Dent Project)" <kory.maincent@bootlin.com>
Cc: Oleksij Rempel <o.rempel@pengutronix.de>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Kyle Swenson <kyle.swenson@est.tech>
Subject: Re: [PATCH net-next v2 2/3] net: pse-pd: pse_core: Fix pse regulator
 type
Message-ID: <ZiZ7-n5q3COmPRx6@nanopsycho>
References: <20240422-fix_poe-v2-0-e58325950f07@bootlin.com>
 <20240422-fix_poe-v2-2-e58325950f07@bootlin.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240422-fix_poe-v2-2-e58325950f07@bootlin.com>

Mon, Apr 22, 2024 at 03:35:47PM CEST, kory.maincent@bootlin.com wrote:
>From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>
>
>Clarify PSE regulator as voltage regulator, not current.
>The PSE (Power Sourcing Equipment) regulator is defined as a voltage
>regulator, maintaining fixed voltage while accommodating varying current.
>
>Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>

This looks like a fix. Can you provide "Fixes" tag please and perhaps
send this to -net tree?

Thanks!

>---
> drivers/net/pse-pd/pse_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/pse-pd/pse_core.c b/drivers/net/pse-pd/pse_core.c
>index bad29eaa4d01..795ab264eaf2 100644
>--- a/drivers/net/pse-pd/pse_core.c
>+++ b/drivers/net/pse-pd/pse_core.c
>@@ -294,7 +294,7 @@ devm_pse_pi_regulator_register(struct pse_controller_dev *pcdev,
> 	 */
> 	rdesc->id = id;
> 	rdesc->name = name;
>-	rdesc->type = REGULATOR_CURRENT;
>+	rdesc->type = REGULATOR_VOLTAGE;
> 	rdesc->ops = &pse_pi_ops;
> 	rdesc->owner = pcdev->owner;
> 
>
>-- 
>2.34.1
>
>