Received-SPF: pass (google.com: domain of linux-kernel+bounces-153702-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240415185120.57973-1-gschafra@web.de>
In-Reply-To: <20240415185120.57973-1-gschafra@web.de>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Mon, 22 Apr 2024 18:23:51 +0200
Message-ID: <CAJZ5v0jmtH6+C=GcWxXLM3qXBoMvuC-Nz8fuBG=1Ha1g95atGw@mail.gmail.com>
Subject: Re: [PATCH] ACPI: resource: Do IRQ override on GMxBGxx (XMG APEX 17 M23)
To: Guenter Schafranek <gschafra@web.de>
Cc: rafael@kernel.org, lenb@kernel.org, linux-acpi@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 15, 2024 at 8:51=E2=80=AFPM Guenter Schafranek <gschafra@web.de=
> wrote:
>
> The XM APEX 17 M23 (TongFang?) GMxBGxx (got using `sudo dmidecode -s
> baseboard-product-name`) needs IRQ overriding for the keyboard to work.
> Adding an entry for this laptop to the override_table makes the internal
> keyboard functional.
> See https://www.reddit.com/r/XMG_gg/comments/15kd5pg/xmg_apex_17_m23_keyb=
oard_not_working_on_linux/.
> Patch was successfully tested with Arch Linux Kernel v6.8 under
> Manjaro Linux v23.1.4.
>
> Signed-off-by: Guenter Schafranek <gschafra@web.de>
> ---
>  drivers/acpi/resource.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
> index 59423fe9d..c9af5d2f4 100644
> --- a/drivers/acpi/resource.c
> +++ b/drivers/acpi/resource.c
> @@ -533,6 +533,12 @@ static const struct dmi_system_id irq1_level_low_ski=
p_override[] =3D {
>   * to have a working keyboard.
>   */
>  static const struct dmi_system_id irq1_edge_low_force_override[] =3D {
> +       {
> +               /* XMG APEX 17 (M23) */
> +               .matches =3D {
> +                       DMI_MATCH(DMI_BOARD_NAME, "GMxBGxx"),
> +               },
> +       },
>         {
>                 /* TongFang GMxRGxx/XMG CORE 15 (M22)/TUXEDO Stellaris 15=
 Gen4 AMD */
>                 .matches =3D {
> --

Applied as 6.10 material, thanks!