Received-SPF: pass (google.com: domain of linux-kernel+bounces-153721-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Mon, 22 Apr 2024 12:38:09 -0400
From: Frank Li <Frank.li@nxp.com>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Lucas Stach <l.stach@pengutronix.de>, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/1] dt-bindings: interrupt-controller: fsl,irqsteer:
 Add imx8qxp support
Message-ID: <ZiaScfP5Ep81cPXJ@lizhi-Precision-Tower-5810>
References: <20240422064949.70778-1-alexander.stein@ew.tq-group.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240422064949.70778-1-alexander.stein@ew.tq-group.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Vw+m49O8I7lBYUCZzFjGcotq0Wz6xJBlLoZ12Qnps2o6O58a13JkA2yKXZeM?=
 =?us-ascii?Q?vXWtg0f6SSNpLO5BBuM/mthKbHts4A/fcKmT2GLYS+PtEf5j1HmRoobxZhX6?=
 =?us-ascii?Q?+kx+V1KJab0EWWtjxBG8xSmzuB0atFVhYa8Yj5jPd3fa91v7pa5MKhqRYCdq?=
 =?us-ascii?Q?l84FKmqaw4bAEcdnjP8r0pZusp96kQD47u5UueHosrHssxfWtrcOyXYuFOP/?=
 =?us-ascii?Q?zLNdkiDo6/gyBkaJWuU+pKdrXzwmRU2wcxtGagN/5Sw/KepijUrcI2j/S5yq?=
 =?us-ascii?Q?q4/2r5riyh9Dh+iXmr8OtwlPIUL8CVHM3xlKMX7Rb7iB70wMoqI07Jv56A3u?=
 =?us-ascii?Q?inuUBNKAOAIQLOsm3BrdbnVLJYy8/r1HBoNKgFj7iMPhTuqesZSsLGT20owU?=
 =?us-ascii?Q?qrMetPnwc/Bn1MZ89cNaRfJmJTa7ZW9ccB0B753N1B1UAwnjlg1hALEwkpvK?=
 =?us-ascii?Q?NMBOFd1fynJ4eabxj5T8uI9wakjN0nMj8dmygakBdhbHgGAawg/YKJHo2R0b?=
 =?us-ascii?Q?0N7BDBugrvv63bjAwBMPojhBXFzuaHwNm4DNwcd07cHP3MAFxSnhhkY6O606?=
 =?us-ascii?Q?RCNhp18ckidkS1YNfJGkyctdzKaoWGIbgbaI6Q+m6vy5lgdLSEcpvuP6zkZg?=
 =?us-ascii?Q?yTHxCdqAqTKujOZjIIMDhZrD3J1ube7CTIr2Pjp83GuMjuEy9VQ7qWPNSY0E?=
 =?us-ascii?Q?23W2Ojz9PIkTzcQhrJhUpwRFpJwoWXs3NTiedaCX8ahG03l3Q4KdvjqlxJTB?=
 =?us-ascii?Q?eSBmL/tSlUqIQkS2ePR5YfbGdBUrisl12MKjOB5xg6+I+BxXq58jpoKbZqfp?=
 =?us-ascii?Q?IAmAV/aeeDcgHKKjWEnvppSN1PLPla84f715DhT3d9AFitfRU1gbO7TyPjYd?=
 =?us-ascii?Q?EzIooa07Z1oWrK3tevsScfsoEYr9xlzKzW21ceKUJvuYpQwf2wVMRqIUEofI?=
 =?us-ascii?Q?xDUeYB6BfVxJAwF5tjaRm4fVGXspbxduTUwDq33y8Glp00NQ1RReKdK7wBMA?=
 =?us-ascii?Q?HTMwrQ9uWlgymw1T0Mh52enUWo79lMVXLDmdlQGIDDj6AAkGkmhRgR4YEpxE?=
 =?us-ascii?Q?jIbHNr0dL7JjvbYjT8YwmC9GNwNX0dPxL/GBlbM1m1Td6l2V14g9wOOmj3gh?=
 =?us-ascii?Q?muC6rp0N6rGbc98zNKnKTQ+2sCGbSJGJmcsgYBNM/HyuhN2YQLBj7aZM6Y+K?=
 =?us-ascii?Q?l4QphDVtIuAA0TdtZTCd/PzQLs6n7hMWnAz3wSJ0kejCz+8hFzu8C47pkIq3?=
 =?us-ascii?Q?uOr5poq6PRUbhBBSjKW2C9Op7t0URCZ9JZAO7AmLEw8ce6mQ8nawA2+IBI3B?=
 =?us-ascii?Q?ROlzpzcQ/FO8BFl9epSy2JwvwZ6C2J2h2g0xIx/gCIcVju+TiHI7ebdvJBHQ?=
 =?us-ascii?Q?Wy3NY5eQgb2K4Gw1ZaKHKGLnRyl0PC4pgJ08LvCPmk4gzfZJs6XD+sfPDuR7?=
 =?us-ascii?Q?UQhiw1RI5LfrsHllDPEqXl5Ttu4Nr29kxXHWvlwz0oIKKIqt7YLCOUlGa91A?=
 =?us-ascii?Q?DKCkyeID3DHy3zsdGto+fUjf8ukRK/qXKhJ5rlaVYnSss/PzPpJk4PRg9EN6?=
 =?us-ascii?Q?uT80E7ZF6T1owqKbHb8=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8a7de62c-44de-4d1d-e36e-08dc62ea9d73
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2024 16:38:18.5130
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BExBymzA7V5TWBwq6NUmpf5k2EnEczOd6quHFifjHhSPtS6Gw+ugYIWzEc0aFnrXScdv6IthaFOQaMuVurmbsQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6885

On Mon, Apr 22, 2024 at 08:49:49AM +0200, Alexander Stein wrote:
> Some SoC like i.MX8QXP use a power-domain for this IP. Add a SoC-specific
> compatible, which also requires a power-domain.
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---

Next time, please cc imx@lists.linux.dev

Frank

> Thanks for the feedback.
> 
> Changes in v3:
> * Move 'allOf' before 'additionalProperties'
> * Remove superfluous 'minItems: 1'
> 
>  .../interrupt-controller/fsl,irqsteer.yaml      | 17 ++++++++++++++++-
>  1 file changed, 16 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml
> index 20ad4ad82ad64..3d33b75d6ecfa 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml
> @@ -14,7 +14,9 @@ properties:
>      oneOf:
>        - const: fsl,imx-irqsteer
>        - items:
> -          - const: fsl,imx8m-irqsteer
> +          - enum:
> +              - fsl,imx8m-irqsteer
> +              - fsl,imx8qxp-irqsteer
>            - const: fsl,imx-irqsteer
>  
>    reg:
> @@ -42,6 +44,9 @@ properties:
>    clock-names:
>      const: ipg
>  
> +  power-domains:
> +    maxItems: 1
> +
>    interrupt-controller: true
>  
>    "#interrupt-cells":
> @@ -70,6 +75,16 @@ required:
>    - fsl,channel
>    - fsl,num-irqs
>  
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: fsl,imx8qxp-irqsteer
> +    then:
> +      required:
> +        - power-domains
> +
>  additionalProperties: false
>  
>  examples:
> -- 
> 2.34.1
>