Received-SPF: pass (google.com: domain of linux-kernel+bounces-153741-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Mon, 22 Apr 2024 09:43:02 -0700
In-Reply-To: <CABgObfaaec5JmLtZ+OJ7NuX1zGh6_dSQ_n7-8K=LtEY-ON-dJQ@mail.gmail.com>
Precedence: bulk
Mime-Version: 1.0
References: <20240419112952.15598-1-wei.w.wang@intel.com> <20240419112952.15598-3-wei.w.wang@intel.com>
 <CABgObfaaec5JmLtZ+OJ7NuX1zGh6_dSQ_n7-8K=LtEY-ON-dJQ@mail.gmail.com>
Message-ID: <ZiaTloh1_a2LtUEg@google.com>
Subject: Re: [PATCH v2 2/5] KVM: x86: Introduce KVM_X86_CALL() to simplify
 static calls of kvm_x86_ops
From: Sean Christopherson <seanjc@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Wei Wang <wei.w.wang@intel.com>, kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 22, 2024, Paolo Bonzini wrote:
> On Fri, Apr 19, 2024 at 1:30=E2=80=AFPM Wei Wang <wei.w.wang@intel.com> w=
rote:
> > +#define KVM_X86_CALL(func, ...) static_call(kvm_x86_##func)(__VA_ARGS_=
_)
>=20
> Just
>=20
> #define KVM_X86_CALL(func) static_call(kvm_x86_##func)
>=20
> please, because having the parentheses around the arguments is a lot
> more readable

+1, the more these look like function calls, the better.