Received-SPF: pass (google.com: domain of linux-kernel+bounces-153746-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <41925799-563a-4aed-a2b8-e1fb67a948c0@theobroma-systems.com>
Date: Mon, 22 Apr 2024 18:45:59 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 3/3] arm64: dts: rockchip: add dual-role usb3 hosts to
 rk3588 Tiger-Haikou
To: Heiko Stuebner <heiko@sntech.de>
Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org,
 linux-kernel@vger.kernel.org, Heiko Stuebner <heiko.stuebner@cherry.de>
References: <20240422163951.2604273-1-heiko@sntech.de>
 <20240422163951.2604273-4-heiko@sntech.de>
Content-Language: en-US
From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
In-Reply-To: <20240422163951.2604273-4-heiko@sntech.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ckg4RVhlUFgwMytNcVFRbm5abGQ0VWphQ2prVDhMOFFQa1IxcFF2OVhTT3Jp?=
 =?utf-8?B?aWo5U25YWHU2clhoblJuMjcwRXNCNmRNalEzejFXaTNOVEdyM2JBNnRubnBI?=
 =?utf-8?B?YzF6SUhab3IwYWRVcWtKS3grL0YydjlraXlhaHFwRkhpK3EwMHIvb3dBaGEw?=
 =?utf-8?B?UzFwM29Ybk9WLzdUOVRwQmhTVG5OM2dqenhmQlpTeTBMTGdNbFhCNlB3RUl5?=
 =?utf-8?B?bE5TaFJCWVY2RDNYeTNseXRER2ZHOWR0K1RhVENqK0RsMllGRHRDdGl0enpa?=
 =?utf-8?B?enBGVXUwZjA3ZWlKRjRDM21VaGhvR050UWVjZk9nZnZKbVhWL21GRG1YN1hJ?=
 =?utf-8?B?NEhmM2Zwam55NklmQndFYlZNd3o2ZnhFVHpoWGtNOEltY25ObDNTeDNlQXZ3?=
 =?utf-8?B?RisybWUvK1BDTm9QUGF6Qk83eEdYM3VSNDdhUDZCUHYzSGhIY2lreVBjcHdq?=
 =?utf-8?B?c2RveDBkZnlCT2V0UFQzUFBoQWFCeTFheU8zYVlpSnhWSGZHTEpYbzBjMGJU?=
 =?utf-8?B?cE5oa2NudlMrbmVHWjhsOTBwNE5reGxFcjRFTHAxY3ROOXlnSFRiL0RMY0RO?=
 =?utf-8?B?L014ek5yUGZUVjZwZmd0NWJaZU0zNE1iRDc5QytZUXRqdlhiVVAxekFZS3J5?=
 =?utf-8?B?V3QvNFh2ckxnYTBHejc2OERkUWphczBsSVhMRk1zOVJrK0I5NFFZdkEvb2tO?=
 =?utf-8?B?enVXWDJ5SnRyczVNUjlibHF0cU5saFhTaWdjMW80cVRtNXZFWTFaMXg0SzV1?=
 =?utf-8?B?SzJLNERlSXlWcVgwZGV4SjJ5cjUvM0FqUGY5NGpVb3FVWlNFclV5RnFUeVp2?=
 =?utf-8?B?RHZ3dTFXdVhtSEhhdkJqTmh2ZU1QL09KUzJ2ODAvdU14Wk16S2J5NXJ6cEto?=
 =?utf-8?B?eUE0bEk4RVhXNXEyRGYrRHJuUTNOend4NUczT2ZZR3BwSjNUN3FsNkNrcHFO?=
 =?utf-8?B?ZE5nSmhlWTRPTm5aWng5YlkrS1lXS0k3MHNPU0kyUnl4UWI5cXk5VjhrTmx6?=
 =?utf-8?B?SlNXVUF2Q0FqT0YzZWZZR1ZlUUViT0RpWUNibGVsd0lSeG9adGtuTjduNk5q?=
 =?utf-8?B?Y3RFdXMxWmtmOXVPNk95RXMvbG1kWGtEdFZuRVJlM1pROWpETHg4ZEljcThu?=
 =?utf-8?B?OWRMR3VSY0wzcVdiMmNncDNYSkRucU1XN2dYWXJNQTJsSjhqb1ZGcDFPZHN5?=
 =?utf-8?B?OFVKL09zZjBVRGFaK2VpMDFRbDBXQ1Q2RW9YUVdQaCtSNXc1c1gra0c5RVNj?=
 =?utf-8?B?N2FLaFU2UEdsMlo5NTBqZ3BoRE84UFVFaG11bVJKc3VHL0RQeFd6Ly9UcnUv?=
 =?utf-8?B?LzlzRnZwejYwUEl0VkR4SjFiMVdUUE9ldXE0MHlhdzBYdFh0TFBzcmhnY0J2?=
 =?utf-8?B?dWEyeUl0S0NzYVNoY0ZOV0ZEQ2hnb1cySXpOR0xva090Uys0OVBlUU05cWV5?=
 =?utf-8?B?cGphL2RFY3FYaU9yd1pnTlRhQk0xczFIQkxrK0Z6aTNwM0pvYnpCcXlMaUM0?=
 =?utf-8?B?TndBc2Ntbjh6QmhVQ28wdTBMRDFIcXlMWXc5Z0V5em13cDZXRmpLU0plWHhi?=
 =?utf-8?B?MVp3UkxzR0RXaHNzRWFTbUswc0g3eU1VQmlSYUhReDVSc0h0YXpUUmlPa0ZN?=
 =?utf-8?B?REVwbFhEMnJTMmZWRm9HM0xKcm9CVmNvUm1BL25vM3gxNXhrMTVlbk8zTk5q?=
 =?utf-8?B?SGxJdk9abks1eXhlN2JwQU10dzBVdkJXOHR5dVVjbEE1K2NFcXRRc3FsT1lS?=
 =?utf-8?B?ODRlV2Q2Vk1HUEFtTisxQVl3b1liQ2g5UExUdUpnWDduV0grS1paelpzVUtO?=
 =?utf-8?B?Q1FtVmRsUkFISnJQNVVyUFgzWUdUTmlyQUhHUVJkVXhnNlU2azRpSk51NzNX?=
 =?utf-8?B?anNUenlJV3dXUHFxN0ZORmlheVgxL3JCWVVlbUpYVk9pKy9EZmxWM0ZhZ2k0?=
 =?utf-8?B?aVR1SkNmbzVOWUYzWnF0UFFISnRTTkp1Yk5mbStybXl5d29NK3krZ1AwODli?=
 =?utf-8?B?R09SZkdLZmpSMU1OcitxVWEzdXVsV0JlaXl4QS83dmI4TFlHM1IvZzl4ampH?=
 =?utf-8?B?d0lTbEVseE1KYUg4UjNkazlkdlZ5ZWwzYnR4SjNTT1kzMHdWQ0w2bWY2cjM1?=
 =?utf-8?B?SmozMEJ1NXlpTDVhY09mRmlFNXhJaFhlWXR6WGZxNE43OEtZVnY4SEZUZmlK?=
 =?utf-8?Q?jwE50wyUEswa9Wn8ZJLZlrM=3D?=
X-OriginatorOrg: theobroma-systems.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6ff62a5a-5480-43d9-f071-08dc62ebb124
X-MS-Exchange-CrossTenant-AuthSource: DB7PR04MB4842.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2024 16:46:01.1948
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5e0e1b52-21b5-4e7b-83bb-514ec460677e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3A9ksZIMryJXcVh+Dmn2RjmfS3tqByYsek0N6tq51FaFPeUUAriiMBhCxZ/M6sjJkhG01er1dRHw0cWG/pGlkSxnIW45TBCP42ckjVye3wLq2GDYaqCoMlIjYo4xjWBI
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8704

Hi Heiko,

On 4/22/24 18:39, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner@cherry.de>
> 
> Apart from the host-only usb3 controller (host2) the rk3588 also provides
> two dual-role controllers. On the Tiger-Haikou combination these are
> connected to the lower usb3-host port in host-only mode and the micro-usb3
> port for dual-role operation.
> 
> Add the necessary controllers, phys to the Tiger-Haikou board and enable
> the usb-id extcon.
> 
> Signed-off-by: Heiko Stuebner <heiko.stuebner@cherry.de>
> ---
>   .../boot/dts/rockchip/rk3588-tiger-haikou.dts | 58 +++++++++++++++++++
>   1 file changed, 58 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-tiger-haikou.dts b/arch/arm64/boot/dts/rockchip/rk3588-tiger-haikou.dts
> index 2aa43e7430e5..52695b6c113a 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-tiger-haikou.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-tiger-haikou.dts
> @@ -113,6 +113,16 @@ vcc5v0_baseboard: vcc5v0-baseboard-regulator {
>   		vin-supply = <&dc_12v>;
>   	};
>   
> +	vcc5v0_otg: vcc5v0-otg-regulator {
> +		compatible = "regulator-fixed";
> +		enable-active-high;
> +		gpio = <&gpio1 RK_PB5 GPIO_ACTIVE_HIGH>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&otg_vbus_drv>;
> +		regulator-name = "vcc5v0_otg";
> +		regulator-always-on;
> +	};
> +
>   	vcc5v0_usb: vcc5v0-usb-regulator {
>   		compatible = "regulator-fixed";
>   		regulator-name = "vcc5v0_usb";
> @@ -137,6 +147,10 @@ &combphy2_psu {
>   	status = "okay";
>   };
>   
> +&extcon_usb3 {
> +	status = "okay";
> +};
> +
>   &gmac0 {
>   	status = "okay";
>   };
> @@ -199,6 +213,13 @@ haikou_keys_pin: haikou-keys-pin {
>   				<3 RK_PD5 RK_FUNC_GPIO &pcfg_pull_up>;
>   		};
>   	};
> +
> +	usb2 {
> +		otg_vbus_drv: otg-vbus-drv {
> +			rockchip,pins =
> +			  <1 RK_PB5 RK_FUNC_GPIO &pcfg_pull_none>;
> +		};
> +	};
>   };
>   
>   &sdmmc {
> @@ -214,6 +235,23 @@ &sdmmc {
>   	status = "okay";
>   };
>   
> +&u2phy0 {
> +	status = "okay";
> +};
> +
> +&u2phy0_otg {
> +	phy-supply = <&vcc5v0_otg>;
> +	status = "okay";
> +};
> +
> +&u2phy1 {
> +	status = "okay";
> +};
> +
> +&u2phy1_otg {
> +	status = "okay";
> +};
> +
>   &u2phy2 {
>   	status = "okay";
>   };
> @@ -236,6 +274,13 @@ &uart2 {
>   
>   &uart5 {
>   	rts-gpios = <&gpio3 RK_PB3 GPIO_ACTIVE_HIGH>;
> +};
> +
> +&usbdp_phy0 {
> +	status = "okay";
> +};
> +
> +&usbdp_phy1 {
>   	status = "okay";
>   };
>   
> @@ -249,6 +294,19 @@ &usb_host0_ohci {
>   	status = "okay";
>   };
>   
> +/* host0_xhci on Q7_USB_P1, usb3-otg port */
> +&usb_host0_xhci {
> +	dr_mode = "otg";
> +	extcon = <&extcon_usb3>;
> +	status = "okay";
> +};
> +
> +/* host1_xhci on Q7_USB_P0, lower usb3 port */
> +&usb_host1_xhci {
> +	dr_mode = "host";
> +	status = "okay";
> +};
> +

Sorry I didn't catch this earlier but the alphabetical order is not 
respected here, it should be after &usb_host1_ohci.

Cheers,
Quentin