Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp2473619lqt; Mon, 22 Apr 2024 11:40:08 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUXlerHD2NNHQ1lTsaQ6cBWqJT3/3+LZIbVwiYq5giHr8+YRUEhNV+/gHPtqLNwGhDXC7VmmlS9xZ4OnmCa+PpVq3Ci86P9yc7vIjkWaA== X-Google-Smtp-Source: AGHT+IFoMhP7OaYlQ/ye0MVAIylEfJwVFnXjZp1DpKf66j+CxonY/Tu+HxBMhGsIhuEv9KIkMUZR X-Received: by 2002:a05:622a:1210:b0:437:a10c:3794 with SMTP id y16-20020a05622a121000b00437a10c3794mr13696669qtx.18.1713811208379; Mon, 22 Apr 2024 11:40:08 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713811208; cv=pass; d=google.com; s=arc-20160816; b=vUei6+CoHIjnxywtXq0nrBcvtcLjwUQmjI1zagYg9YcsprttVETRPd8PTdHOUibQa+ ER6m6FmIC7awjRuL2UIuNaglVrC8jeRkg4O2oC0/RZL1rr/rha0qsWD8r3aG+l57wX5F vccZWa9Cirfr3SrKGZuxpObMqj4S1sGCL0BcWWudINOLzI0JeKcOUvBbNOUtyPW9ZeAn MCazLd9MzwLrrtOKhhBoSi1MaDIfb/YJ7WoI6emAsPU8HKYtr5TbRbLkiHJSF+sCXv7E YtczYxiesyZzfvDlOoZdJdpZ6tdEGBmZwEdP+OK6PLXM0R8fSNu5MOKwLfflTHdSRQcR PoZA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=WvnAsiuZt8H1Zl4oauEZTca+TX5rbK65b3taUhfahhM=; fh=UIv9PHMavMuS3VbCyFJU69Hvhju9poHvsQOevDyygzw=; b=IMBsggv8iFq8hnwxnUG9iqf/6yJFet2ebkJmYrBO0hPtdIV5vP3F9TZFThulZMpT7d iG/nT8aEydy7k5pM9iNuwklAaf46JQcCEwVz0qrMv/0iMbhVDHU0t7S0mNUoDmtVGsdV MF922EdE6Z6zscpEYpdTH1NISd4x0w6ynfwDAHqxG7c1BuHH2QpmXrXArZVDTDYTlOSD EU7BANQmlsd0LJFynUyExyIyU42F20Nq1/Iwj2EBITd0meaIgixpJqhfntdAz/Xc4Xvo X/4eewWmYKQaOtBnL4sMUNHEHM969YiO/HMBvShzakOBz6Vjg2P/AdBzazWlLjObtslx /WKg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=ds52ftOk; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-153847-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-153847-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id hd25-20020a05622a299900b00437544defd3si9785170qtb.550.2024.04.22.11.40.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Apr 2024 11:40:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-153847-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=ds52ftOk; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-153847-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-153847-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 1CC491C20E3D for ; Mon, 22 Apr 2024 18:40:08 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 448D1154C0B; Mon, 22 Apr 2024 18:39:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="ds52ftOk" Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6889153BFE; Mon, 22 Apr 2024 18:39:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713811198; cv=none; b=Jm049GjnpidvbvfFd1U5lQetgouePhdr2HCQmnwt7vB5ezkLMjx/Z2YpaPJz2HAou6+Ss+uHvkzSmhvTLIDXPT5glHB0xOh4qwJws4HRCFlzlllOwrM+BtIw8AZHw4/UIYIsT7BIC3XOFDcS9hSw12lJxK0KdqhbU9OrVSIskcE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713811198; c=relaxed/simple; bh=Nyd5CC3+SeZTxf0OJyqVrpGGzfHzAExyfn45MCTlIKo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UUDYwSwS2zg11cVpHijUVXKrlSSoPotYo8kssTZ8UVu9Ge9XmJrr3TvZ71hSYMk6EopoDvmAAxwLDfzSj44QR+AeJoyBlmUGLlhbKCrV0VZJC4MyKnDRueITOmjwECHmAE/6+92eOKIB1qySu0IZJlATXaKIJ8ZMR4hkdFIk+bg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=ds52ftOk; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=WvnAsiuZt8H1Zl4oauEZTca+TX5rbK65b3taUhfahhM=; b=ds52ftOk9Au39MxQJzq73CM5N2 GyV5+iclVmjhqP8u/seLO1N6Mb+fe9n4Kk5dPhboUvhWAWH83j2jb36JLESOI7gdhv3Ww5LfQdT3M BLRzv/gZMgBEI6yH10yerKdpcnPbG3qVGmIYCXG506Mhx53ceDbSKHZaJhD64l8A7zh+d/WZmmCTq eoH251REzJFUgB+TTUcWu6q55bD6MVHVhOrYGzNdTPh/iy40hqx++1YUmEXCfmzfZsekvAfQ2cdPb 7QfNAnodGujKu6nkSSGr5syzGuzSYn1lTpDTK4gdh698bI8dt247N9/uAu/hIwkH86+qL9jLXJNKE 1fUiAdFA==; Received: from [50.53.4.147] (helo=[192.168.254.15]) by bombadil.infradead.org with esmtpsa (Exim 4.97.1 #2 (Red Hat Linux)) id 1ryya3-0000000EdIe-0WYS; Mon, 22 Apr 2024 18:39:55 +0000 Message-ID: <7d24e1fb-520c-4ec2-a6aa-89856092891a@infradead.org> Date: Mon, 22 Apr 2024 11:39:54 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/7] block: Init for CBD(CXL Block Device) To: Dongsheng Yang , dan.j.williams@intel.com, axboe@kernel.dk Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, Dongsheng Yang References: <20240422071606.52637-1-dongsheng.yang@easystack.cn> <20240422071606.52637-2-dongsheng.yang@easystack.cn> Content-Language: en-US From: Randy Dunlap In-Reply-To: <20240422071606.52637-2-dongsheng.yang@easystack.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, On 4/22/24 12:16 AM, Dongsheng Yang wrote: > diff --git a/drivers/block/cbd/Kconfig b/drivers/block/cbd/Kconfig > new file mode 100644 > index 000000000000..98b2cbcdf895 > --- /dev/null > +++ b/drivers/block/cbd/Kconfig > @@ -0,0 +1,4 @@ > +config BLK_DEV_CBD > + tristate "CXL Block Device" > + help > + If unsure say 'm'. I think that needs more help text. checkpatch should have said something about that... And why should someone say 'm' to the config question? Will lots of (non-server) computers have CXL block device capability? thanks. -- #Randy https://people.kernel.org/tglx/notes-about-netiquette https://subspace.kernel.org/etiquette.html