Received-SPF: pass (google.com: domain of linux-kernel+bounces-153959-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240422151752.53997-1-ubizjak@gmail.com> <Zia-VeObR-m6Bf39@boqun-archlinux>
In-Reply-To: <Zia-VeObR-m6Bf39@boqun-archlinux>
From: Uros Bizjak <ubizjak@gmail.com>
Date: Mon, 22 Apr 2024 21:57:04 +0200
Message-ID: <CAFULd4ZhTAY9irw8V=MLZpjQK+q0AM_Aw8g2E=ivHjv7+5m9Zg@mail.gmail.com>
Subject: Re: [PATCH] locking/pvqspinlock/x86: Use _Q_LOCKED_VAL in
 PV_UNLOCK_ASM macro
To: Boqun Feng <boqun.feng@gmail.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org, 
	Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@kernel.org>, Will Deacon <will@kernel.org>, 
	Waiman Long <longman@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 22, 2024 at 9:45=E2=80=AFPM Boqun Feng <boqun.feng@gmail.com> w=
rote:

> > diff --git a/arch/x86/include/asm/qspinlock_paravirt.h b/arch/x86/inclu=
de/asm/qspinlock_paravirt.h
> > index 466af57b8ed6..0a985784be9b 100644
> > --- a/arch/x86/include/asm/qspinlock_paravirt.h
> > +++ b/arch/x86/include/asm/qspinlock_paravirt.h
> > @@ -40,7 +40,7 @@ __PV_CALLEE_SAVE_REGS_THUNK(__pv_queued_spin_unlock_s=
lowpath, ".spinlock.text");
> >  #define PV_UNLOCK_ASM                                                 =
       \
> >       FRAME_BEGIN                                                     \
> >       "push  %rdx\n\t"                                                \
> > -     "mov   $0x1,%eax\n\t"                                           \
> > +     "mov   $" __stringify(_Q_LOCKED_VAL) ",%eax\n\t"                \
> >       "xor   %edx,%edx\n\t"                                           \
> >       LOCK_PREFIX "cmpxchg %dl,(%rdi)\n\t"                            \
> >       "jne   .slowpath\n\t"                                           \
>
> There is also a "cmp $0x1,%al" afterwards.

Not anymore. Please note that the patch is against -tip, where we have:

https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?id=3D91=
095666125a666c8f20c2323b742c53165c0325

Thanks,
Uros.