Received-SPF: pass (google.com: domain of linux-kernel+bounces-153984-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 22 Apr 2024 22:09:57 +0200
From: Robert Richter <rrichter@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@intel.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	linux-kernel@vger.kernel.org, jgross@suse.com, tglx@linutronix.de,
	x86@kernel.org, Kim Phillips <kim.phillips@amd.com>,
	Robert Richter <rric@kernel.org>
Subject: Re: [PATCH 2/4] perf/x86/ibs: Use CPUID region helper
Message-ID: <ZibEFZ6DoxDeBxxp@rric.localdomain>
References: <20240403153508.7328E749@davehans-spike.ostc.intel.com>
 <20240403153511.75CB9DA0@davehans-spike.ostc.intel.com>
 <20240416151242.GGZh6VaiO2gC4ej2BT@fat_crate.local>
 <f142e9c4-4829-4ace-8757-485246ad3572@intel.com>
 <20240416174850.GEZh66AmnDjrLxoXaw@fat_crate.local>
 <ZiEMnWaHkn99_oyW@rric.localdomain>
 <20240422172055.GAZiacdxkQU0XAbybW@fat_crate.local>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240422172055.GAZiacdxkQU0XAbybW@fat_crate.local>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?5aOX5yfeoAMk5pTyM/+d63cuEYVet5eKaAiePpH+h2TqOKMnM9DNb56vaxDC?=
 =?us-ascii?Q?1Zh11Jve8Iz25SUoNc5LEN2SV+4mWjuECBP+6+So4p1aHsfp47SJ+/WsHK2t?=
 =?us-ascii?Q?ai+7OrmSnbiAkbNBah+IoA/6obJl8FYG+PMEnsCtEhznTYGB0Hg/hXc+mK8A?=
 =?us-ascii?Q?C5Wc1pc3a7Uz6cY7mFUK2zo/X5VAQjMQoovUC/XSij6yhjhwp8+qZZpD2amH?=
 =?us-ascii?Q?5mE3RWYwmC3YYGdhRhGr29GeKiGd8dC7XRPWPQDSj7yWrWuVS7ol1boU1SLx?=
 =?us-ascii?Q?yv2GSTwf2d/9DdBvqGFkNNSBA0+q1XifvlNIaigoN8Q9rCg+rVN9e5ktT9w7?=
 =?us-ascii?Q?6KWQaYjA50EjFr1jIsiHh7aSNlsBLL8Dod1vOEXZfT13DXCRmVeWDVy6ftsK?=
 =?us-ascii?Q?yjagtb1w7gunG3ok/0uD9R/nCUt4F91Yvs0BzIdkgngR7CkxxL1znQe5bnKw?=
 =?us-ascii?Q?19CybU8ooRhijga66eWfEv5S6eMdmUs5EcAPIoB0G6KgWZr56n7SYQq+7OD/?=
 =?us-ascii?Q?/sl68j3oaqP8GcN5Bv5o0N3vT47ExPl2mWVBWT+2a9QN+UyV6cv37IxAddH8?=
 =?us-ascii?Q?cJoJQ0kYTBHS9dD8uk71Xi26FtOqK45VW9db7nfOhFuu7Gr+D4eGZEzNNUsE?=
 =?us-ascii?Q?ESb1eLEGgZ04X/sHArgSBih7v3CtEopgoafutBG1mJ/4b1ueyfEkridMnup0?=
 =?us-ascii?Q?Uo/iYhjGvudF0UcLmwkVA7XnVF6zix9Jq8CkoYso36sxeG/di2+p+vKpXJCM?=
 =?us-ascii?Q?xLo6MEsDI+yhxLL5NRD3YTO2KHiRUE5Lxcw7T5zpWKozXm7EEAgfyzT+THX6?=
 =?us-ascii?Q?ICczRHcAK1FTxiBYquPIGcguJoZ/1E/OGdGKNueCTvf/e729JYez51BPrGRG?=
 =?us-ascii?Q?bVaOFcvxni7s3JcTeWTrza0qtcuiakEVSxFnOcVsXX+a0ZM+rEElDzERCQmw?=
 =?us-ascii?Q?6po7KV21Yucms9+p9IypBgr6bZsGlTU+S/bH8+XutpzkGr1YtRYbnAlgPrxm?=
 =?us-ascii?Q?5+wR8rkisaw+TtQiUGp4r2jCo3x/YXTJtxrZe+JaNtKiwDDG0CDk/4WGH2rI?=
 =?us-ascii?Q?+bcce588bI3L/wLMdoF3C2PPfP1ezKgBukkIcekm7IjxYMFv8Fs71ru1vMcx?=
 =?us-ascii?Q?sWqQjm6/vK8l5YB9exdAsQTu/BdzSST0eHG9P4Vh6kl8B2y6oPVrI9mbvAb/?=
 =?us-ascii?Q?5tKO0KrjWKClF6lAW7Sl7aGFaREHsiGaaISb2l8oYpwAT9iG5eM0ZYvx3efT?=
 =?us-ascii?Q?C0wYOSofIz4bVJ8S53248g8DPAZoS87L48am1wEFDcbkmw+2Cnqa8+XuucVH?=
 =?us-ascii?Q?PVpw5BokqkrI35OzzMaCSi6WCSby3uTtwFe7/KzSSXh29PWjzf/mBtA9lOFs?=
 =?us-ascii?Q?bpoC0BgZ9Ex1lLA20pMukpl0c/Iz4sWIXSMHQd9ZM/QMAoNbXUhwSdaxYe+7?=
 =?us-ascii?Q?/2CChJOviPfka6v5tSfo6tL4WwXY0P1NgNaDrue62sOu82ukwWqjHWMB4kLH?=
 =?us-ascii?Q?SZ0e0Vau1qmE/JfLkprY3BsO2lgt0WpGs7yWNB3/DW6ylo0+/6nzkn/RMMGO?=
 =?us-ascii?Q?rd8WLaOidr3++z5NXeQGh4+CgwrgAbljb79SjbWS?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 11baa030-86e1-4f00-ccd1-08dc6308322d
X-MS-Exchange-CrossTenant-AuthSource: CYYPR12MB8750.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2024 20:10:03.4156
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: c6LHRgDUouv49t7DdLaFT8RLoQayzLIDt9ElYM39lrPINFn4lnsyjhwYNWgE5ZkSf60YF4DUep8M8Xuk9gh8Mw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7312

On 22.04.24 19:20:55, Borislav Petkov wrote:
> On Thu, Apr 18, 2024 at 02:05:49PM +0200, Robert Richter wrote:
> > There is the X86_FEATURE_IBS bit (Fn8000_0001_ECX, bit 10) which is
> > available from the beginning of IBS (all Fam10h production releases,
> > revB onwards).
> > 
> > And right, IBS_CPUID_FEATURES (CPUID Fn8000_001B) was introduced with
> > revC. The capabilities of revB are set in IBS_CAPS_DEFAULT.
> > 
> > It doesn't look broken to me, simply the ibs caps field was introduced
> > later which can be determined checking the return code of
> > get_cpuid_region_leaf().
> 
> Right.
> 
> > My preference would be:
> > 
> > 	[...]
> > 	if (!get_cpuid_region_leaf(IBS_CPUID_FEATURES, CPUID_EAX, &caps))
> 
> Right, checking get_cpuid_region_leaf() retval should happen.
> 
> > 		return IBS_CAPS_DEFAULT;
> > 
> > 	if (caps & IBS_CAPS_AVAIL)
> > 		return caps;
> > 
> > 	return 0;
> > 	[...]
> > 
> > Not too complex?
> 
> I'm wondering should we even support those old things? All revBs should
> be probably dead by now. But ok, it's not like it is a lot of code or
> so...

Since we check get_cpuid_region_leaf()'s return code here we know if
the cpud leaf exists and return IBS_CAPS_DEFAULT if not. That would
not change the refB behaviour.

Though I think that case is rare or even not existing, I would just
keep the implementation like that and as it was for for years.

> 
> > This slightly modifies the functionality so that 0 is return if
> > !IBS_CAPS_AVAIL (instead of IBS_CAPS_DEFAULT).
> 
> If !IBS_CAPS_AVAIL, then this is revB. But then you want to return
> IBS_CAPS_DEFAULT there.

No, on a rebB get_cpuid_region_leaf() would be false, meaning the
cpuid leaf is missing, function returns with IBS_CAPS_DEFAULT then.

-Robert