Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp2522561lqt; Mon, 22 Apr 2024 13:11:31 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW5Jm9jiE+zHRwqEIVsNcCjdZtIi+yfoE6/yBj9QX1gnorXvwCJld0r/+G1dT5gcnBIBzMctAVVDG0djJ28bz7fDOjao1ODCZbTZghs1g== X-Google-Smtp-Source: AGHT+IEyT2amix8AisQUJ2X75Jnk9/NXGmRML9ttKrlFIWjlz0mS+jgUyex00hlYrFnznTGY23jo X-Received: by 2002:a17:902:7487:b0:1e4:344b:734c with SMTP id h7-20020a170902748700b001e4344b734cmr14527574pll.19.1713816691367; Mon, 22 Apr 2024 13:11:31 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713816691; cv=pass; d=google.com; s=arc-20160816; b=lMpO+VlWnYH9j4Jk8d1lnSk+UxhJ8c4nbH/wVM+Oa4vuUXkjStFGanpY13XtFZnpl4 oDBMQKMOms2U2vQpiZTn3QKWxbBo0V/Rgt93e3ORg6cpupftTzOagqS5+xe5Cpd026mU pRf8nPMd670m2Wcf6yPyFTwojfysN07Opo872Q8wyVwsdIMY2iPz1iDEO+1R/lTqNhJv ZV+IvO+tPSEgyNeoC85pjwGZdQ7l27vZpirpXwHKYm+qkUEPL9Uk3kkbEv90Y8mPLFyr n6NxxqjrzvZVqTsHHN3yxDaFBQ1wEMzKkQVyhOj2RGawX5206rYFu7njVFZgBlmbE2ZS QIqA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=thread-index:thread-topic:content-transfer-encoding:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:subject :references:in-reply-to:message-id:cc:to:from:date; bh=4JpIgXCB9jUQPkFUGAI31NP5EjtRLupEYrFT1gtqbDU=; fh=9OohdXKLKauh+VZ1dvFKfz30G61NOrT4yOHFFCM5qrk=; b=KqtRHQ9YBWn5oStsW2eCHRFk2w2RNPaEjsU8PPrwCjSZxir0DW9ep988EW51HnIj7S 3ijrSqBbRQuLOP9SfDgDn1bUHCpbldcLH8k4Xv9sWH3ZgsWfxDEUbYR4yQZjYQ6x2+4L qVqMHmbd7CjUXy97Qo9lBJcD2usDfnAMVB4y2KifGSAQ9TgpQr9ZOwMyw46WkLcNmUQi sBvi8DZdUNzTaNtiuaYe41ELT+NTXAsHN8CATOHaQEuiko80VcwGNFyJ4BwAlOMOS9K3 NlcXTC021lzEycZ2QEXRs8Dk1CZnsoYF16RSU1fiZf+AiF1ejSjzwbbFOtbkSpjjELGA 9/bA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-153986-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-153986-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id b5-20020a170902e94500b001dd62fbcf75si8596022pll.536.2024.04.22.13.11.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Apr 2024 13:11:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-153986-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-153986-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-153986-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 949692813E9 for ; Mon, 22 Apr 2024 20:11:29 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A407A155A53; Mon, 22 Apr 2024 20:11:07 +0000 (UTC) Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAAA51553A3; Mon, 22 Apr 2024 20:11:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.201.40.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713816667; cv=none; b=VubCmGMOHrVDdjLOR4vpFRap5QrPO2TrA5RZVJCEnoUH7RZd7kphb8Dz7BfhGrvDHcD4by5Chuw4eKsw3gQ31Al+obuc/aNrcr+DHcCVoRnTlZ2eMAkYSA54kOFoBbQG79O2In4b2qtybnMp3APC/xPI0+8pdi8//gRo8WwU9nA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713816667; c=relaxed/simple; bh=4JpIgXCB9jUQPkFUGAI31NP5EjtRLupEYrFT1gtqbDU=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: MIME-Version:Content-Type; b=ZsyV8WlcNro1ATU34Dqs/Yc0fBcib2u+tLiF6wbEvJ22pwhSZ15x5IN+7QRZzVumNysYWnRkFIwCRQNKptc2kJasm+UmhXdXCyaRcJErMHtLQ5rH0YQ8IjtIarNtPWXMIAmXJi35nOaTVZTGzVLT8W/kaq+OkpDA+BwI3frb3jg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nod.at; spf=fail smtp.mailfrom=nod.at; arc=none smtp.client-ip=195.201.40.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nod.at Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nod.at Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id 8788D647A82A; Mon, 22 Apr 2024 22:11:01 +0200 (CEST) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id fvDzHBxSevvb; Mon, 22 Apr 2024 22:11:01 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id 10A4F647A80D; Mon, 22 Apr 2024 22:11:01 +0200 (CEST) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id rBhDvx3ZBnCr; Mon, 22 Apr 2024 22:11:00 +0200 (CEST) Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130]) by lithops.sigma-star.at (Postfix) with ESMTP id CEF3A609B3C4; Mon, 22 Apr 2024 22:11:00 +0200 (CEST) Date: Mon, 22 Apr 2024 22:11:00 +0200 (CEST) From: Richard Weinberger To: Suren Baghdasaryan Cc: Andrew Morton , Stephen Rothwell , kent overstreet , SeongJae Park , anton ivanov , Johannes Berg , linux-mm , linux-um , Linux Next Mailing List , linux-kernel Message-ID: <95819052.15033.1713816660761.JavaMail.zimbra@nod.at> In-Reply-To: <20240326073750.726636-1-surenb@google.com> References: <20240326073750.726636-1-surenb@google.com> Subject: Re: [PATCH 1/1] arch/um: fix forward declaration for vmalloc Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailer: Zimbra 8.8.12_GA_3807 (ZimbraWebClient - FF97 (Linux)/8.8.12_GA_3809) Thread-Topic: arch/um: fix forward declaration for vmalloc Thread-Index: VhMS7jUdUYDlNrao2e2bRQ6VhbmZJA== ----- Urspr=C3=BCngliche Mail ----- > Von: "Suren Baghdasaryan" > Betreff: [PATCH 1/1] arch/um: fix forward declaration for vmalloc > Patch [1] replaced vmalloc() function with a new definition but it did > not adjust the forward declaration used in UML architecture. Change it > to act as before. > Note that this prevents the vmalloc() allocations in __wrap_malloc() > from being accounted. If accounting here is critical, we will have > to remove this forward declaration and include vmalloc.h, however > that would pull in more dependencies and would require introducing more > architecture-specific headers, like asm/bug.h, asm/rwonce.h, etc. > This is likely the reason why this forward declaration was introduced > in the first place. >=20 > [1] https://lore.kernel.org/all/20240321163705.3067592-31-surenb@google.c= om/ >=20 > Fixes: 576477564ede ("mm: vmalloc: enable memory allocation profiling") This commit id is not in Linus tree. Do I miss something? Thanks, //richard