Received-SPF: pass (google.com: domain of linux-kernel+bounces-153988-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240422151752.53997-1-ubizjak@gmail.com> <Zia-VeObR-m6Bf39@boqun-archlinux>
 <CAFULd4ZhTAY9irw8V=MLZpjQK+q0AM_Aw8g2E=ivHjv7+5m9Zg@mail.gmail.com> <ZibB5zp5DcCmC9gP@boqun-archlinux>
In-Reply-To: <ZibB5zp5DcCmC9gP@boqun-archlinux>
From: Uros Bizjak <ubizjak@gmail.com>
Date: Mon, 22 Apr 2024 22:12:11 +0200
Message-ID: <CAFULd4bxtH_Eo3j6kXDBOs_a4u4qsneOfm9t0c-fxGHo5L_FuQ@mail.gmail.com>
Subject: Re: [PATCH] locking/pvqspinlock/x86: Use _Q_LOCKED_VAL in
 PV_UNLOCK_ASM macro
To: Boqun Feng <boqun.feng@gmail.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org, 
	Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@kernel.org>, Will Deacon <will@kernel.org>, 
	Waiman Long <longman@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 22, 2024 at 10:00=E2=80=AFPM Boqun Feng <boqun.feng@gmail.com> =
wrote:
>
> On Mon, Apr 22, 2024 at 09:57:04PM +0200, Uros Bizjak wrote:
> > On Mon, Apr 22, 2024 at 9:45=E2=80=AFPM Boqun Feng <boqun.feng@gmail.co=
m> wrote:
> >
> > > > diff --git a/arch/x86/include/asm/qspinlock_paravirt.h b/arch/x86/i=
nclude/asm/qspinlock_paravirt.h
> > > > index 466af57b8ed6..0a985784be9b 100644
> > > > --- a/arch/x86/include/asm/qspinlock_paravirt.h
> > > > +++ b/arch/x86/include/asm/qspinlock_paravirt.h
> > > > @@ -40,7 +40,7 @@ __PV_CALLEE_SAVE_REGS_THUNK(__pv_queued_spin_unlo=
ck_slowpath, ".spinlock.text");
> > > >  #define PV_UNLOCK_ASM                                             =
           \
> > > >       FRAME_BEGIN                                                  =
   \
> > > >       "push  %rdx\n\t"                                             =
   \
> > > > -     "mov   $0x1,%eax\n\t"                                        =
   \
> > > > +     "mov   $" __stringify(_Q_LOCKED_VAL) ",%eax\n\t"             =
   \
> > > >       "xor   %edx,%edx\n\t"                                        =
   \
> > > >       LOCK_PREFIX "cmpxchg %dl,(%rdi)\n\t"                         =
   \
> > > >       "jne   .slowpath\n\t"                                        =
   \
> > >
> > > There is also a "cmp $0x1,%al" afterwards.
> >
> > Not anymore. Please note that the patch is against -tip, where we have:
> >
>
> Oh, thanks for the information. Maybe it makes sense to mention the
> patches dependency in the commit log?

Hm, yes ... I should mention this as "[PATCH -tip]" in the subject
line to avoid confusion with this particular patch.

Thanks,
Uros.