Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp2526145lqt; Mon, 22 Apr 2024 13:18:37 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVBA+V20KG3npitDUx+a3DeOeXbX4pJDK5sXXbU6jD2NvV+Ir4wiT4v2c167szG2bTvhp/3dTj2Mxr1KIV4jZV9qH3yCwZxnR3k+lRXIw== X-Google-Smtp-Source: AGHT+IHI6QkJ1LJgm8BFgoGuI6i6P/f6/Xi0YtJ9PydXwUUWOACjIY53Hyv6OFH9fVscLIBeqd1P X-Received: by 2002:a17:903:42c5:b0:1e5:1041:7ed4 with SMTP id jy5-20020a17090342c500b001e510417ed4mr747889plb.14.1713817117433; Mon, 22 Apr 2024 13:18:37 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713817117; cv=pass; d=google.com; s=arc-20160816; b=GqS5WvHuaKg4s7PhwIUwG6hLabplWqM/Ks1JABcINerQCCbfPRuGSkx432hi/UE7Z+ V2t9TZYYdoQQKkGcR61381V1EZB93G178NE1oSxiKCt2l1sDHKoWmv8VhxFsI4p9Y9sk MKp+riFdbFrd84139IX/wgCt225gsdv3kAqEYgc886gtiMmrwLD4rEg/f/5MJQ8/atzc FqL4DEi8qogcXzZG6+dpG5Onk+cMpPG0ANJliOU1gf+5m9QJWbpRRNe5zf1FXEJQQtpW HMriGmcnLDu8RBmP7l5IqNcl3W5U0k6vf7HnMiENv3aWs5u6np5REB1AvbDELA3DWdq5 wXbA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=mxTgejPOrJaz54lO42dd/JWWLGhqdq5gju3c/nNkRII=; fh=wmhR/HTi93Fv4MIZkAtqFsiaKBwvNkMyX2lT47kWBi4=; b=ZN/jd+O5Y5UOnowgk7STDnyzcrbd5BxLFm/cm7XE1MfUI2PPZ0QhmOzGhB/16KpElm XQYQLUS66d9nkmgCSFXD+qBe/7KaYsU+yzurxXavAuzYs5XxXEIuA9ef4jItv4VJwDAn tfwK9+zdW1Uyj7t6C7T8AcLuwVHa6pL4K2PxQYFMinM110XKkViSE7+SISvDbHcIOkGa t8OjIzCmg65XvHzmD2rlBSJ3/XuZl06ae4lvMB9FwrJBK5c7z9grIVkEMsRZl97Y13uv TCXxH5HAjDdrgbbo1FcDOX1A/GRKvMQV8Yfi4Veo6L6P77WJ46xDpMzioH2ImDPoekBA 9+DA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=H7FOA9Ax; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-153991-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-153991-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id p14-20020a170902780e00b001e43c7fbfe6si8003348pll.280.2024.04.22.13.18.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Apr 2024 13:18:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-153991-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=H7FOA9Ax; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-153991-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-153991-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 18C8D281670 for ; Mon, 22 Apr 2024 20:18:37 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8489B1553BB; Mon, 22 Apr 2024 20:18:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="H7FOA9Ax" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D166615380B for ; Mon, 22 Apr 2024 20:18:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713817110; cv=none; b=p1lmdfcFdFrHQd1v2be8h/XRASKP0Gbz5IHLX8Xd5J2WzP3+ycGIq3nWIxHThANi89SCS896gp64UVZq1SiMs3/Kpw0QPN9HtpOV4+QxNkDuRizY4pNT67B+vGhnfamRdTbuCzR3Y03DJxmmRADGZswJ2fkR1i4xXmO1QRd12dA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713817110; c=relaxed/simple; bh=eZ/a9lRplWWMryXPKGei0Ish1bJuXUnXclDH9pla2No=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VEt8pdD8ZZ/BHcATSe3ZrbCkAUUUiXz3pqi9PtwKyczZIfuyMDaUavbQavAS0AzMg5/rsbwEpl15B9T8D1VHLjT+ufNUUpDs4h3Zd+MsIB+WdQsO4CO/nP4mKA4eZGaDPrfEo+zpn9pdJORhMDRUelVEAmQD8ThXL2rFc/9Z1lk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=H7FOA9Ax; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1713817109; x=1745353109; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=eZ/a9lRplWWMryXPKGei0Ish1bJuXUnXclDH9pla2No=; b=H7FOA9AxBlZYiL6b9aAX4h9V3nlEdOpY32ykSz37p3M/TmdPOwZ0Cjf4 6+aG/kjWC6bGcmB3c5vKKX4KQbG0h9R6LNYLgs/tigpah/MxF7G0/lRp/ BXqGyR4GwdNsUQ0crZI1xrpjonAkU3hjWAk1JZVZ18CmMX7mDCv7rev+v aAzXqGFT+pvkl5ec3Jxg2F8SqIEEqWmb5XiuJGh73tzfa8ENe6RAeAiel XSsWyp5REl/gLvgMOdchjglMXcEZO3Q+Y9ETD6GxeAcEPWhxxRhLYj30w mZ2uPy069eFhwjoboKEoH/QfdUBYYrVWCb19GfGpqwKWKRrgoP/9OdRT8 Q==; X-CSE-ConnectionGUID: WUmhwRq8SIeMHN5lXSGz1g== X-CSE-MsgGUID: ER3yB2g9RU2Yr5VQ5Db9eA== X-IronPort-AV: E=McAfee;i="6600,9927,11052"; a="20779980" X-IronPort-AV: E=Sophos;i="6.07,221,1708416000"; d="scan'208";a="20779980" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2024 13:18:28 -0700 X-CSE-ConnectionGUID: UA3f2popTJepStR+vwnZbg== X-CSE-MsgGUID: /UPYEq0+QIG69ne8bHoKWg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,221,1708416000"; d="scan'208";a="24156330" Received: from vivekcha-mobl.amr.corp.intel.com (HELO [10.209.55.5]) ([10.209.55.5]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2024 13:18:27 -0700 Message-ID: Date: Mon, 22 Apr 2024 13:18:26 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv2] x86/tdx: Preserve shared bit on mprotect() To: Tom Lendacky , "Kirill A. Shutemov" , tglx@linutronix.de, mingo@redhat.com, bp@alien8.de Cc: sathyanarayanan.kuppuswamy@linux.intel.com, hpa@zytor.com, seanjc@google.com, elena.reshetova@intel.com, rick.p.edgecombe@intel.com, x86@kernel.org, linux-kernel@vger.kernel.org, Chris Oo , Dexuan Cui References: <20240419201353.3937135-1-kirill.shutemov@linux.intel.com> <17930444-3740-f874-91e7-3ed81304b1a9@amd.com> Content-Language: en-US From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <17930444-3740-f874-91e7-3ed81304b1a9@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/22/24 12:46, Tom Lendacky wrote: > Appears to be no functional change on the AMD side. > > Reviewed-by: Tom Lendacky Thanks a bunch for that! I was just noodling over this one and that was one of my worries.