Received-SPF: pass (google.com: domain of linux-kernel+bounces-154021-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <1a5e719f-efa0-4c60-8add-ef7c0464d1ce@ti.com>
Date: Mon, 22 Apr 2024 15:57:10 -0500
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/2] dt-bindings: arm: ti: Add BeagleY-AI
To: Robert Nelson <robertcnelson@gmail.com>,
        <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
        <devicetree@vger.kernel.org>
CC: Rob Herring <robh@kernel.org>, Nishanth Menon <nm@ti.com>,
        Jared McArthur
	<j-mcarthur@ti.com>,
        Jason Kridner <jkridner@beagleboard.org>,
        Deepak Khatri
	<lorforlinux@beagleboard.org>
References: <20240328191205.82295-1-robertcnelson@gmail.com>
Content-Language: en-US
From: Andrew Davis <afd@ti.com>
In-Reply-To: <20240328191205.82295-1-robertcnelson@gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit

On 3/28/24 2:12 PM, Robert Nelson wrote:
> This board is based on ti,j722s
> 
> https://beagley-ai.org/
> https://openbeagle.org/beagley-ai/beagley-ai
> 
> Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
> CC: Rob Herring <robh@kernel.org>
> CC: Nishanth Menon <nm@ti.com>
> CC: Jared McArthur <j-mcarthur@ti.com>
> CC: Jason Kridner <jkridner@beagleboard.org>
> CC: Deepak Khatri <lorforlinux@beagleboard.org>
> ---
>   Documentation/devicetree/bindings/arm/ti/k3.yaml | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml b/Documentation/devicetree/bindings/arm/ti/k3.yaml
> index 52b51fd7044e..ca23b7e6a35e 100644
> --- a/Documentation/devicetree/bindings/arm/ti/k3.yaml
> +++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml
> @@ -134,6 +134,7 @@ properties:
>         - description: K3 J722S SoC and Boards
>           items:
>             - enum:
> +              - beagle,j722s-beagley-ai

Recommend "beagle,am67-beagley-ai". The "J722s" is the family
name, the part used on this board is the AM67. We do the same
for the SK boards, for example, the SK-AM69 uses the AM69
part from the J784s4 family, so it is called k3-am69-sk.dts
with compatible = "ti,am69-sk", "ti,j784s4";

This would otherwise be the first board with a specific part
attached but uses the SoC family name instead of that specific
part name in the DT file/name. Only the EVMs should have the
family name since we sell versions of those with all the different
parts swapped onto it. I don't imagine you will be selling
BeagleY's with TDA4VEN, TDA4AEN, DRA82x, etc.. All your
docs and other collateral use "AM67", using the same here
would help avoid confusion.

Andrew

>                 - ti,j722s-evm
>             - const: ti,j722s
>