Received-SPF: pass (google.com: domain of linux-kernel+bounces-154037-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Mon, 22 Apr 2024 23:17:47 +0200
From: Robert Richter <rrichter@amd.com>
To: Alison Schofield <alison.schofield@intel.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Dan Williams <dan.j.williams@intel.com>, linux-acpi@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org,
	Len Brown <lenb@kernel.org>
Subject: Re: [PATCH v3 2/5] ACPI/NUMA: Print CXL Early Discovery Table (CEDT)
Message-ID: <ZibT-38ZfEkIZrtG@rric.localdomain>
References: <20240419140203.1996635-1-rrichter@amd.com>
 <20240419140203.1996635-3-rrichter@amd.com>
 <ZibO4C7bGb4tsXuJ@aschofie-mobl2>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZibO4C7bGb4tsXuJ@aschofie-mobl2>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?LnH3TMEhvYM9tWShMnegAW+WbjHjoJ/XjJc3/6C4YQjg/yreQd/pgfKFI9B7?=
 =?us-ascii?Q?dTKQ8HuSu9wRtlsDWzDbMGTYNuYiEbWtSJhmDIu+RJifbffVdj+48LSzXa/T?=
 =?us-ascii?Q?u0pzRMcaBDiUH+p3NaRJmXs89sqiZR5GE9TvOgN8+It4vUw7E8DaWL+/riv1?=
 =?us-ascii?Q?Wmna6oDj6NoaWQciYHZZXyXcJUr4CQ+8jTH3EB+q4c34GGSPL4I9vpz+rSpw?=
 =?us-ascii?Q?H/D+7LyiusnKZJu5FKdIRArGx97jzJ3WjZKUXYXMQqf79v4h8I7d0oNydXIc?=
 =?us-ascii?Q?OKPZhXMwgUbzI/iJGxaUg5ikq2QlShOtkLz2PrwwGtFAZM/8Gdk2CgG5R0h/?=
 =?us-ascii?Q?kPEF/ev3p/hI0jbvz2gRRFAHJ2C8FIT6n+D4luUgIQ0I5IS+3pNupTPCbsom?=
 =?us-ascii?Q?Mtqw6UNfwCLiFNfRQ49EXHtrSJVQ2oERg5HMLJlt5yeEU9pzcr6uOTV2yL8y?=
 =?us-ascii?Q?Aj4y1te93MM9aX0J2x9qCj6StJj5hZvZjeULEhQY/tYI009FFKuDUpy938to?=
 =?us-ascii?Q?lfpUZPbFQkST8hVl+0NuiIfWE8fCISPdoogVjS/8HXOq48pPyhRxS1uqmGEf?=
 =?us-ascii?Q?tIw5mt0JSBbeyVdosccdVt+5mAyXAQ+m8eL322nqte1D0PeNbcyaeH6HTFNO?=
 =?us-ascii?Q?8NQq2+OT1nevIrnTQ/BaipSqGzhcwrHkn7Z0Q7+JFvsVujW/hvOdxVwoS/Vu?=
 =?us-ascii?Q?NO2bO/Q5AlTeAtU3c1aTtzf2n9cweZbrryJMsaOFGhDtmlBc2qYZ7XzweNRb?=
 =?us-ascii?Q?R4iaVqQRAgiD6KkuTdshHi23vVSQ2ctul6rR7u6C9A7aTX7oQ8mocp4qW/yS?=
 =?us-ascii?Q?Nbnlta4smU6avOrKwwtcXHjng8JqDWiNg1McUaKxMUCL8wU7DH9xzbGRgKIh?=
 =?us-ascii?Q?sOmpeYagsCJgFeMavpLWa7t0bbgEx2YbO+/iKZfVvYuXedRX7mW//HR5kjlw?=
 =?us-ascii?Q?GxlPawlsqmCAAQWCU3sVbN1ZoR5BA5MEN1xMpPEevxnBQILj8i0ocQiUNrnb?=
 =?us-ascii?Q?cdRaFkQySdgaieCtm6oSlvsYzjVrhKZHkDPGeiFxZqOYMWOfXtHuPY/ZuK7A?=
 =?us-ascii?Q?uk9tJ6EXMBGqsRXhlOt9d4J4TVGsVCvusCL0zNtJ+KRyg4nJZF0ayynglD6Y?=
 =?us-ascii?Q?LSv/AYSGB0zZmRUtP7p9+Ti0T0/Hc0XrDQMDgTUaGxjG23SpMHkjAD8pX1+y?=
 =?us-ascii?Q?D3nI5sXwXxTad4PnWKdh6QnzLOglKuirzgvItq5AmJKMi6vC8J/6A3R4FjO4?=
 =?us-ascii?Q?2dNnboW1WqfyMQBG7qF9tYdquADCl/wDOb8P/bp0jODz3sAaxCME/K2f19h0?=
 =?us-ascii?Q?JPEZ7QbTdaQKs8evDuilcHL+EP4Co1PaJvPwul5YWUptZOV00W+6nHOlg94R?=
 =?us-ascii?Q?patbLdxZi57Pa45zuBLPZ9iU9mtEjTq/YzuoiliChSdwBHyqdOAXAdyGO4d+?=
 =?us-ascii?Q?Wy8MpOVNcyFaX6SPHtPSdppiu6BrC7LSFBuiCRhYHcC5C+XVrpwA/ljas5Ha?=
 =?us-ascii?Q?VqXg12RjicPlyzLWNNQV/xowNgyoCXFiFbTG6l5GV/WokFovRBe58sj0Ph2y?=
 =?us-ascii?Q?xslv8utk7qRELjivJvS6bi9BdBXp1//VGG6t2FHJ?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cf4c45ed-e39b-4b52-773f-08dc6311ac15
X-MS-Exchange-CrossTenant-AuthSource: CYYPR12MB8750.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2024 21:17:53.3627
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eT1aCyNOOcY9wnWsPvEWX2hzqKrc5EqDP06uwmeZEA3kHv0lqCqvV+VvhPUgNGGlFUs7I6KrSOXlIm3r9N3bJA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7607

On 22.04.24 13:56:00, Alison Schofield wrote:
> On Fri, Apr 19, 2024 at 04:02:00PM +0200, Robert Richter wrote:
> > The CEDT contains similar entries as the SRAT. For diagnostic reasons
> > print the CEDT same style as the SRAT.
> > 
> > Adding also a pr_info() when successfully adding a CFMWS memory range.
> > 
> > Suggested-by: Alison Schofield <alison.schofield@intel.com> # CEDT node info
> 
> Ah, I see you annotated the Suggested-by. I did suggest the pr_info
> when we extend or add a node during CFMWS parsing.

That's what I meant here and what I have added to this patch with this
update.

> 
> There is an update in acpitools for CEDT decode and dump[1] offering
> pretty dumps of this info. Is this printing for convenience or for
> something else?

No, this helped early boot debugging of kernel and ACPI issues since
CEDT entries are important for this. For acpitools you need the
machine to be up already. If it is not part of the kernel log there
would be a 2nd step needed to get this information from. The patch
also lifts CEDT logging to the same level as for SRAT.

I hope that makes sense?

Thanks,

-Robert

> 
> [1] https://github.com/acpica/acpica/pull/939
> 
> -- Alison