Received-SPF: pass (google.com: domain of linux-kernel+bounces-154052-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Mon, 22 Apr 2024 23:30:24 +0200
From: Robert Richter <rrichter@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@intel.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	linux-kernel@vger.kernel.org, jgross@suse.com, tglx@linutronix.de,
	x86@kernel.org, Kim Phillips <kim.phillips@amd.com>,
	Robert Richter <rric@kernel.org>
Subject: Re: [PATCH 2/4] perf/x86/ibs: Use CPUID region helper
Message-ID: <ZibW8D9-CTd8G-_v@rric.localdomain>
References: <20240403153508.7328E749@davehans-spike.ostc.intel.com>
 <20240403153511.75CB9DA0@davehans-spike.ostc.intel.com>
 <20240416151242.GGZh6VaiO2gC4ej2BT@fat_crate.local>
 <f142e9c4-4829-4ace-8757-485246ad3572@intel.com>
 <20240416174850.GEZh66AmnDjrLxoXaw@fat_crate.local>
 <ZiEMnWaHkn99_oyW@rric.localdomain>
 <20240422172055.GAZiacdxkQU0XAbybW@fat_crate.local>
 <ZibEFZ6DoxDeBxxp@rric.localdomain>
 <20240422204146.GCZibLiqZhbY1J4qFJ@fat_crate.local>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240422204146.GCZibLiqZhbY1J4qFJ@fat_crate.local>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?GpJezcGzJiBEtMbFQxir7lESKEOv8EtdzXwcP1j08306C3XlsFj4p3dD15Nr?=
 =?us-ascii?Q?GMbv9nqpROe2/UG0R0SComcfmUtvJIDfHo761bThpkyuvfXacHohr/dpUsmx?=
 =?us-ascii?Q?8gxw8hy0VqpnoOVAYLjP/s4MDL3UdwaBCQPwU0FnjQOZzq9yT1D+USfGO7W9?=
 =?us-ascii?Q?HAukHETWZmUZwlf60j0SZ94QThHlRzePayxViy2utXVfPyc/lHAZmrvCHZkj?=
 =?us-ascii?Q?g8qoFYtH4vU0OBpT3FZHXBegD50udd6Fvp0rR9JJ6QvO2WtNNB3PB8SwbduS?=
 =?us-ascii?Q?uHdDxwfNhOc7drFu3eK9HgIbrbQbn0FaNyGfgbxupA5RZH20u7zg/aBe4nTK?=
 =?us-ascii?Q?r5S30+gnOSHmeMVLRZrvxin64dWuIca7jcYivikTyukFZ1PJiax89Q7HWpRm?=
 =?us-ascii?Q?oAxaylTbxz0wsqYTPNg533RMbch4ZwdawAHVC1dFGHFIVv1tqvOg3pSoUFVM?=
 =?us-ascii?Q?w/TqNKDFIPh9elFmSXQIg2Fw1XGzwqkMLMFgYeaSM/W2SCZpdOSYebGOXLyp?=
 =?us-ascii?Q?kOqugmikkC5C1nUs6BlfsrNNzyyzfx66AcvDJ1uPXSOWPJ8FHNtq/vOBlEZd?=
 =?us-ascii?Q?092VBfhheuXwQ0A2yaOBQufxkt0PJ7bATPBxBbFdxvgq1Xe+a+oraSWv3Oaq?=
 =?us-ascii?Q?GpBO4xK+Xyu0yv5BzX5KnMHK1yDazh8vc95Tx6Dn8kiND64f8PplEnIyuWy6?=
 =?us-ascii?Q?ndI5L8lMti6VEDpDR0GBMBJrqDYKPSmG4ajCEGhOm9KgGIOPg0PTTTaoaykd?=
 =?us-ascii?Q?SWKJhWUlpvCRB952l/r2B2R8WgZPZ9/wRpHwefvmDborq0ICktzKUA/4M0Cf?=
 =?us-ascii?Q?vPv6T5FSQp6D6Ryf+96UPrb/mhwthmRK0v8CqzhhrpfuDBhbMp6Z6BBLHiuZ?=
 =?us-ascii?Q?oYgaibQ0N9BYVXa0uX0EWJtEcMf9ioPsF8g2/olnXLN4R/DYtQE3BNohv0AC?=
 =?us-ascii?Q?Lu0y+gyzarR1pYAkXbaVz0oXEuSGWShtOAyw65WEmOS5l+THFuZ69XIjHTx8?=
 =?us-ascii?Q?Fn0APMcE+OlTinMjSLN2Sg8jioymnnq1ETVMkWjMC0NsHVoq5VQ91Z1dtwSM?=
 =?us-ascii?Q?NUd32BM+sNkxA6oTrVIeuhhqKjRdX4LZq0EOIJKzwKAptaBlYmIeZa8K+zAg?=
 =?us-ascii?Q?+JYbCGdNjXY5ECHKyGjjtlVIK2dwdaVSyCx+cNF2fc3jA+Jv7CD2npkSllmv?=
 =?us-ascii?Q?1OoWGEV3IEc7n0/CPktafjecOoI5AEjem8X8djrXE9MR5yRKfjMgWnHe56kU?=
 =?us-ascii?Q?WBCwyaEizQYm9MUbwbU8I9P2Z7HRGSUbzPTUWP/RGl/st6nYQfrBx8mKDpVj?=
 =?us-ascii?Q?NyJ/chXkIC19YhoLEn32G/ERts2fRHYPwxI+rLRP+iLbkb3q9LyaUAgopWkG?=
 =?us-ascii?Q?eiWm6qBAsBfcS0c7X85fqrUj2lNSe6hdiut53i7s2tV0cRK0hsToYL8nPGjG?=
 =?us-ascii?Q?3ouL7nmnvxwsxdpZSZ9pK2R32Q2UwbSYwuCE2WZ0dwkWrtMXh25ld9swydIu?=
 =?us-ascii?Q?Qa8h3oHW6biWBbhczDY/6FqpSPBtPMwiBVvIEkHsRt1nO9YOpJihNMdbohgt?=
 =?us-ascii?Q?6PTLxA0CbdjcsV1nkR4/6TgqtzGu2b8KLXASLROO?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 692366a6-b7d7-4a92-3664-08dc63136fc1
X-MS-Exchange-CrossTenant-AuthSource: CYYPR12MB8750.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2024 21:30:31.1510
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 47+UwBIKW1/ysjLvdc5LX+NjjPlvGctB3hbXGcClJi1XXuGLJ2lBvXa58MYAMRaCc5ExZkR3teyYnQuzRp/D1g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6066

On 22.04.24 22:41:46, Borislav Petkov wrote:
> On Mon, Apr 22, 2024 at 10:09:57PM +0200, Robert Richter wrote:
> > Since we check get_cpuid_region_leaf()'s return code here we know if
> > the cpud leaf exists and return IBS_CAPS_DEFAULT if not. That would
> > not change the refB behaviour.
> 
> Yes.
> 
> > Though I think that case is rare or even not existing, I would just
> > keep the implementation like that and as it was for for years.
> 
> Yes.
> 
> > > > This slightly modifies the functionality so that 0 is return if
> > > > !IBS_CAPS_AVAIL (instead of IBS_CAPS_DEFAULT).
> > > 
> > > If !IBS_CAPS_AVAIL, then this is revB. But then you want to return
> > > IBS_CAPS_DEFAULT there.
> > 
> > No, on a rebB get_cpuid_region_leaf() would be false, meaning the
> > cpuid leaf is missing, function returns with IBS_CAPS_DEFAULT then.
> 
> So what functionality modification do you mean then?
> 
> When will IBS_CAPS_AVAIL be not set?

I mean the case where the cpuid leaf exists but IBS_CAPS_AVAIL is
clear. That could be possible with some cpuid override e.g. in virt
envs.

> 
> GH BKDG says about that bit:
> 
> "IBSFFV. IBS feature flags valid. Revision B = 0. Revision C = 1."
> 
> so that has been set ever since on >= revC.
> 
> And on revB we'll return IBS_CAPS_DEFAULT which has IBS_CAPS_AVAIL.

Yes, all this is correct.

> 
> IOW, I don't see how we'll return 0 if !IBS_CAPS_AVAIL because latter
> doesn't happen practically with that flow.

Not on real hardware and if future systems not decide to enable IBS
feature bit and clear IBS_CAPS_AVAIL, which could be a valid case IMO.

Thanks,

-Robert

> 
> Thx.
> 
> -- 
> Regards/Gruss,
>     Boris.
> 
> https://people.kernel.org/tglx/notes-about-netiquette