Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp2589664lqt; Mon, 22 Apr 2024 15:44:09 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWcM6QbkcZRfebkTOv6+mKNeGb0izQJsXQdAOJVvH5wigE93RMoSxp8xmdKRO9ZjARG7N3gFlexODiVLpJdqbM54P7qKg0egGmJBtt2qQ== X-Google-Smtp-Source: AGHT+IEyo8mtIoELoqx6AdBt/nGlBtry0a9lV4SbR3PlP7ROOB8ToadZwQ2vsphyPT9tDRtNQCFj X-Received: by 2002:a05:6a20:7fa9:b0:1a9:85a0:afeb with SMTP id d41-20020a056a207fa900b001a985a0afebmr12351921pzj.20.1713825848856; Mon, 22 Apr 2024 15:44:08 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713825848; cv=pass; d=google.com; s=arc-20160816; b=LGTEeU8ybM+wysAo7qGeSSpUdreoS2EpENVK7n6mLBNmvGMZkv8D0+c4VZsJnMHs47 1W3jcTombFOZSRVaKWxoQx62UhhLQnQB91PT3IggOKWw/OEejfkBTcwwGiT+KqZY8nIV jC/dSXDQogdbjBo47F6I7fDIBD4/geXsV3d2/XKq4tYk6uw+cFs6K8C6NArZrF08GOvR gNjunOH72zjH5BPWL6ZhLoMAUTq7crPiw5Zm7YrFYChg2x4/7x44VeHvvnb+71j+UlC1 MKUgX4C4TdmsZBriZNFpt96dxJ8Pp0kiYYqep9D2npRxe1w+mMh0eVODa9LEvikXa7eq vulw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=oofEEwMcsUFGHCf9AB7GLQjS3HSrYP8XWX7NSP6yUuo=; fh=fdPi/B6OUj1pmry3OMg6mNoYVvPADe3GChKZlTYMaYI=; b=ZZ2hXb3pygQAKZX3NIaaPCDo6wPTZidf1ulzImQbOceQxnSna8ONDt96oyYBxSWLh7 8GZp2RgG0mePvpikPhyQkf8Qt+CyRraaRp/Ez1IHFIxSI3jAYyoeb5b3+DDtz7QSbRT7 q13fxHgkpvi8pUGBni/jJHiknwKiUSUD5ZgICm1z2d9RDZvjhRorPxCyPKuabPXYmDd/ Wzd2RkhHTjco5hAeJ/67/5rgM1j79RylWQXgcg/OnGZE+IQT+ITUHLWYG7PXTKNhF7EV 62RBz5Hr3A2vdX+HsXtta0tNZw0koUjcptIBkOxg7Xnng5yecNV5JsTpi9Vhlqe4DfmK PrvQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="Q3vVhk/X"; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-154101-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-154101-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id ei5-20020a056a0080c500b006eadf7e0fe5si8143304pfb.325.2024.04.22.15.44.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Apr 2024 15:44:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-154101-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="Q3vVhk/X"; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-154101-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-154101-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 5103A285862 for ; Mon, 22 Apr 2024 22:44:08 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C9A4C2135C; Mon, 22 Apr 2024 22:44:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Q3vVhk/X" Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C81710A20 for ; Mon, 22 Apr 2024 22:44:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713825842; cv=none; b=SsE01Y9idXnvtcPBPk9hTOJ7B8yYUVxevAvEJKRaqB1oAtI2CvfzzPbez3YXUZMEWnymjSMaFTe9grC8jmPl31JD3yisDUgIL1TM7NWcTeW8BFVPgKZv4ky9E4gnu4zXfkry0MY/KeLo6YfraqlnEoa5L5ZRIcfu7ojJ7PHLi0E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713825842; c=relaxed/simple; bh=ElqV9w5egMCE1fLprf67vgUULGRpUkv5I3l3AQ4IKSk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sNIofSu2LNjyRZVadk5iH1FVieNwtbPJyaVPqLnUQoyQ05QNBupd0iMED3f+nVbvuYycBPKGzuRx0msFA6+c9rt/WDntIu8q1yrY0rkTRrOEusktOPCJM2T1nCz/8F6cUNMZnLzw9dZdmMK3dRMWqhr2eNGBr/97yC0oFAtGuu8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Q3vVhk/X; arc=none smtp.client-ip=209.85.167.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-516d6c1e238so6299563e87.2 for ; Mon, 22 Apr 2024 15:44:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713825839; x=1714430639; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oofEEwMcsUFGHCf9AB7GLQjS3HSrYP8XWX7NSP6yUuo=; b=Q3vVhk/XIpb/nc7rFNSB35G2q1LVjx8Br2L+5m0HkikLZqUD5Nkr80oxo5n9DNTlgN Om10dKKjSL7adi4WvD5q3elvUkPz8cxk6nZHTfcopnNNi7wmzesNCcMhT+DvNw3wyl29 ruejLgcbIszDW3Zq0KlrWTaGK1P3tNVARyRiD/L96sS/lI3IOYdgWTZZKKDSqsaSQCOJ fdpQxebLNE1nJEzxYIJXLApLnGKviURwCFd4jG60XWGob0dSuHk3SedURqI8BuOnlPYY oj8DEhHEBPZkS0vdCc6ZTvCX+GzZ+vdIzbdR8xy21TRXmQejhXeG2DcLMs37O8+aIbFX wyeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713825839; x=1714430639; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oofEEwMcsUFGHCf9AB7GLQjS3HSrYP8XWX7NSP6yUuo=; b=Pf8SBIKWSZ7Lre3n/gKWdlAuVWuxrT1GfDcYoer3jcyCi9dTgwvJFojurwyO5GnBQp 8d21KH1ps0OP2H+1pcynKLGKzsQ5P029fGSg9FBhJj59DgSOOUvAfuR0iNbgktz9enwk tXDpEb72se+bq7er9Ec8dDiI7hiyG6ddFmBHOLde7Cmt9BctKpIsuPTL89IUXCcL9XkS T//pVOkuKkCHDrkWn+GAPPKCW6MdEwh0u9sunGM7CuLiy9QDW4hcOKThIbcoeb/Lw/Vf 2EKFqyFNXvQ2YO2dfcU4JwNNnjspL81ZNDaWX5ktilA9fPv8/9mzi2Vx+XIS7VuFVSTg kqqg== X-Forwarded-Encrypted: i=1; AJvYcCVb78qcbTvc96dIozzKc3l6qqGQh1AyrT4ogO9j0nVwlWNH7C/Wi9QSTxiKBGx32wDrQkUtyY64axJ6tm6ZgTjsTVVVwefgXfoZv58u X-Gm-Message-State: AOJu0YxQ63zY+K0Hrq98jvv0zr9HX8rZzuSGGj4OT1b4nnQFksgjC009 EaGDI//xVv2AWrqliCyr86rYD7XlkKWESkB+aDMI1ZV+zDp7Wh3ptbA5vK3yf9c= X-Received: by 2002:a05:6512:b8b:b0:515:bbe9:f208 with SMTP id b11-20020a0565120b8b00b00515bbe9f208mr8463038lfv.19.1713825838785; Mon, 22 Apr 2024 15:43:58 -0700 (PDT) Received: from [172.30.204.103] (UNUSED.212-182-62-129.lubman.net.pl. [212.182.62.129]) by smtp.gmail.com with ESMTPSA id m7-20020a056512358700b005175dab1cfdsm1833414lfr.257.2024.04.22.15.43.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Apr 2024 15:43:58 -0700 (PDT) Message-ID: <36f33797-22d9-433c-9b5f-df8488191f3a@linaro.org> Date: Tue, 23 Apr 2024 00:43:55 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] arm64: dts: qcom: pmi632: Add vibrator To: Luca Weiss , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Fenglin Wu Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240418-fp3-vibra-v1-0-b636b8b3ff32@fairphone.com> <20240418-fp3-vibra-v1-1-b636b8b3ff32@fairphone.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/18/24 12:03, Luca Weiss wrote: > On Thu Apr 18, 2024 at 12:01 PM CEST, Konrad Dybcio wrote: >> On 18.04.2024 8:36 AM, Luca Weiss wrote: >>> Add a node for the vibrator module found inside the PMI632. >>> >>> Signed-off-by: Luca Weiss >>> --- >> >> Reviewed-by: Konrad Dybcio >> >> On a side note, this is a totally configuration-free peripheral that doesn't do >> anything crazy until manually configured. >> >> In the slow quest to be (hopefully) more sane about the defaults, should we keep >> them enabled by default? Bjorn? > > But many (most?) devices don't have a vibration motor connected to > PMI632, some (like devboards) don't have anything, and other phones have > a separate chip that controls the vibration motor. > > Enabling this by default would mean all devices with PMI632 would get an > input device for the vibrator that probably doesn't work? Fair Konrad