Received-SPF: pass (google.com: domain of linux-kernel+bounces-154172-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 22 Apr 2024 23:58:24 +0100
Message-ID: <87v849t373.wl-maz@kernel.org>
From: Marc Zyngier <maz@kernel.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Naresh Kamboju <naresh.kamboju@linaro.org>,
	open list <linux-kernel@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	lkft-triage@lists.linaro.org,
	Linux Regressions <regressions@lists.linux.dev>,
	Arnd Bergmann <arnd@arndb.de>,
	Anders Roxell <anders.roxell@linaro.org>,
	joey.gouly@arm.com,
	Oliver Upton <oliver.upton@linux.dev>
Subject: Re: gcc-8: arm64/kvm/pauth.: Error: unknown architectural extension `pauth'
In-Reply-To: <ZiYqV-5BWmPwgqbU@FVFF77S0Q05N>
References: <CA+G9fYsCL5j-9JzqNH5X03kikL=O+BaCQQ8Ao3ADQvxDuZvqcg@mail.gmail.com>
	<ZiYqV-5BWmPwgqbU@FVFF77S0Q05N>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2
 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
Precedence: bulk
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII

On Mon, 22 Apr 2024 10:13:59 +0100,
Mark Rutland <mark.rutland@arm.com> wrote:
> 
> On Mon, Apr 22, 2024 at 02:04:43PM +0530, Naresh Kamboju wrote:
> > The arm64 defconfig build failed with gcc-8 and passed with gcc-13.
> > 
> > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> > 
> > Build log:
> > ---
> > /tmp/ccSUNNZy.s: Assembler messages:
> > /tmp/ccSUNNZy.s:3159: Error: unknown architectural extension `pauth'
> > make[5]: *** [scripts/Makefile.build:244: arch/arm64/kvm/pauth.o] Error 1
> > 
> > Steps to reproduce:
> > ---
> > # tuxmake --runtime podman --target-arch arm64 --toolchain gcc-8
> > --kconfig defconfig
> 
> I think the key thing here is GCC 8; the associated assembler won't necessarily
> have ARMv8.3-A support, since all the relevant bits got added around GCC 9.
> 
> Looking at the commits, I think this is broken since its introduction in commit:
> 
>   6ccc971ee2c61a1f  ("KVM: arm64: nv: Add emulation for ERETAx instructions")
> 
> ... where the pauth.c file only depends on ARM64_PTR_AUTH (which doesn't imply
> AS_HAS_ARMV8_3), but in the file we do:
> 
>   asm volatile(ARM64_ASM_PREAMBLE ".arch_extension pauth\n"
>                "pacga %0, %1, %2" : "=r" (pac) : "r" (ptr), "r" (mod));
> 
> Given the minimum supported toolchain comes with an assembler that doesn't
> necessarily support ARMv8.3, I reckon we'll either have to make NV pauth
> support depend upon AS_HAS_ARMV8_3, or manually assemble the PACGA instruction.
> 
> I suspect the latter is the better option.

This is what I've done [1]. It certainly isn't pretty, but this counts
as an incentive to drop some of the old stuff in the near-ish future.

I've pushed this out to -next, and hopefully the breakage will be
solved tomorrow.

	M.

[1] https://lore.kernel.org/r/20240422224849.2238222-1-maz@kernel.org

-- 
Without deviation from the norm, progress is not possible.