Received-SPF: pass (google.com: domain of linux-kernel+bounces-154170-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Subject: Re: [PATCH 1/7] block: Init for CBD(CXL Block Device)
To: Randy Dunlap <rdunlap@infradead.org>, dan.j.williams@intel.com,
 axboe@kernel.dk
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-cxl@vger.kernel.org, Dongsheng Yang <dongsheng.yang.linux@gmail.com>
References: <20240422071606.52637-1-dongsheng.yang@easystack.cn>
 <20240422071606.52637-2-dongsheng.yang@easystack.cn>
 <7d24e1fb-520c-4ec2-a6aa-89856092891a@infradead.org>
From: Dongsheng Yang <dongsheng.yang@easystack.cn>
Message-ID: <dd1df8f1-f80c-5a3a-f804-3e360bfac339@easystack.cn>
Date: Tue, 23 Apr 2024 06:41:11 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.0
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <7d24e1fb-520c-4ec2-a6aa-89856092891a@infradead.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit


在 2024/4/23 星期二 上午 2:39, Randy Dunlap 写道:
> Hi,
> 
> On 4/22/24 12:16 AM, Dongsheng Yang wrote:
>> diff --git a/drivers/block/cbd/Kconfig b/drivers/block/cbd/Kconfig
>> new file mode 100644
>> index 000000000000..98b2cbcdf895
>> --- /dev/null
>> +++ b/drivers/block/cbd/Kconfig
>> @@ -0,0 +1,4 @@
>> +config BLK_DEV_CBD
>> +	tristate "CXL Block Device"
>> +	help
>> +	  If unsure say 'm'.
> 
> I think that needs more help text. checkpatch should have said something
> about that...
> 
> And why should someone say 'm' to the config question?
> Will lots of (non-server) computers have CXL block device capability?

Hi,
     Thanx for your review! In this RFC version, I have focused entirely 
on prototype validation and demonstration, so this aspect has evidently 
been overlooked. I will supplement the help text in the next version. Of 
course, this place should be If unsure say "n", not "m".

Thanx
> 
> thanks.
>