Received-SPF: pass (google.com: domain of linux-kernel+bounces-154176-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Mon, 22 Apr 2024 16:01:21 -0700
From: Dan Williams <dan.j.williams@intel.com>
To: "Li, Ming" <ming4.li@intel.com>, Dan Williams <dan.j.williams@intel.com>,
	Terry Bowman <Terry.Bowman@amd.com>, <rrichter@amd.com>
CC: <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 3/6] PCI/AER: Enable RCEC to report internal error
 for CXL root port
Message-ID: <6626ec41da372_690a294df@dwillia2-xfh.jf.intel.com.notmuch>
References: <20240313083602.239201-1-ming4.li@intel.com>
 <20240313083602.239201-4-ming4.li@intel.com>
 <7172ec2f-7cba-460b-a6c6-9fff45ba938b@amd.com>
 <b4a721c2-567d-4ab3-8a85-963e3f323e61@intel.com>
 <91ddd182-cc71-480f-a1b2-e7c31b29a549@amd.com>
 <f0b85a37-ead0-4954-b7e0-dd09cbd9ab09@intel.com>
 <662134e290d89_5eec229450@dwillia2-mobl3.amr.corp.intel.com.notmuch>
 <8a304a97-7825-4b02-a716-f25d0e9d4718@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <8a304a97-7825-4b02-a716-f25d0e9d4718@intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4E4P3nqS51dQXFIKaUtQ6ITgdJKez25hH6D4BCvXgNu3/BLztzJiFtkN3ufL?=
 =?us-ascii?Q?w0JaysQG7l8r/RRCI8xIuWIFA8lOcWfHPCpriOqWvE0D+KLSlWdFR7/xeqhD?=
 =?us-ascii?Q?4w+QD/eycvo8b7lUWVxVgctY3FsmduHSBw1mQazidJQ8988REqnDm7ea9m+k?=
 =?us-ascii?Q?KTFnhOQZEFITn7h/6910bMfNwOROW8s4YIbb6aRtedgFuWeCspAhmXQjOo2N?=
 =?us-ascii?Q?08ZO5ZXg+hSpE7cUoQOOSyybGqD2iMG/svXdiTVmA4zoIEURR71pGI67dNz+?=
 =?us-ascii?Q?LrJouL9nFL3sy/3EpZClWVPUwNJiFZy0zhZBC6rVOd9mQF5aBc51s6U5IZUY?=
 =?us-ascii?Q?u04XfCw955FJjhT6s4bO7is6GNbip2cYsy78NcvpBazfqagkVWPvXMfdrOL9?=
 =?us-ascii?Q?bHzPBk0NCL1Itd17uEnFkXHWlN4K6spvRrQRl6IpNdi+DfBD5kRU9dXzxKWM?=
 =?us-ascii?Q?P3EY1eqOBjdDKv74CWtonYt0F6NKXN3EwIHt+TRWO8dJfvWFqY4+kgWcnDQx?=
 =?us-ascii?Q?FPmg/5k7mFp9dCaFbTL3Qi0A/NMIQNIgkwUd24Yuec7Dxe8EV1vQbMQAYaPd?=
 =?us-ascii?Q?mpwS2a7u/VNTmiD7JS49Z99D+uyjgrh09RTvxbd6A4zsIQLgMhxx1wa4KPBZ?=
 =?us-ascii?Q?ljDuv9vj9bkbbuJb3nRC1ZEY+mXtJ5SziDq7BgXa/ty6r0kI2CtU9hjORvAi?=
 =?us-ascii?Q?7WI1Jy2yJCDmQlKTQCaNp6AdLRA/JX6uvOM+9xi1ePsSILc4o57Rhpp488fk?=
 =?us-ascii?Q?AsLoTdVuaAQUFLWTYwqAMEQvGDyWU9CRxPur9DEKQbwp0ogEQu2uTXvJu2e0?=
 =?us-ascii?Q?bymOy6pQOozIoH/4kkVEcgz5cX3qT3p5U8UKaTBxbAA3zPlKtrzxpasAPIYa?=
 =?us-ascii?Q?255f9fwaI+G56fL6IKnZPqs+W4Wg4D8MuS8orjgfOtdLQIhUpIxhaTGC1VRA?=
 =?us-ascii?Q?m1o0oebVUQZzVOQF++Me/cV7tLO8tH1PopqVHcbr1hYnWbW5Gma0DPSj0YXa?=
 =?us-ascii?Q?zbLxSA3QW3MXC8TJo0UBb3YnxOybS6Qi5knKYCpvigjgPxMoU3+Kto2b3kU3?=
 =?us-ascii?Q?HUPLVD1fpxlW3DpJg0fGrI+13hSELj6F8s3yE7G3Pp8TGRZ0nT8Jk8QmKpzx?=
 =?us-ascii?Q?OmzRKx+TS0qdrG6fzggFyyp32FlQqRL4A43zHcYyuHBiVfUzJ2EtLyL7BNie?=
 =?us-ascii?Q?J5C2nW4NyV7kMHndjnYA2jkzF6uL0PWM7BJL4FlebhMBW2grw/0Bzx+gfYpG?=
 =?us-ascii?Q?CnwyIo68gdna5+8HZLtRLQg04G7qFoMqbdICNSnDkp1Z8MfCA4K6MDw7uwZA?=
 =?us-ascii?Q?BsU49ezIxj/wpgePJkRzgvSE+CeVvG/bgtk+tapRZUYhUgr0sIfidJdYiFII?=
 =?us-ascii?Q?TVRU6Wn2X5ufWQAQtO+Zzhz+W2Ato2wMj+A5AdnRbMn1eZVYHLQXeLyrw0Hd?=
 =?us-ascii?Q?XTEXN6cZcs7Zj8pW04ru9+a0Wp5HshIXRyXIaOgubyceEtjaOqByahD8XoMk?=
 =?us-ascii?Q?w7lutB00IExIk4nSkXSG78vr3p+LTeIClYQCd65nIoIKbROeqShQIbg7Ckpa?=
 =?us-ascii?Q?9Rxl3ch7DccPrCnyU8TQSkXhIDUc9kD/z6B0Pi8GZlX0dIBZPjCpS6pRZ7yT?=
 =?us-ascii?Q?nw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7a79838d-b8c2-4b61-049c-08dc63202217
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2024 23:01:24.3213
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WORKsLYFcQE9QG0Gsc+I/InZf8MR0B6xcPyA5HPLq+EPJd8eMzPhc6KeeIy/zJV73nt8xOmWNjyXjUaacO/olgfIR9FuJV7pE3sTzwl7m9s=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6186
X-OriginatorOrg: intel.com

Li, Ming wrote:
> On 4/18/2024 10:57 PM, Dan Williams wrote:
> > Li, Ming wrote:
> >> On 4/16/2024 10:46 PM, Terry Bowman wrote:
> >>> The driver support is much simpler if RCEC does not handle VH protocol errors. Is there 
> >>> a reason to forward root port VH mode protocol errors to an RCEC rather than consume 
> >>> in the root port's AER driver and forward to CXL error handler? 
> >>>
> >> I agree that is simpler if only root port handle VH protocol errors,
> >> but I think that software has no chance to choose if VH protocol
> >> errors reported to RCEC or root port, it depends on platform
> >> implementation. So I think we should support both cases.
> > 
> > The question is whether the CXL spec RDPAS behavior causes any problems
> > for platforms that follow PCIe rather than CXL reporting flows for
> > root-port errors. I.e. does it cause problems if Linux starts scanning
> > root ports on RCEC notifications?
> > 
> > I do think the lookup needs to change to be based on CXL host-bridge
> > detection and not CXL-type-3 endpoint detection, but otherwise it looks
> > like CXL spec wants to invalidate PCIe spec expectations.
> 
> Hi Dan, if my understanding is correct, the CXL host-bridge detection
> you mentioned is that iterating all root ports under RCEC associated
> bus range for RCEC reported VH protocol errors case, and the
> CXL-type-3 detection is that iterating all CXL-type-3 endpoint under
> RCEC associated bus range. is it right?

I think this error checking needs to be tightly scoped to only scan for
CXL.cachemem errors and not CXL.io or typical PCIe errors. That way we
are not technically running afoul of the PCIe expectations that *PCIe*
root-port errors are only reported by their local AER block and not an
RCEC.

So the scanning should be limited to just the root-ports that have
negotiated a CXL.cachemem link.