Received-SPF: pass (google.com: domain of linux-kernel+bounces-153898-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 22 Apr 2024 20:11:59 +0100
From: Matthew Wilcox <willy@infradead.org>
To: Jianfeng Wang <jianfeng.w.wang@oracle.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	akpm@linux-foundation.org
Subject: Re: [PATCH] mm: huge_memory: convert __do_huge_pmd_anonymous_page()
 to use folios
Message-ID: <Zia2f2EI8LWFE2XA@casper.infradead.org>
References: <20240422181216.91938-1-jianfeng.w.wang@oracle.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240422181216.91938-1-jianfeng.w.wang@oracle.com>

On Mon, Apr 22, 2024 at 11:12:16AM -0700, Jianfeng Wang wrote:
> Change __do_huge_pmd_anonymous_page() to take folio as input, as its
> caller has used folio. Save one unnecessary call to compound_head().

I don't like this patch.  It makes the assumption that folios will never
be larger than PMD size, and I don't think that's an assumption that's
going to last another five years.  Look where you had to
do &folio->page:

> +	clear_huge_page(&folio->page, vmf->address, HPAGE_PMD_NR);

> +		entry = mk_huge_pmd(&folio->page, vma->vm_page_prot);

For mk_huge_pmd() in particular, you need to know the precise page, and
not just use the first page of the folio.