Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp2629477lqt; Mon, 22 Apr 2024 17:25:10 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVa3sXSPuwRlR4oNEFOWXIL5IQPOujQDJ9iyAiaO1o5JCDXRiuCeUGqAM30Ncro8VVFRyopKkD4vRvtpzdxGMRFLyUN+kZkl62+l9izjg== X-Google-Smtp-Source: AGHT+IFhHyfbKL8iolT29WngopLEwQqv8WhCI+FRxeROABhDmtmN5OLkcPQHNrdzGaYCb1Ayojlk X-Received: by 2002:a05:6870:158c:b0:22e:a2fc:afaf with SMTP id j12-20020a056870158c00b0022ea2fcafafmr12568682oab.49.1713831909892; Mon, 22 Apr 2024 17:25:09 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713831909; cv=pass; d=google.com; s=arc-20160816; b=xW3UhkmJrq1dKZBmWy5zG1aOpt+wRLvCsK+VgnaT665cXWw6aCQTWWwgDt9bfnizp8 2W6XkJiX0krOvjRAQqT7ttMjgOUKYGrvp4yTRoQGuksJSF5coqBPOaP9NULb8Tey3D/e w6YzdeubT7VGs5ChnEIyqZI3cdf1NRKG+yWPmgWd2iLE+G3C5dyjgHLdRGFAC7Z3SkrH UVB2DYGR8NZKtuvF9Jl9/quiZm1IBmDQW8D3DFemZ1OzZ7j/zNszgMSM4fOUGwJMJnmm Noio+3FxOCxpFifZp2bDzeHrUmTw7C20/HAXczWQpK93S0Rr1USl4t73B1mypVP7j0If KYPw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=UH9XjHMQCB0ptbhIU/cXVj9IrIh7+qbglkR5L06Z7p4=; fh=LgLN+/3W1mZoZAr3/BhbQ/1ltalmcm8WFgnAucewcN0=; b=x4XExqPHVPNuZxZ81TddC+s6kRmD26DDiicEhW0DkNT14TBFa9S3IY9hZMGhbE4tc/ /Xpe7Uei/2XPUHsTrPsxVr2clVdmk0imaB95t1XlxETR/lEHdSk3llhs2dnPEkN6WOnl 7TFTn+0jgHwLq1LFURKua9QDGc8I4c02sGKAscTiRyCvB9HPG9zgHn8WLk9wQ/d+knVU YcRFwZdE3ZASvGUrEdSQSa7hCfkiWT1U+IiziVVdCTMCXkGDdTwWA06Vacc/TpSyLgKm KlOU39sqwcVNT5p5+cJ5+nwZo4UxGzn/Olhp28wwXXvUIYsJbGHxq+rJl+6c/iF2mUL/ mpIg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=krPMNfJF; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-154278-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-154278-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id g20-20020a635214000000b005f057f31f96si8725520pgb.60.2024.04.22.17.25.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Apr 2024 17:25:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-154278-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=krPMNfJF; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-154278-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-154278-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 0316AB208A5 for ; Tue, 23 Apr 2024 00:08:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5A88F16D9D9; Mon, 22 Apr 2024 23:56:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="krPMNfJF" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80B3F16D9CF; Mon, 22 Apr 2024 23:56:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713830204; cv=none; b=QhUoQi+S8/Tby4toCFQJcN7Z9q08Br0RskQJC186b0ws2PvQrkhB6YQ4mJ3OcLUNkaXkrpRoxnp8Z/6Hvmi6HCCYwsLCsjZ6rpSfGIDuNox1zvrtdSn1TN/tAslunybgSWUkq86DtM1IrdgPmD7hBQR0+x5EDXbaEbVBfQIBVqk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713830204; c=relaxed/simple; bh=EUGFj9Mtq+6MugVf19sjasOnoCDVrjYyF0aW0FnC7M0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=X656Fm69/x8+6atggIS7c5PmiSFcSPaB3nKjBtIqCmppKRhoTR+p9RCMdYWCMPeFrjm6CQV+iGW+1h8nQTwKNyw3ZQHQruKcGEwHGRWW8I95z0agvHB05+XriCvm0LOaTr2DvRpjvRX+QWCWl6Y8IRpiiZiqqaVGf+sIKz+RDyA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=krPMNfJF; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id C802FC2BD11; Mon, 22 Apr 2024 23:56:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713830204; bh=EUGFj9Mtq+6MugVf19sjasOnoCDVrjYyF0aW0FnC7M0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=krPMNfJFnvwsyDiRFHqqwfqvyccMWpKBPcr4mZEbhfJ5w5ZUfjf9H0L0GjPIHYTrw MrsZmiT2mLWJc0j7qwM512O9/dANqdmOpozOTsNoZbbs7i2wod2kijl4Dw1p+zsl2q 8W3oJ5IBVCwtJ/W2Vw9rdLJx6PAJxJ3r8mdepZlbAfCnDtquVST5sK4qBSULLWcCUF YzDjDd4bh4srbFICBupHU/sgH1uuWHqqUwKldEVOWMvcVpI+fSXU39CEAP1fQvzekq EmnoX7/HZa2oVyZfZRB8E/OtAenUk/fY/cuexE3HkU0RCRXplos+CKaRGE1MRpszsf aEL7Lxy80YHjA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Lijo Lazar , =?UTF-8?q?Christian=20K=C3=B6nig?= , Asad Kamal , Alex Deucher , Sasha Levin , Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch, ltuikov89@gmail.com, zhenguo.yin@amd.com, dakr@redhat.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 6.6 17/29] drm/amdgpu: Refine IB schedule error logging Date: Mon, 22 Apr 2024 19:16:58 -0400 Message-ID: <20240422231730.1601976-17-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240422231730.1601976-1-sashal@kernel.org> References: <20240422231730.1601976-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.6.28 Content-Transfer-Encoding: 8bit From: Lijo Lazar [ Upstream commit 4b18a91faf1752f9bd69a4ed3aed2c8f6e5b0528 ] Downgrade to debug information when IBs are skipped. Also, use dev_* to identify the device. Signed-off-by: Lijo Lazar Reviewed-by: Christian König Reviewed-by: Asad Kamal Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c index 78476bc75b4e1..de9d7f3dc2336 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c @@ -300,12 +300,15 @@ static struct dma_fence *amdgpu_job_run(struct drm_sched_job *sched_job) dma_fence_set_error(finished, -ECANCELED); if (finished->error < 0) { - DRM_INFO("Skip scheduling IBs!\n"); + dev_dbg(adev->dev, "Skip scheduling IBs in ring(%s)", + ring->name); } else { r = amdgpu_ib_schedule(ring, job->num_ibs, job->ibs, job, &fence); if (r) - DRM_ERROR("Error scheduling IBs (%d)\n", r); + dev_err(adev->dev, + "Error scheduling IBs (%d) in ring(%s)", r, + ring->name); } job->job_run_counter++; -- 2.43.0