Received-SPF: pass (google.com: domain of linux-kernel+bounces-154350-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Mon, 22 Apr 2024 17:19:52 -0700
From: Dan Williams <dan.j.williams@intel.com>
To: Robert Richter <rrichter@amd.com>, Davidlohr Bueso <dave@stgolabs.net>,
	Jonathan Cameron <jonathan.cameron@huawei.com>, Dave Jiang
	<dave.jiang@intel.com>, Alison Schofield <alison.schofield@intel.com>,
	"Vishal Verma" <vishal.l.verma@intel.com>, Ira Weiny <ira.weiny@intel.com>,
	"Dan Williams" <dan.j.williams@intel.com>
CC: Robert Richter <rrichter@amd.com>, <linux-cxl@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] cxl: Fix use of phys_to_target_node() for x86
Message-ID: <6626fea88c0d1_690a29479@dwillia2-xfh.jf.intel.com.notmuch>
References: <20240419140109.1996590-1-rrichter@amd.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240419140109.1996590-1-rrichter@amd.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?9Th8oR3pJfi0BYhAMs7D42s+L5SMoUr7JHEb5Epl52NL2lLgYQgWGIbKGhdn?=
 =?us-ascii?Q?TfWVZBOC/wu6arqglKYA0S3Q4fEzeGO6YB7HhEp1j4X6I9DlezVrDe0nvKp0?=
 =?us-ascii?Q?wHUEpR0GBnFv63VNWvbA91Esk0ReG2v5Y1XVd+GU8TBek1PR2Dr0iiVTGKZ2?=
 =?us-ascii?Q?JSwMcKp52HpM2HRpdst5D8W/yFMQarde7FeXlb4u1ur6GmoeuBdTKyPNRa5F?=
 =?us-ascii?Q?n2/3RcicZHaXiuDeLzG7AOAUV6g7V6d2Jbx3p3Q5g1Fk3CFGAcHI2kgoTgtF?=
 =?us-ascii?Q?rj4V2k8L9SjZZ0jFFvq6z6T30Cl99pT0ZPU3fd4Vkq1SdnoU+wm46vj9cRSX?=
 =?us-ascii?Q?Kv1EZceAzauyeSrnU3AAMj4CB+3D9BedMXxnHQznQtq7VdltVnvbn9xNDMf8?=
 =?us-ascii?Q?N0rRytRKWuDsCf7HpvUPwz2kpNNdM72wbUwp46+Wp89lYjcEQc/zlaWlpvBT?=
 =?us-ascii?Q?ErpcvgO4f927d5JX2GNuhbT00hbkffFLCaiDJ2DqmrObCenmnCI1WHteNaCz?=
 =?us-ascii?Q?gLEXhGgKlV71qs9sL9JJeQDltkqjAavzEJcO2rxFAVFCmoFhNsZ0JqFNTDdN?=
 =?us-ascii?Q?niDZigOel+MBrAiVY9Yh/9335VQnlPbF77qVu9QFXBswJtz2EYm0kMUblIDL?=
 =?us-ascii?Q?5HVffLLyLa3u9JSawVmUxLPQsYD2ry1naIokH5aPVYioAbeD7Pp+AoH1i1ke?=
 =?us-ascii?Q?LWl7av1lzF0mJwGToQpxtIVL9tC3mxUYFhGb+UIIrEu87+GMjyXHxtwv29CZ?=
 =?us-ascii?Q?LgeiUXIyCixxMulxQtwQhGw33+ZjwoiXd/PyEQCFLjiIoM4k9yNn5ltP829+?=
 =?us-ascii?Q?u7QtsypmnWxDs3PPwJSGdPaIPKgbEN9YTglzyGhUQlo5lP/AinwZWjOb7qwl?=
 =?us-ascii?Q?vhEv8EcvlBEKu3efyeHWHKCaZ+DE15wI4wUZkAQ+IIjV72v1eh3dyMLztbvb?=
 =?us-ascii?Q?46uRdPoVkkC3Vwa1nCpkJ0SvJAz246TfyX3rnTFeT0NocuBfiqflUBt2/chm?=
 =?us-ascii?Q?EDJfhI2etRw9iNBCLGmrk5eBRaYbTwrrQTVSYCvwvJMbF+iQou9OV0+mZ8cS?=
 =?us-ascii?Q?vsKV1ZpH5GKzprxZjBcKYgokBO2JAxtkVYY3JmCGvFW3fcjbsML70iU6o6h+?=
 =?us-ascii?Q?iHC6FfRYgF+C5U67FxU516PInoehbpLtvM6KpUeHatYdL30E8/Ou9f5i6sRy?=
 =?us-ascii?Q?PELheEN6oB8uZSXzHPWeIANdI0aIYnFd46i69h6fQ7bwiLx29vIYEGeTqFp3?=
 =?us-ascii?Q?Wt7+cNNUtEmwCjOpDDlFzIEOtGd6B2/wb0ca3Ki+xTnxCiJlce+DxYpDNHUG?=
 =?us-ascii?Q?y6XG5xuWRmBm++iKtX4v0P9/JTlI645kKO5bX1aDAvCZ1Sb7eRtCDbz+JcAJ?=
 =?us-ascii?Q?h4TlGWgDP1DkwMzVLLiaNotilSv4pYxCWDNjk05P7MSIUhu6tb5bAnqj04If?=
 =?us-ascii?Q?sSPcygkQGBMSGbl/keeMN8BhLm0B5ezI+1mr3Yzeo6+Dh2teb0KWHWwhkbaN?=
 =?us-ascii?Q?USZmM1Rf2/6A22HWhZZWHTLs8Qat23xPNgqHR4NHfl5sTCAJCEHhHYxfRv7+?=
 =?us-ascii?Q?uFA0Pwjq+iWVSwuaByd+7bdoR/QixoQdTaxGXWvI5PW6Cq4cNTNwm33FWr+f?=
 =?us-ascii?Q?cA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 22d0f0f4-2428-432d-688e-08dc632b19ca
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2024 00:19:54.8506
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dysq6Eh2U2CxCbd5WAFAY8rTiyFluNHScXTZ7RbR+mC6kcC87nJMOAcLiqL5O3suKY3tu2OVfrQ8xb3C3Jiy0ql0cW/MsfXrsbYVfYxvf2g=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6099
X-OriginatorOrg: intel.com

Robert Richter wrote:
> The CXL driver uses both functions phys_to_target_node() and
> memory_add_physaddr_to_nid(). The x86 architecture relies on the
> NUMA_KEEP_MEMINFO kernel option enabled for both functions to work
> correct. Update Kconfig to make sure the option is always enabled for
> the driver.
> 
> Suggested-by: Dan Williams <dan.j.williams@intel.com>

It would be nice if all "Suggested-by:" tags also came with a "Link:"
tag to recall the rationale, because my brain had cache flushed what I
said earlier.

Found it here:

Link: http://lore.kernel.org/r/65f8b191c0422_aa222941b@dwillia2-mobl3.amr.corp.intel.com.notmuch

..with that added:

Reviewed-by: Dan Williams <dan.j.williams@intel.com>