Received-SPF: pass (google.com: domain of linux-kernel+bounces-154357-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Mon, 22 Apr 2024 17:38:50 -0700
From: Jakub Kicinski <kuba@kernel.org>
To: Jun Gu <jun.gu@easystack.cn>
Cc: dev@openvswitch.org, echaudro@redhat.com, linux-kernel@vger.kernel.org,
 netdev@vger.kernel.org
Subject: Re: [PATCH net-next v4] net: openvswitch: Check vport netdev name
Message-ID: <20240422173850.2222305f@kernel.org>
In-Reply-To: <20240419061425.132723-1-jun.gu@easystack.cn>
References: <20240419061425.132723-1-jun.gu@easystack.cn>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 19 Apr 2024 14:14:25 +0800 Jun Gu wrote:
>  	vport->dev = dev_get_by_name(ovs_dp_get_net(vport->dp), name);
> -	if (!vport->dev) {
> +	/* Ensure that the device exists and that the provided
> +	 * name is not one of its aliases.
> +	 */
> +	if (!vport->dev || strcmp(name, ovs_vport_name(vport))) {
>  		err = -ENODEV;
>  		goto error_free_vport;
>  	}

Sorry I applied this before I realised that it's buggy.
dev_get_by_name() will give you a reference on the device.
You must free it, so the error handling is different.
Please follow up ASAP to fix that.