Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp2642806lqt; Mon, 22 Apr 2024 18:03:18 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVUciBKy/gNt2CMGwO1OGJPrr2lV6aCHJYseLMd4/E7Ai0277D2gma9YhUckZ1tmAEIPJSvB9fNlBFifoiNESJpa8h2qH6SrWSzmdVPDA== X-Google-Smtp-Source: AGHT+IGbscD0k+AotYh2EGqhnY94fHdakBh7jmspawe0kNlHfHUA43VVASEPyp61WaC2RcNIsPTb X-Received: by 2002:a05:6a00:1786:b0:6ea:b1f5:112b with SMTP id s6-20020a056a00178600b006eab1f5112bmr17660804pfg.21.1713834197783; Mon, 22 Apr 2024 18:03:17 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713834197; cv=pass; d=google.com; s=arc-20160816; b=JbIXRycGMqvnw92Aqd25wU+FGnCltvnU2hm61MnE/Fv2LiJlqWMz6LZ+GNVYQiPUvL aSw6UsXbm/bN7BorihmMIhtIfYtzEB8c5DKxq5w3mLwAhlyDEJTvZnWEmz54N1NTLgZ6 IxI7WIP0GMjKUZzq9HUne1FcboNgD6z+VpNIYnYiSP4G3Ff/A/Px7q9LKJD77uhkCxUF JSRgZKaq/v3v45owChi/Y76j/3eQA6FM/6C5aV5NEyrWN3CPhcmgKOue46dbGD11n/iy +K6zlgrt5TF7uLbLdxFlkBYRu0Zj/NhIkh7r3m4gi9K4vbPyhNEtfUqY4QVtwVGrn6NZ fffA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:message-id:organization:from :content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:references:subject:cc:to :dkim-signature; bh=97+Qzyb7hvTUp5JgDEyllVyyHm/j+hdmSlwO1IcDqgg=; fh=x9lpokaX7uj2+k31XyA5f5tpUeife0koYxkDSW1UMe0=; b=tv2VHnxOewOJOLmikDDB0KYrKwIJtkkqNzkOx8AK8CLR/LLZQ1WO6RJDR+LWDoKad/ aiVb6WsXY21n4NqJInRltECSSIyzflOtItaCAFyYW9bUE6uWAX/AgwQ5lg7tyXGuoGEX oupzQyFwhB/5g83KTtXYZXBjXAi+UURUrSHURTScb/6pht1xVLaN1ZAuHQV9Fvo1pcza OXhIFENfExMxNwWuw/x3UyppcDSH20ljbzibdjuTMxaHGklqTdK5Rv9Fh8LNxLUdcvLx VUKNPM5ZpKNatH0ZMLKIbLc9c8PUZnZAnI1ff4MeMasxpRHh0GyOujlci5BEWm6uIwd3 1rAA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=IDVPB+RK; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-153926-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-153926-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id m12-20020a63710c000000b005f7fe3fe571si6765344pgc.572.2024.04.22.18.03.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Apr 2024 18:03:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-153926-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=IDVPB+RK; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-153926-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-153926-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 6A6C7B21E37 for ; Mon, 22 Apr 2024 19:39:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B574515534A; Mon, 22 Apr 2024 19:38:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="IDVPB+RK" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54AFF155337; Mon, 22 Apr 2024 19:38:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713814733; cv=none; b=s2FJOkOUH5XwrTPN5Of8vAMUMaeX26rU8ylSh+ZBEGxp3egLuwpSkM6aIZz87tqooeNgNsDxKDgEtqo3WuWmlXWZQelhB4t46hXPcQzot6o6Y5AXnT4LXm2pMS8YPnHBcxYwckxA4um4a2ufMXeqHFJIL6i0eFuDPIoHWPFR3QQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713814733; c=relaxed/simple; bh=2GRFl6WMleWf91SC8vfssaS1Has6aTi33GaASl85sXM=; h=Content-Type:To:Cc:Subject:References:Date:MIME-Version:From: Message-ID:In-Reply-To; b=lLjpIshkB6AJdBKcMx+fpTp1MjErdM9eyauzKJtGakhQOY15erAacQKw3a9Y6gf7HTJ2LqTNR5maAUTILIqkmrUwpEzJD7+arAvWCXV1bLmlez3s5kVMyR6v2oBYKUgoZm0TU9+YnZprqQ9lRvQDuiCzNkjfnWjmRJm4iQG0AkQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=IDVPB+RK; arc=none smtp.client-ip=198.175.65.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1713814732; x=1745350732; h=to:cc:subject:references:date:mime-version: content-transfer-encoding:from:message-id:in-reply-to; bh=2GRFl6WMleWf91SC8vfssaS1Has6aTi33GaASl85sXM=; b=IDVPB+RKVn8/241gQnuf2TCERhjYgKPdRBaCvI9XOSw1PQcLD/sbH0TO PAvigSPFlvDRslMT3kj/PWxVloPxDjhfKPmm/4Gpw5nwbsubvv+eZum6i d/t2YzWuFUHX1zySJ55npCJ7EOyXVm7M0SEUNctmnrI1BwKVRDcGnYQ4+ iKJZ1pdXi0bkQ3B9+lnny0MJXB9Py/PryxUX8Pjrb87X6yY/n65y/oAsV 2PFQGDwnpAEAFuy3LJiwved7dkisS/FxsPk85j8nWAolrb1jkwpGAAS81 cZb8HD+lgWb8pPJWn6LNlDFDFq5AvNPr1vuhCTCgqqUNomGECG4nUJUhX Q==; X-CSE-ConnectionGUID: lRyTJZY5QD6/8WWnjjKHmg== X-CSE-MsgGUID: dWQeUNsXRo+qhYjDe5dESQ== X-IronPort-AV: E=McAfee;i="6600,9927,11052"; a="31862685" X-IronPort-AV: E=Sophos;i="6.07,221,1708416000"; d="scan'208";a="31862685" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2024 12:38:51 -0700 X-CSE-ConnectionGUID: wxQAfcSZQH6z1pluyFm5Xw== X-CSE-MsgGUID: LUyg5N3USu2ioIEx+8xN4g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,221,1708416000"; d="scan'208";a="28777816" Received: from hhuan26-mobl.amr.corp.intel.com ([10.125.85.20]) by fmviesa004-auth.fm.intel.com with ESMTP/TLS/AES256-SHA; 22 Apr 2024 12:38:49 -0700 Content-Type: text/plain; charset=iso-8859-15; format=flowed; delsp=yes To: dave.hansen@linux.intel.com, kai.huang@intel.com, tj@kernel.org, mkoutny@suse.com, linux-kernel@vger.kernel.org, linux-sgx@vger.kernel.org, x86@kernel.org, cgroups@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, sohil.mehta@intel.com, tim.c.chen@linux.intel.com, "Jarkko Sakkinen" Cc: zhiquan1.li@intel.com, kristen@linux.intel.com, seanjc@google.com, zhanb@microsoft.com, anakrish@microsoft.com, mikko.ylinen@linux.intel.com, yangjie@microsoft.com, chrisyan@microsoft.com Subject: Re: [PATCH v11 14/14] selftests/sgx: Add scripts for EPC cgroup testing References: <20240410182558.41467-1-haitao.huang@linux.intel.com> <20240410182558.41467-15-haitao.huang@linux.intel.com> Date: Mon, 22 Apr 2024 14:38:46 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: "Haitao Huang" Organization: Intel Message-ID: In-Reply-To: User-Agent: Opera Mail/1.0 (Win32) Hi Jarkko On Mon, 15 Apr 2024 14:08:44 -0500, Jarkko Sakkinen wrote: > I did run the basic test by manually creating the cgroup so you could > add tested-by from my side to the other kernel patches expect this one > > I've reviewed it enough rounds and given various code suggestions etc. > For me it is "good enough" or has been for a while. I just want this > test to work so that people doing kernel QA will automatically get it > to their testing cycle. That is why proper integration to kselftest > framework is a must May I have your "Reviewed-by" tag also for the patches #8-13? Not sure if I missed any other comments/issue you raised. I think all are addressed in v12. I will refine the test scripts (patch #14) in v13. Thanks Haitao