Received-SPF: pass (google.com: domain of linux-kernel+bounces-154410-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240418074652.126355-1-stevensd@chromium.org> <87wmopuobi.ffs@tglx>
In-Reply-To: <87wmopuobi.ffs@tglx>
From: David Stevens <stevensd@chromium.org>
Date: Tue, 23 Apr 2024 11:06:21 +0900
Message-ID: <CAD=HUj7cmO5x4aunD_sJoQ6BQxejiwqa8tMbORnGjB3gADiLxg@mail.gmail.com>
Subject: Re: [PATCH] genirq: Disable suspended irqs when restoring affinity
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 23, 2024 at 5:36=E2=80=AFAM Thomas Gleixner <tglx@linutronix.de=
> wrote:
>
> On Thu, Apr 18 2024 at 16:46, David Stevens wrote:
> > In irq_restore_affinity_of_irq(), after initializing an affinity
> > managed irq, disable the irq if it should be suspended. This ensures
> > that irqs are not delivered to drivers during the noirq phase of
> > resuming from S3, after non-boot CPUs are brought back online.
> >
> > Signed-off-by: David Stevens <stevensd@chromium.org>
> > ---
> >  kernel/irq/cpuhotplug.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/kernel/irq/cpuhotplug.c b/kernel/irq/cpuhotplug.c
> > index 1ed2b1739363..c00132013708 100644
> > --- a/kernel/irq/cpuhotplug.c
> > +++ b/kernel/irq/cpuhotplug.c
> > @@ -197,6 +197,8 @@ static void irq_restore_affinity_of_irq(struct irq_=
desc *desc, unsigned int cpu)
> >
> >       if (irqd_is_managed_and_shutdown(data)) {
> >               irq_startup(desc, IRQ_RESEND, IRQ_START_COND);
> > +             if (desc->istate & IRQS_SUSPENDED)
> > +                     __disable_irq(desc);
>
> Makes sense. But I rather avoid the whole startup/disable dance in this
> case and let resume_device_irqs() deal with it.

Thanks for taking a look at my patch. Should I send a v2 with your
suggestions, or will you create a patch for your tree yourself?

-David