Received-SPF: pass (google.com: domain of linux-kernel+bounces-154416-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <12f4d203-615b-0937-857e-ef0a478cd183@huawei.com>
Date: Tue, 23 Apr 2024 10:16:51 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.0
Subject: Re: [PATCH -next] genirq: Reuse irq_is_nmi()
Content-Language: en-US
To: Thomas Gleixner <tglx@linutronix.de>, <linux-kernel@vger.kernel.org>
References: <20240417085616.3785647-1-ruanjinjie@huawei.com>
 <87r0exun6e.ffs@tglx>
From: Jinjie Ruan <ruanjinjie@huawei.com>
In-Reply-To: <87r0exun6e.ffs@tglx>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit


On 2024/4/23 5:01, Thomas Gleixner wrote:
> On Wed, Apr 17 2024 at 16:56, Jinjie Ruan wrote:
>>  
>> +static bool __maybe_unused irq_is_nmi(struct irq_desc *desc)
> 
> Seriously? What's wrong with static inline?

Use "static bool" has follwoing warning:

kernel/irq/internals.h:283:13: warning: ‘irq_is_nmi’ defined but not
used [-Wunused-function]
  283 | static bool irq_is_nmi(struct irq_desc *desc)

But us "static inline bool" is ok.

I'll change it to inline, thank you very much!
>