Received-SPF: pass (google.com: domain of linux-kernel+bounces-154424-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: haibo.chen@nxp.com
To: linus.walleij@linaro.org,
	brgl@bgdev.pl
Cc: linux-gpio@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	imx@lists.linux.dev,
	haibo.chen@nxp.com
Subject: [PATCH] gpio: vf610: always set GPIO to input mode when used as interrupt source
Date: Tue, 23 Apr 2024 10:28:14 +0800
Message-Id: <20240423022814.3951048-1-haibo.chen@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?3ZeFVq+5ikG6UbLoUyW+Ef0Vo3dho8DtUkkMeN9f/CwcMowKD0q/cyvIKHLq?=
 =?us-ascii?Q?dAxESchQX5KSmuKL6560YCNoZ5Hk/w2pzl6dPoD4pJBxisDj/WqAeEM0XLIr?=
 =?us-ascii?Q?fJXCa5ub51UsBnvfj6ZM9SFcPrRBytKiXz5CtAfQ+gda5MtpCZtoXIVL5FbA?=
 =?us-ascii?Q?MSzbfTse9QXyXNviF549Te5KmuQfkHlTYN0jcqiA9qxD5+SVbFnolQraFghj?=
 =?us-ascii?Q?mzqMYgddiwknRaM3TwORrCMwr41stG9Uk2y73hUA9UBdc8tD/4QutNGSO6Rg?=
 =?us-ascii?Q?dNBkIe/vxhlGlWDtyI1HDW0gCHUnXVY6IA5H7r2C/SqysBLwKO+zL+Jq8/G0?=
 =?us-ascii?Q?23yijpPZynsjhyCG8lzHhdHIGZIf698sVFT5qfP5vJWE1p7LRblWLQfEaMcw?=
 =?us-ascii?Q?hmxUdsCVLJ51JhI8T+1GcLlokDIL80ZeUlRfxA3Bw2Ul03gGTk8BurIOWIlR?=
 =?us-ascii?Q?89PI5PPh449efy9VFcbDauicTanw1//psxiFh/eRpjJalFavkyyxENnFQncA?=
 =?us-ascii?Q?CiKTXBiEMHf9bW24EVeopWTGyVug6Inw7PPmHglGPkEZKUZM0bpJvbVxIRtn?=
 =?us-ascii?Q?nhVMIehIAOO4YWV2NePajFtC/ljpdKsuAo1LlRIrDkPVEKkQqTwvREeuWXP8?=
 =?us-ascii?Q?ldxYU5yo8DahwytsMptW2nl94O4EeBUrYP4376GPuuGF+4O5DjM6ciEz/By2?=
 =?us-ascii?Q?ewAxykSukP25LdHO+f3HKwnlc5XL5JbY7ynlyojN5jV4OOyyFJEwofKdOoCn?=
 =?us-ascii?Q?vwujeL+i4QHdNQ38lR1GVK6hZ5C0c9QHLGSB6bR3Q3U0zzPnNOJTcvW4aw5m?=
 =?us-ascii?Q?4eUK+rTONPmQgMpQ7eNfmcZ2kpehQcVpVTcRYkbTTSKvclslozDXHtuHZv2u?=
 =?us-ascii?Q?CkEFqaoox/k8MiycBau3qm7TC05CUnVM299golRUDrYIeK4ssfusrtKKphBt?=
 =?us-ascii?Q?TB9ESSG0gvQBd6Z+wKSd5awccSh3u/uVIX74OL70+BmsH/QEPBOMl8oxB/dP?=
 =?us-ascii?Q?qjD9glIapD/PU4B2tl09ePvr4b+Nvk9rMnz6MR3iI+yKlo16LwAMwizzAfNW?=
 =?us-ascii?Q?qfhA8znt8F/YR6x1F/tC/T++BsBi63Fo/GTBYBbpppg1D/CHPzF3i0foYAuS?=
 =?us-ascii?Q?fjBK1nbUsGNwIYAFk634H1xRwvrrdcuf5ruMbKv5m4z/3IJxaGkpc1RxpbtV?=
 =?us-ascii?Q?FI6Ec1nG/JCL2OU7lk3SzsmmVbtSdyqr1b6GwtmucWz863Zk5wK9hSKdY/Lh?=
 =?us-ascii?Q?DS6CtxwcQW4LoFbSjl3sjZ9EEArmIRnI0uZ/URTwdqW4dUrEyqAwMnpMtCuC?=
 =?us-ascii?Q?R2Z0Hh81fSxEdZV6GmpRhGMVl/IuOIXBgrzG2UdMQ7fBCkaTI6rDBDxlImY6?=
 =?us-ascii?Q?egp6Yr60yq+HAw5LGUrLHSv1a/RwIFNTuVsfxeEp/GDHaZLC+RDu0qAKxeaZ?=
 =?us-ascii?Q?GcgW5YuK/cPXbAZ/pqDFSepBFNjZPEboHUUKjbbXwNhWaQpL5GZFO0TdIia8?=
 =?us-ascii?Q?jeUS8EfCJNluclSfsxkhexJde6BnvhcKDXLxdn+JSE6HFcoghWmPHNQMbs1l?=
 =?us-ascii?Q?qUsJ6SdFjvh0h9ekLl2f47P9UHTpI8NivHEZxyBI?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f3abecc4-9490-49cb-7a60-08dc633d19f8
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9496.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2024 02:28:46.3119
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hOmJbWxz50VVh1fAUbEAB6io9QnSfDph4kEjO3LAGgUP7vk/jz/NozfbXGKust17qyHXeksdaAz2h633N49dTw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7098

From: Haibo Chen <haibo.chen@nxp.com>

Though the default pin configuration is INPUT, but if the prior stage does
configure the pins as OUTPUT, then Linux will not reconfigure the pin as
INPUT.

e.g. When use one pin as interrupt source, and set as low level trigger,
if prior stage already set this pin as OUTPUT low, then will meet interrupt
storm.

So always set GPIO to input mode when used as interrupt source to fix above
case.

Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
---
 drivers/gpio/gpio-vf610.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-vf610.c b/drivers/gpio/gpio-vf610.c
index 07e5e6323e86..305b0bcdee6f 100644
--- a/drivers/gpio/gpio-vf610.c
+++ b/drivers/gpio/gpio-vf610.c
@@ -214,7 +214,7 @@ static int vf610_gpio_irq_set_type(struct irq_data *d, u32 type)
 	else
 		irq_set_handler_locked(d, handle_edge_irq);
 
-	return 0;
+	return port->gc.direction_input(&port->gc, d->hwirq);
 }
 
 static void vf610_gpio_irq_mask(struct irq_data *d)
-- 
2.34.1