Received-SPF: pass (google.com: domain of linux-kernel+bounces-154429-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <9f23dd31-e7ef-4599-a13c-932ac288266b@intel.com>
Date: Tue, 23 Apr 2024 10:33:23 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC PATCH 1/6] PCI/RCEC: Introduce pcie_walk_rcec_all()
To: Dan Williams <dan.j.williams@intel.com>, Terry Bowman
	<Terry.Bowman@amd.com>, <rrichter@amd.com>
CC: <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20240313083602.239201-1-ming4.li@intel.com>
 <20240313083602.239201-2-ming4.li@intel.com>
 <d69c2157-a0da-4d8c-8684-d42afd285191@amd.com>
 <661e00eb808e4_4d56129429@dwillia2-mobl3.amr.corp.intel.com.notmuch>
 <84eb39a1-60dd-40cb-8c7c-dfd9a988732d@amd.com>
 <6626ecb93f752_690a29483@dwillia2-xfh.jf.intel.com.notmuch>
Content-Language: en-US
From: "Li, Ming" <ming4.li@intel.com>
Organization: Intel
In-Reply-To: <6626ecb93f752_690a29483@dwillia2-xfh.jf.intel.com.notmuch>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bHVQMnFxY3JYWXBYN1ExNHNaVW1QQWdReGhmTnhiRjlNbVNtZW5rT2tQOUtG?=
 =?utf-8?B?R0pJRGZEeG5ndFk2MTBPeUpST2xvVHNXK3BnVmRSRy9TS3hwZkVBNkNxT0J3?=
 =?utf-8?B?N2U4UnJXWGpQdHQvMUZjZkRCdUFKWG94c09Wbkkvb05KeWRDdzRhYmwvaVR0?=
 =?utf-8?B?K1Irei9rOTNJQ29yOGhaUzNpckZNZHFwNk1HTU4xeDIyZVg0YVFwaitYbmRt?=
 =?utf-8?B?ZjZ0V2hjNXc3VjVDc00wc2xXRTFJQW9URksyVVFNOE1iWm9ReGFqb2JrNHhm?=
 =?utf-8?B?emNMTHJVT1QzdFN3bnduVGtOVlN0ZmRsTkx1aTRqR1ZCSTRLSUQrck56SG1M?=
 =?utf-8?B?eXNNaEtzcEVHbGV0UmRIbjhBTnRUdGI1bG4zWThGdHZLZllBdC9qYTMvWmRN?=
 =?utf-8?B?ejUxWXdHOTBsbFd6TkY4Sk9QMTFRTUZLa3dSZzZoR3o5YTdFbjgrLzBqdW9U?=
 =?utf-8?B?NEpWd0VEM2p1YjRDaTBkdGthOXd0clBvVjdHcG9VbDF1SjJ1YVRrSmI2V1Jv?=
 =?utf-8?B?Wit0T3VpRnVYZGFHT1RJL2RrVDdMc200T3lYYS9wQ21ncE54ZVBpQVpNMlpV?=
 =?utf-8?B?ZFEyQlFNMHJEUW54WHR0ZXM1YkgvRi9VNktlOUJKQlF4TzhRR0VKek1GTHpz?=
 =?utf-8?B?cWhWazU3djh3OXVEWTRFaVJLaWY0bVRxSXZydENrQnRpTGRqdDVSelhtWEdW?=
 =?utf-8?B?bG5RL0p1aDlSUmlicG4zQWd0WG9oT1NSM3gvdmxxb1dsMm9JdEFmTmluK0ZC?=
 =?utf-8?B?N1NxL1l2RFJ4OVJPRlRYdnBGTXFXYVQvZkwvVjQ4enRHTVhKZjZKSS94NDIw?=
 =?utf-8?B?R0llRkZvY1JUbk9KK29seFU4MCs3aFI0ZGVWNXdSMDhpUzJ2VVR6ZG9xaU5h?=
 =?utf-8?B?YitZRklyc0theG9zTlhvbFpwNElLVnduRGRhUEc1SExnd3gyVyt1TG9UeFdL?=
 =?utf-8?B?TXR0Mlg1QWkvNVJERitDbTVjZ2I0M3N4eWFnVVdTTlRsR2llTWc4R3J6N2J3?=
 =?utf-8?B?WVd6ZkdEcXNYSGZYazM4VUpZd0Flc1VabDNLWjcvM2w0YjRiOS8vMmQ2MWs5?=
 =?utf-8?B?cndIeXBsRzBsYVpMSXNadm5jRG1nVDlpcEhVdTNZQjRZdkIvVmY1bU5qbkhE?=
 =?utf-8?B?bDJCV29WOW9lYkJzVXB1OGs5OEJmSk9mWjhCeHpjMkpNY1JvanIydTA2R25H?=
 =?utf-8?B?UkdMZFhFL1I3SGRiUnZUNDdHV2F3V2hUVWZmQS92a0JSaUpjcXpvVFZVeHlE?=
 =?utf-8?B?eFVMOXEvQXVBUndic0Z1UDdvRmZtZTZGMHdEbUlsTHNuWlN2S3B4VS9velM0?=
 =?utf-8?B?aXFjWUlWQ3BpSTlPdW5xRFhreEdSR25reCt5VzRJRXhFb2tGUjJyOFBCRCtS?=
 =?utf-8?B?bDFMTHp0eXpvOXo2Y0xSOHFHbmJzbkhBVGVySFR6cUNFWEpuK1NzdjVUK01h?=
 =?utf-8?B?Y1NRUjUyL0Z1WVVZT2JPN1BwTWN4cXZjR0VwS1R1QUtGN3JDUGgwNnFDajlM?=
 =?utf-8?B?ZFRPSVVhMWd5UXZ1MkFOTFB0aHVhM09YUmE1OVpIUXRGQStLQmhOQjVxNk1x?=
 =?utf-8?B?YXdwY0RMd0RMdFlvUjRVQ245SEwvSVJYSTlYU3dTbndxbkI0c0t3MWVJSHg1?=
 =?utf-8?B?cTBzNERNamcvQ3RjT2tBdnZxTGU1RHc2MFMzYjZZdW1EaC9LUGxyTjBtU21U?=
 =?utf-8?B?T3V5cUtnUDFiYjhydmhXMXJZbmVsMFJhNWxGcFFKV2NwSTM2eGU5TjJLN2JG?=
 =?utf-8?B?SkdhWjFMSThCa0FiQ3laK3B3QlRFclY3RmczSExHbzdUWWR0ZnhSWjFtZmty?=
 =?utf-8?B?cXhZaE1FVGNCU2J4NDRmZkVURkNHQlE0aVlMNEFVSmFMdEY1NlJlQU1uNkk0?=
 =?utf-8?B?VkdLVXhldmMxU2lFbHF2a0JFWlB3R3ZHa29DdHU3YXhERkk0dTlQT0NmSjkx?=
 =?utf-8?B?dmVNV2RjWGlNOVNRbnA0TEdhdkVQS3FIQ2h3aXZMMUozejV1SXpLcWYxaXFK?=
 =?utf-8?B?QlVsdzVSdmxtcEpiN1BIRS8ydWRVZ0hZa1RQOG5zZ1V3OTNqNVYyNndkZ005?=
 =?utf-8?B?QmFURWsyWWtZbUlQdk5PaWgwSGQwTkY0OXZhbFdEVG1xUUdHT1U1YTliaU4z?=
 =?utf-8?Q?m08ZZHAky4tfTBQL6vcdmzo+5?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c9514bfa-54ab-4a1c-c77c-08dc633dc45d
X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB7200.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2024 02:33:32.3264
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8YJKZ2T6pU1M3BE786i1/6BX5g82wfXKL89fLpBm0M7JJ22nIxciTz7avh+2zHOAKr8spq5fN/dMISxK3YY7Nw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7876
X-OriginatorOrg: intel.com

On 4/23/2024 7:03 AM, Dan Williams wrote:
> Terry Bowman wrote:
> [..]
>>> Hi Terry,
>>>
>>> This patchset is responding to the implications of the implementation
>>> note in 9.18.1.5 RCEC Downstream Port Association Structure (RDPAS).
>>> That says that CXL.io and CXL.cachemem errors in Root Ports may indeed
>>> be signaled to an RCEC. Do you expect that implementation note to cause
>>> any issues on platforms that do not follow that CXL spec behavior?
>>>
>>> My expectation is that it may just cause extra polling for errors, but
>>> not cause any harm.
>>
>> AMD platforms in RCH/RCD mode consume protocol errors in the RCEC's AER driver. AMD 
>> platforms in VH mode consume protocol errors (including root port errors) in the 
>> root port's AER driver. The exception is the VH mode host with CXL1.1 endpoint and 
>> RCH downstream errors. CXL1.1 endpoint and RCH downstream errors in a VH host are 
>> consumed in the RCEC.
> 
> I agree that's the most compatible path for existing software.
> 
>> I don't believe these patchset changes would affect this behavior. But, I will need 
>> to test to confirm.
> 
> As I wrote to Li Ming, I think any potential conflict can further be
> limited by the fact that this extra scanning is limited to CXL.cachemem,
> not typical PCI AER flows.

Agree with Dan, but I think that software does not have a chance to know if the error is a CXL.cachemem error withour RDPAS(only knows it is a uncor_internal_error/cor_internal_error reported by RCEC), maybe we can limit this extra scanning for the RPs working on CXL mode?