Received-SPF: pass (google.com: domain of linux-kernel+bounces-154435-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <fd806ed3-372b-4911-838d-975f3aeef1d7@redhat.com>
Date: Mon, 22 Apr 2024 22:53:30 -0400
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 -next] cgroup/cpuset: Avoid clearing
 CS_SCHED_LOAD_BALANCE twice
To: Xiu Jianfeng <xiujianfeng@huawei.com>, lizefan.x@bytedance.com,
 tj@kernel.org, hannes@cmpxchg.org
Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240423024439.1064922-1-xiujianfeng@huawei.com>
Content-Language: en-US
From: Waiman Long <longman@redhat.com>
In-Reply-To: <20240423024439.1064922-1-xiujianfeng@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 4/22/24 22:44, Xiu Jianfeng wrote:
> In cpuset_css_online(), CS_SCHED_LOAD_BALANCE will be cleared twice,
> the former one in the is_in_v2_mode() case could be removed because
> is_in_v2_mode() can be true for cgroup v1 if the "cpuset_v2_mode"
> mount option is specified, that balance flag change isn't appropriate
> for this particular case.
>
> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
>
> ---
> v2: remove the one in is_in_v2_mode() case.
> ---
>   kernel/cgroup/cpuset.c | 5 -----
>   1 file changed, 5 deletions(-)
>
> diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
> index d8d3439eda4e..bb9bf25889c9 100644
> --- a/kernel/cgroup/cpuset.c
> +++ b/kernel/cgroup/cpuset.c
> @@ -4051,11 +4051,6 @@ static int cpuset_css_online(struct cgroup_subsys_state *css)
>   		cs->effective_mems = parent->effective_mems;
>   		cs->use_parent_ecpus = true;
>   		parent->child_ecpus_count++;
> -		/*
> -		 * Clear CS_SCHED_LOAD_BALANCE if parent is isolated
> -		 */
> -		if (!is_sched_load_balance(parent))
> -			clear_bit(CS_SCHED_LOAD_BALANCE, &cs->flags);
>   	}
>   
>   	/*

Thank for the v2.

Reviewed-by: Waiman Long <longman@redhat.com>