Received-SPF: pass (google.com: domain of linux-kernel+bounces-154489-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Mon, 22 Apr 2024 21:10:29 -0700
From: Ira Weiny <ira.weiny@intel.com>
To: Dan Williams <dan.j.williams@intel.com>, Ira Weiny <ira.weiny@intel.com>,
	Dave Jiang <dave.jiang@intel.com>, Jonathan Cameron
	<jonathan.cameron@huawei.com>, Smita Koralahalli
	<Smita.KoralahalliChannabasappa@amd.com>, Shiju Jose <shiju.jose@huawei.com>
CC: Dan Carpenter <dan.carpenter@linaro.org>, Yazen Ghannam
	<yazen.ghannam@amd.com>, Davidlohr Bueso <dave@stgolabs.net>, "Alison
 Schofield" <alison.schofield@intel.com>, Vishal Verma
	<vishal.l.verma@intel.com>, Ard Biesheuvel <ardb@kernel.org>,
	<linux-efi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-cxl@vger.kernel.org>, Ira Weiny <ira.weiny@intel.com>, "Rafael J.
 Wysocki" <rafael@kernel.org>, Tony Luck <tony.luck@intel.com>, "Borislav
 Petkov" <bp@alien8.de>
Subject: RE: [PATCH v2 3/3] ras/events: Trace CXL CPER events without CXL
 stack
Message-ID: <662734b5cd6d4_bbee629455@iweiny-mobl.notmuch>
References: <20240422-cxl-cper3-v2-0-5cdd378fcd0b@intel.com>
 <20240422-cxl-cper3-v2-3-5cdd378fcd0b@intel.com>
 <6626fdc7b7e31_690a294a6@dwillia2-xfh.jf.intel.com.notmuch>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <6626fdc7b7e31_690a294a6@dwillia2-xfh.jf.intel.com.notmuch>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?AM12P3qKTOS03L3oxaMND8sqfMPsZTvcnhiW9/jYXh5cLF9HD7AufwU3Jp2S?=
 =?us-ascii?Q?Y1POGoc8hW08xT5+0EjAMNKu5iEfUk48VmkfB/mUb35QyeARr7Qtx5wnuOcK?=
 =?us-ascii?Q?p30W9W1jAEq/reUX8tlX/VPkDC46dT5H4p0y8BX+pq2k+iQ8p9WCpyxIiZaD?=
 =?us-ascii?Q?A2+Lva/fbYVe9Y5B/kvja0o9wFkkWFMiv2KfyKwuVtP1/fSOoaBjpS7rTlID?=
 =?us-ascii?Q?zLo8F8PHXClL6xVTbw5OWqWvLCTWGenawT3ExFU+ro9+PGdpN684rrVFjBp+?=
 =?us-ascii?Q?hi4PBzrRw6xkwAEORgnK/1u+mIrsBUWs1+5QyBosO2flOgqgC4zcCBworcUZ?=
 =?us-ascii?Q?08Ab0hsjzmNR6MGyxe4dsvmzyEhSrx+1ixrQ2tzcBt0hc7wGK/WDeJYU3dPp?=
 =?us-ascii?Q?N8S2TUm6n18FBxTZDlEzFcanhXxpsFwmr0pFo5rqhL7wMaPTLrewWnnfraJn?=
 =?us-ascii?Q?c8vY1i3Tls5EvffGnej9miXGm0jSdZ324tiSsSLBpJdQoMa0quM7pD86CClQ?=
 =?us-ascii?Q?Qfxzr0kQkLZXBag3j2vN7PP3LUQfdjZfHAgFxxLIriNoVvohBVL3JU+SRQZ3?=
 =?us-ascii?Q?RiYNcocPDSU7LdF9rRNT6NucmJWtWdA1SKTe7wL406yfBC08arSYTU9SBRiN?=
 =?us-ascii?Q?XMOGu17b17z0i0X5rram9NmPabrK8MMSghKBPVCDfJNKD8e4jzoVF5S5Xpic?=
 =?us-ascii?Q?mv8juK/GDqr68vTkSC0TcXH2RZxvSC4hqm/8VXUiv5EX73Cjt+IRtLP93ynG?=
 =?us-ascii?Q?eH6fqdnTJs7Kwfsma5Nd8/hydCCyic9FtEI5ZAjj3g36wVOBFqDHsNYSca7u?=
 =?us-ascii?Q?bnQgTBu3o3twgwj5PEWYRzz0WRZ185IKqn8dWQAAtb+IG7+a4rujs2QTgP60?=
 =?us-ascii?Q?aq2WoU093k2Q1N8b0v8C0wdFDFPNrvkxy7Mawf48MBM7nKO+QD1FCEWw3NQA?=
 =?us-ascii?Q?su2G/H6QCYAV9HvTcPKFxevXKCTxp1qv8bHgU7ggFANhytbJxOyajbzc10x2?=
 =?us-ascii?Q?tC+Ewf+G5mTA+ph4VGob7x9R/o2FVdZIXg9OqGrK8GcVVKKel85/7fwr1uws?=
 =?us-ascii?Q?GnYGuSUZgvFf2DTrw5G3bmU8ATUSLjzUNBVOKKn8elo5Rc7gycIoAM+92hN+?=
 =?us-ascii?Q?LtXyxdPwOkZ/8MYWwxpD4kxa53+6JgHTxKggwIhj2Bp2tihVX7sWtsesFfOJ?=
 =?us-ascii?Q?zi0mWCUePZ9etkhOz8iiTXT2ztZd57w0ySreiQTBQYVVx34/wbn4q+BpUHDz?=
 =?us-ascii?Q?2nm5XsA7UpHUR2T62nRB7mBcWUZqqhGPZbUsuWsmD54aQ0KAJDAqXj2xkt7C?=
 =?us-ascii?Q?diiFGzDVHiW1YIMMIGdFyOmj2HC2ZxgE71HEgYkyFCOSes9+zjeVpDUtUNzp?=
 =?us-ascii?Q?bK8Llf/m6V8R5RZSj/ENoT90nCgyznxpBXmo2Qmgx5wvSIZzFIFd4oBwTOG+?=
 =?us-ascii?Q?eEXSnWtQ5pgc6edYl3sB3MNsH+1CJl/xyZ5whoiJStrwu679NrO5f4TNKz8B?=
 =?us-ascii?Q?8t7kBWBXPVVsYG8HbjJlJ2ZEkeKUdA3ILZXN5qnngkxgIiHF8VfXwm0pCPdc?=
 =?us-ascii?Q?4DV0Ts+xpkkoBlhZxMSBwOSbuI3Rfw3row4yBfyb?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 57594fd5-797b-43c2-5e04-08dc634b5287
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2024 04:10:33.9749
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nrXbKiuEcvtcxk830/FMX7CEKY7QcrmQyxJb3SLjmzG81rXh24AaLDPJwZAQw8ZVLE5Xcobii6Vgg9xD+ur3gA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB8668
X-OriginatorOrg: intel.com

Dan Williams wrote:
> Ira Weiny wrote:
> > If CXL is solely managed by firmware (including HDM configuration and
> > event processing via firmware first) it is possible to run the system
> > without the CXL software loaded.  In this case no CXL callback will be
> > loaded and CXL CPER errors will not be processed at all.
> > 
> > In this case memory device and region (HPA) information is missing but
> > omitting the error completely is not friendly.  Some device information
> > is available the event.
> > 
> > Trace CXL CPER events if the CXL stack is not loaded.  A balance was
> > chosen to decode only the CPER header as this configuration is likely
> > rare.
> 
> I think the justification for this is weak and it pollutes the user ABI.

Do you want me to drop this patch or slim the tracepoint down even
further?

Looking at this again I feel like 

	54ce1927eb78 ("cxl/cper: Fix errant CPER prints for CXL events") 

Was a mistake.  PCI AER errors are both printed in
cper_estatus_print_section() and again printed/traced in pci_print_aer()

Why should CXL be any different?

Ira