Received-SPF: pass (google.com: domain of linux-kernel+bounces-154492-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <6a7a8892-bb8d-4f03-a802-d7eee48045b5@amd.com>
Date: Tue, 23 Apr 2024 09:52:41 +0530
User-Agent: Mozilla Thunderbird
Reply-To: nikunj@amd.com
Subject: Re: [PATCH v8 06/16] virt: sev-guest: Move SNP Guest command mutex
To: Borislav Petkov <bp@alien8.de>
Cc: linux-kernel@vger.kernel.org, thomas.lendacky@amd.com, x86@kernel.org,
 kvm@vger.kernel.org, mingo@redhat.com, tglx@linutronix.de,
 dave.hansen@linux.intel.com, pgonda@google.com, seanjc@google.com,
 pbonzini@redhat.com
References: <20240215113128.275608-1-nikunj@amd.com>
 <20240215113128.275608-7-nikunj@amd.com>
 <20240422130012.GAZiZfXM5Z2yRvw7Cx@fat_crate.local>
Content-Language: en-US
From: "Nikunj A. Dadhania" <nikunj@amd.com>
In-Reply-To: <20240422130012.GAZiZfXM5Z2yRvw7Cx@fat_crate.local>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?QURVRExZNkRpNmlGK1JjOERIUyt6NjdCUkk1b1JydmZTN3cyZkhFbWhNNWdP?=
 =?utf-8?B?VEdLbWZkdkE5QnFuNUFoUzh5NXNpN2ZGMnVLR3pQZmlWdkJNT1FXM0h3Qm94?=
 =?utf-8?B?SVJ3VjB6VXlIV1NYNnBzSnlCbGN2VmJlSlEwUml6aGFTVXRZNmNMWFNMRUps?=
 =?utf-8?B?U2diMHRDeklWWm1HZHIrVjRONTA0V2VIaVVldnBpK29XNkxNbDJ1NnZYYUcr?=
 =?utf-8?B?SnRNclQ1Y3E3N2p0alhGUHhkRmlGN2QySHpnV09HdTVBbTRsZFl0NDROaUdW?=
 =?utf-8?B?M2QwYjk5Vm9oeERZbGo2ajNkdThCdVUzdEluRFczUmhDQkFpWDBROVRiUG0r?=
 =?utf-8?B?eHNVQmx2TzNFSWRmei9RODdWd1pTQ2d1UUozbE9YMFMveWpUWUtTcndacG9E?=
 =?utf-8?B?VzZuSFd0cFAyVjhoL1dETjhtUHdPazZyV1lNRTlFZlo5V2YvWW8rUFRENzho?=
 =?utf-8?B?T3J4ZkwxZnVHZlJDTFVNVmtNcE5PRzBTandLRWI0dU1BaDIyc3BTcmhQdjli?=
 =?utf-8?B?dGJKVlVmWWFSZC9zUFBpMFNZRjAzVFNRSVZMRFNKVU9PWmNkdThBYWcwU25v?=
 =?utf-8?B?SkR4Qm13M2FvOFl3a0FHK0lNWUFnMENxZTdYTVFvRWlqSGN4ODlaTENSazB0?=
 =?utf-8?B?YmxMb3Vad0wxbnJSMXJXY3Qrc3pKZHdTVE1qQ1ZjaVVsSkpXc2Z6UFVnZmls?=
 =?utf-8?B?YUxabll3dXNhZ1lqa0pOQi91Zy8xenpOQXprcHFIaTVMWHV1RWZyQXZ6NDZi?=
 =?utf-8?B?RUpPSTFOdWVDVWRjWHpPY3grYnRmbUZKZk9IanN6N1FVMnBmVjJwYTBHbWN0?=
 =?utf-8?B?YkVmWERUN1V1Z2wxWHVIam8zOVlEeC9qaUtob0pQMjFmQjNEclJaeVU4cVBL?=
 =?utf-8?B?Rm9qRTJBcUZnRGhWd1Bxd2gxTi8xb0Y4Uy8wNkhka3Vmc0VvbHFxZWxLNnVQ?=
 =?utf-8?B?NFVOOXdvNGR6MmtwbXpoRTU5ZW4wcFRkc0QrYjRJdTFPMUIrVUwrbzQ4VGR6?=
 =?utf-8?B?eWMvclRLNzlmeHVuZTAwdEx1MXV6TEJXOHhrTWl4b3plcTdsbzh4T0thYSs4?=
 =?utf-8?B?NkdaYytkUER3Y2h4VkVDL21aUWFFZmhIdDhDWDBPejRwZXVRQ1NHd3V4VnJZ?=
 =?utf-8?B?a09ZWEFrSTBnZlVmVXpEMWF5ZTRzWlV3M2tpaWpwMVFtZ1AzSnB2ODdIbnlT?=
 =?utf-8?B?R2J2WGxmeVo5WGhxcW44OGNaekdKYlN5YkRQbWk5QlVIby9nQ1R0eUZoM3Nk?=
 =?utf-8?B?V0xMVnJnbUg1MFpHWXdoYzFBaTZWNzJlWlBDSURBbzJwSkFjYzlsR095S01v?=
 =?utf-8?B?SXVoS0prTGU3YVZBSlBaME9FQ3ZDNFo4SXZDQUFoN24zMGw3bTRtL1VVQ1Ur?=
 =?utf-8?B?L0NPbDNFZFJIcWdUWmtnN2VPYmJEZ3NhcGtMSllLdGlIM1c1UVI4eDFwNUNI?=
 =?utf-8?B?cDZpc3k5Wkh1cFdjMUZJb1BZUUxVZHQ4cCt1QXRQeFJHcFFOL3RUVy8zTzRl?=
 =?utf-8?B?c2kvOU02Z1hzekRvcmpuWGdPR2kybFJHQlF2LzRDcUxLNzZpV0xUcFJoOUxy?=
 =?utf-8?B?Q0F6dUdFOXc1c2JpMHpSWkVaQ3lOZFlTdkpvSVVJYjAyTmg5a0tvWW5tVjJG?=
 =?utf-8?B?UFJoSzZoYUQvL1VkZ2RKYzJXS0E0T245RnJpSTFXOXBCYzRmc3N4bGg1OW0x?=
 =?utf-8?B?U1ZrQzVVSk1iakluRUN0SnI3QkJQdU1jOEtOdGdEbXhtWkI2TFdYMWIvRERS?=
 =?utf-8?B?VFVzRXN1M0ZoRis5VXY0VytTU1dQZjJWbVM4THBpdXZ6cUluYmxNYTZOSlZr?=
 =?utf-8?B?aEVhTWRUUDhxMW5WTWJiSXpkeUZXMVhTLzZHbThack4yb2NFQnJueEM1TERC?=
 =?utf-8?B?WjdlaURrYzkvTHFRNEtGSUEzazk3a0l2L2FRQzJVU0xHWVgrMUkwak5mYXlk?=
 =?utf-8?B?L3piTFZKOWJhZDN2aHhJM2c5T0NtMDdiWWd5Sm5yN0tIWElFcGUvQytCNGxo?=
 =?utf-8?B?SGxiVGJONmtYQjVtK1Q5eFN3Rm5vV3RacVFBZGJHdUR2b040bzcyQ0xJWTR0?=
 =?utf-8?B?M0dHbjNBVXJHTS9zQnZwZ01wQUpSaWNpL3k0RTBmMy9kQW4yVlJXOTMxdm1r?=
 =?utf-8?Q?o1pUohlJIbMXjM/SigaKFCdOp?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c03c2982-f3db-4210-d100-08dc634d0a74
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6309.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2024 04:22:52.2341
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: d5VLk8TJzo0KtS0m1Bs6Oa5iC/PguNz6uOxH2AEFELlaIkIn6imwCjZhEZGmJEeT9kl9CM8CMDQE6NIMpOEblg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8766

On 4/22/2024 6:30 PM, Borislav Petkov wrote:
> On Thu, Feb 15, 2024 at 05:01:18PM +0530, Nikunj A Dadhania wrote:
>> SNP command mutex is used to serialize the shared buffer access, command
>> handling and message sequence number races. Move the SNP guest command
>> mutex out of the sev guest driver and provide accessors to sev-guest
> 
> And why in the hell are we doing this?

SNP guest messaging will be moving as part of sev.c, and Secure TSC code
will use this mutex.
 
> Always, *ALWAYS* make sure a patch's commit message answers *why*
> a change is done. This doesn't explain why so I'm reading "just because"
> and "just because" doesn't fly.

Sure, will change.

> 
>> driver. Remove multiple lockdep check in sev-guest driver, next patch adds
>> a single lockdep check in snp_send_guest_request().
> 
> The concept of "next patch" is meaningless once the patch is in git.

Sure. As direct access to the mutex was not available now, I had removed lockdep
check here and documented that lockdep gets added at later point.

Regards
Nikunj