Received-SPF: pass (google.com: domain of linux-kernel+bounces-154503-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <eadcab6f-b533-49e3-9aec-dc06036327f5@amd.com>
Date: Tue, 23 Apr 2024 09:56:38 +0530
User-Agent: Mozilla Thunderbird
Reply-To: nikunj@amd.com
Subject: Re: [PATCH v8 07/16] x86/sev: Move and reorganize sev guest request
 api
To: Borislav Petkov <bp@alien8.de>
Cc: linux-kernel@vger.kernel.org, thomas.lendacky@amd.com, x86@kernel.org,
 kvm@vger.kernel.org, mingo@redhat.com, tglx@linutronix.de,
 dave.hansen@linux.intel.com, pgonda@google.com, seanjc@google.com,
 pbonzini@redhat.com
References: <20240215113128.275608-1-nikunj@amd.com>
 <20240215113128.275608-8-nikunj@amd.com>
 <20240422131459.GAZiZi0wUtpx2r0M6-@fat_crate.local>
Content-Language: en-US
From: "Nikunj A. Dadhania" <nikunj@amd.com>
In-Reply-To: <20240422131459.GAZiZi0wUtpx2r0M6-@fat_crate.local>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aStZMjdNRDl0OGZUNFVMWTN0OU16MWt4N2EvNGIrOWd5TytpQlMrT3krZXFa?=
 =?utf-8?B?d1I3SHQrcmtwVlJ6Sm0zWGxKbHhuS3NzY0tMVXpWbGxmNWpLSnlGbTlZTEFr?=
 =?utf-8?B?amJiaVZ2RlYrNWdLak5MUVN4cHBraXRvV2tWOTIyL2Rvb0poeGFZVUt6MnRm?=
 =?utf-8?B?NzR6eWRoNlBmUUtKZG5OQUlRbGRpOEFxd1NudDFNNFFXcm9ra3owL2EwdklR?=
 =?utf-8?B?MlJHa3g4dmxDc2Y3NjlaMWJ5WHpJdXlsUVNlVlZVUUprQjBUeHpVSlJJYm8w?=
 =?utf-8?B?NzY4TStheGFQMXZldWo5RU0rblM5Rzl4V1JoekdWRXppMDVQaEJuUlRoOWNw?=
 =?utf-8?B?WlhpOGZWOXQxK3Q3Z3FMTmx3S2ZFcHoxcXQvczBiUFJkR2k4eEYzVi82YkF0?=
 =?utf-8?B?SzZCQ0lrc3kwZFcxTnpUVER3ZU82a2tDWGRlZ1lZU3RLMjVnL0FCc1RJdHp4?=
 =?utf-8?B?TkZqUnV4eXBhMjRNUWtYVE1RU1BGL1VEMjhwZVRTTU1qRlNOV1oxdlN5ME0v?=
 =?utf-8?B?L3ZWUGo3Vm5MSk5KSDhpeDlpYU9odlMzcUMyVDlmY0JIVzNoMVQxQTZTdDBt?=
 =?utf-8?B?cFl1ZVYvREsxSnkzUW8rbmltTkdKSmFzZlN1NlFzL285eFRjZWtGM28rWjAv?=
 =?utf-8?B?OExzNlVRbUp2VTFSN052OWZqdnJRNFZRVzhQeTlHYzloMW9MMS94U1BlZ0J5?=
 =?utf-8?B?VjZ2andpT2kxZFJjSVBMYkdVWlBvUUpUbjZKRC9UNStwaE1KT0VkcTM0Z09H?=
 =?utf-8?B?K05aMURrbzJNZWFyNEZRUHlnN2VORkxEVU1SYnpYT0ZmNGpXTDRrQWVuYXhh?=
 =?utf-8?B?eVZ2bzhHazJNOTdFYXkraUNyTTlxakdad0NxV3VBdllvV05tU0lqWmQrS0Ft?=
 =?utf-8?B?MXFJMElud1pVSGUzZ2d1RkNyTW5BMzhTYUVxZExBM0xCbEEybC9kSE4xSFFm?=
 =?utf-8?B?OUhCSlU4aldieHZPbFowM0xTT2h1Z2thZzFUVG9uazRiUUVIU0E4WHFCdHdy?=
 =?utf-8?B?QWdSVmlqbXlDeXN5VXlMd3JFTmw3Mk9VeE5PMFZaSHhFMEw0UGpxUWJkdmVF?=
 =?utf-8?B?SkRsWXc3VHlxNGlTaDk4UzFpV3plc2xOVXA1amVLZTYvbUVwNWJOWHMwdnU4?=
 =?utf-8?B?ZDNtc1p4eWVDQmFucWNnbFdrOGpIWEFlNzdodVdhZFlsK3E4TGgvZkF3a2xk?=
 =?utf-8?B?L2lreklRSmh2VE9LYzIwTWRvZ0hFQXVCZ2Z3b3lYNi9SL0YwZlNEOXJkcm9h?=
 =?utf-8?B?aXEvbURxMzV3bDdaRDJDcVNjbWpqdEdUOWtLbFZwTlRFOGlObWJ6VVZwRjhD?=
 =?utf-8?B?aDFkWmVBOVFXVXkvOW16UndpdkI5VXljdExyVi9HazVzc0xFYzY5Q2ZhdzJP?=
 =?utf-8?B?d0x0RVpyTDh4TTI3MHFLZHZ1K2RnLy9KcmVsM3Z3ZG5VaXJ5bytlWTBTbERW?=
 =?utf-8?B?MElkRWdnaDlxclRWWTMvcnNTNGdtTTR6SWxRMGVaT1pRSFAvWkU1UURFQ0Nr?=
 =?utf-8?B?WFQzeEo0REVkTXBVNTdUWU5Penc3MmVmTko5a3JrZHJURXlvU3pCZDIwb0JV?=
 =?utf-8?B?SnplQ1J6c2JGTTJiVVV1dm9vSEZhKzZ2TGJKSStycWM4NThFeDgvTXcrbzFn?=
 =?utf-8?B?N21mRGJRZzlxODZJNEV3d1dGZ1dPdjlNdnJWcGE0aWE0SFFPaXZiRk9TbERY?=
 =?utf-8?B?NW5tZGE4TGdlSlBJYzlTYS94WjNQR3hnUml4VXBZcjlkUWl4K210T2paNHlR?=
 =?utf-8?B?U2k0Z3FCWFprTkhGVkxDWjhMMnlBNG9paDd1WnBnRHdTckFOajV0Y1RUWFg0?=
 =?utf-8?B?YmtQSFZpYVQ2blBLbzEvcS9IUnZXeUJqTWZyN3prNWZmVnFCZWJ6VkxPbjVJ?=
 =?utf-8?B?M01zYW1reGRMMy9wMStGVFpJYTYzeTJ5Sis1bjIrSFBWaGxnVVM4UGJrZjRW?=
 =?utf-8?B?ZXd0NjhNOVdVS3NweERZVm5taVYzd2tPWFljSWNJVzJzbkhGczJ2Q25MckVk?=
 =?utf-8?B?V1VpUUJYSnFoTmlOUS9scW5GQTFuK2F0bXZ5RXVLM2lPVnpFNEloNHBVN0Zs?=
 =?utf-8?B?NHNCVHNOdEhlQXU1NHZRYnEwMHdTZllwV216aHU2alVJK081TG5qTm91Nmhx?=
 =?utf-8?Q?ph6iISRloKZSWH12g07EvRyMZ?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: edc30ffc-e130-4ace-1079-08dc634d9844
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6309.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2024 04:26:50.1447
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uM4Lo0yVv5l4fMCDX8RfMpA1VgD3GDrD9UKu24dn42krYm0Th8opWT+BQ4B1HgUHUJIPw+05boU5UIVSlDN3pw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8929

On 4/22/2024 6:44 PM, Borislav Petkov wrote:
> On Thu, Feb 15, 2024 at 05:01:19PM +0530, Nikunj A Dadhania wrote:
>> Subject: Re: [PATCH v8 07/16] x86/sev: Move and reorganize sev guest request api
> 
> s/api/API/g
> 
> Please check your whole patchset for proper naming/abbreviations
> spelling, etc.
> 
> Another one: s/sev/SEV/g and so on. You should know the drill by now.

Sure.

>> For enabling Secure TSC, SEV-SNP guests need to communicate with the
>> AMD Security Processor early during boot. Many of the required
>> functions are implemented in the sev-guest driver and therefore not
>> available at early boot. Move the required functions and provide
>> API to the sev guest driver for sending guest message and vmpck
>> routines.
> 
> Patches which move and reorganize must always be split: first patch(es):
> you do *purely* *mechanical* move without any code changes. 

Yes, I had tried that compilation/guest boot does not break at this stage. 
That was the reason for intermixing movement and code change.

Let me give a second stab at this and I will try just to make sure compilation does not break.

> Then you do the code changes ontop so that a reviewer can have a chance of seeing
> what you're doing.

Sure

Regards,
Nikunj