Received-SPF: pass (google.com: domain of linux-kernel+bounces-154533-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <98273dd8-a5df-45bf-a46d-80fdba6cfb39@gmx.net>
Date: Tue, 23 Apr 2024 07:44:13 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] arm: dts: bcm2711: Describe Ethernet LEDs
To: Florian Fainelli <florian.fainelli@broadcom.com>,
 linux-arm-kernel@lists.infradead.org
Cc: andrew@lunn.ch, Rob Herring <robh@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>,
 Broadcom internal kernel review list
 <bcm-kernel-feedback-list@broadcom.com>,
 Andre Przywara <andre.przywara@arm.com>,
 Claudiu Beznea <claudiu.beznea@tuxon.dev>, Baruch Siach <baruch@tkos.co.il>,
 Shawn Guo <shawnguo@kernel.org>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 Enric Balletbo i Serra <eballetbo@gmail.com>,
 Heiko Stuebner <heiko@sntech.de>, Viresh Kumar <viresh.kumar@linaro.org>,
 Paul Barker <paul.barker@sancloud.com>,
 =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= <uwe@kleine-koenig.org>,
 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
 <devicetree@vger.kernel.org>,
 "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
 <linux-rpi-kernel@lists.infradead.org>,
 open list <linux-kernel@vger.kernel.org>
References: <20240422230811.1284092-1-florian.fainelli@broadcom.com>
Content-Language: en-US
From: Stefan Wahren <wahrenst@gmx.net>
In-Reply-To: <20240422230811.1284092-1-florian.fainelli@broadcom.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:4zdTdeny15U=;BvIT53Gj1l3qShp4UDfDN09ceY7
 xAdrirEVfjnjAT4XjD2zExzQxjBcv3m1AQ2MdbsBonyE1tvyZJujE2I8h0c6wR535WyJsZukN
 LXCi7Ng+hfsIPLXiH4hX3sDSGxE2Y4oht9gF3T11cHz0UfNN7gZ8u5qoOvftduHAeqKmuzTTz
 fBWjb1DzStMXW0VdjqZwgeGzIPEZHmH3CCSTGdpw4M1FPaNa3l8GnD4KmE7CF/JTxrw0C5bbM
 wWX8tLiHc4farMMC8iWXQaoOAPeuxMXJaeEZ7347dDBxTgFDNwkXZHH3fQEUpiapVXvrVVhdx
 aNpjJyL+clWeeC/hJgsQdYw16QP/bpHqK9lkunQa6czNbtQfVpLsYVX0INjGAbo+9OWuMhTot
 8FZWmUbuBj8fufbh3thcajNiKBh8L3JMBVi3+7cQXPtqy9zwThIQIEsaYCjfaw6RZTBnNXXm4
 osJRzMlBCLERVPd9rJUCX9OBW2XbnIYXLEaP5SGjQSo+CQMubGt5czw5M2Wy3t49Y+bdRQYty
 wjB2y+790Zqc/xIuRdtjErTZIU2tlYdcsLhsDn5AIzWcyjCUWcVWqtG7Wnt4sF897i08OPY1R
 3aHHxa3gpQrfWCnnUi8OnyOuDIBbRT6ZsutqQRWeUp4IqnuxG+EIHtXLm41Chu4X+0RC0meAv
 HPUg0pLfZwei0kTrET1C7Zut14yXz13m6MltzApDVG9oYnwfu7ZsNLJMox6Ee5dtI1nzDi2Ux
 QIjhSK3ZCtcfw3cfz0Cssjm8uqNfKqxvgGyz1OELyu+Idal3RlaNwn9a8/wpAEXVuKScSsbaf
 sIK4n154CxbIfoeUbOSNB5qsB1xrXui4wxojuraeFHJF0=

Hi Florian,

Am 23.04.24 um 01:08 schrieb Florian Fainelli:
> Describe the Ethernet LEDs for the Raspberry Pi 4 model B board as well
> as the Raspberry Pi 4 CM board. The Raspberry Pi 400 board does not
> include RJ45 connector LEDs so the 'leds' node is deleted accordingly.
>
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
> ---
> Changes in v2:
>
> - added "function =3D LED_FUNCTION_LAN"
>
>   .../arm/boot/dts/broadcom/bcm2711-rpi-4-b.dts | 20 +++++++++++++++++
>   .../arm/boot/dts/broadcom/bcm2711-rpi-400.dts |  1 +
>   .../boot/dts/broadcom/bcm2711-rpi-cm4-io.dts  | 22 +++++++++++++++++++
>   3 files changed, 43 insertions(+)
>
> diff --git a/arch/arm/boot/dts/broadcom/bcm2711-rpi-4-b.dts b/arch/arm/b=
oot/dts/broadcom/bcm2711-rpi-4-b.dts
> index cfc8cb5e10ba..7a0f495ff726 100644
> --- a/arch/arm/boot/dts/broadcom/bcm2711-rpi-4-b.dts
> +++ b/arch/arm/boot/dts/broadcom/bcm2711-rpi-4-b.dts
> @@ -5,6 +5,7 @@
>   #include "bcm283x-rpi-led-deprecated.dtsi"
>   #include "bcm283x-rpi-usb-peripheral.dtsi"
>   #include "bcm283x-rpi-wifi-bt.dtsi"
> +#include <dt-bindings/leds/common.h>
>
>   / {
>   	compatible =3D "raspberrypi,4-model-b", "brcm,bcm2711";
> @@ -204,6 +205,25 @@ &genet_mdio {
>   	phy1: ethernet-phy@1 {
>   		/* No PHY interrupt */
>   		reg =3D <0x1>;
> +
> +		leds {
> +			#address-cells =3D <1>;
> +			#size-cells =3D <0>;
> +
> +			leds@0 {
> +				reg =3D <0>;
> +				color =3D <LED_COLOR_ID_GREEN>;
> +				function =3D LED_FUNCTION_LAN;
> +				default-state =3D "keep";
> +			};
> +
> +			leds@1 {
> +				reg =3D <1>;
> +				color =3D <LED_COLOR_ID_AMBER>;
> +				function =3D LED_FUNCTION_LAN;
> +				default-state =3D "keep";
> +			};
> +		};
this looks good to me, but i'm wondering about the address numbering.
This ones starts with 0 and the CM4 starts with 1. Does this come from
the PHY?
>   	};
>   };
>
> diff --git a/arch/arm/boot/dts/broadcom/bcm2711-rpi-400.dts b/arch/arm/b=
oot/dts/broadcom/bcm2711-rpi-400.dts
> index 5a2869a18bd5..ca9be91b4f36 100644
> --- a/arch/arm/boot/dts/broadcom/bcm2711-rpi-400.dts
> +++ b/arch/arm/boot/dts/broadcom/bcm2711-rpi-400.dts
> @@ -30,6 +30,7 @@ &expgpio {
>
>   &genet_mdio {
>   	clock-frequency =3D <1950000>;
> +	/delete-node/ leds;
>   };
>
>   &led_pwr {
> diff --git a/arch/arm/boot/dts/broadcom/bcm2711-rpi-cm4-io.dts b/arch/ar=
m/boot/dts/broadcom/bcm2711-rpi-cm4-io.dts
> index 7c6a5bdf48aa..76cb20373095 100644
> --- a/arch/arm/boot/dts/broadcom/bcm2711-rpi-cm4-io.dts
> +++ b/arch/arm/boot/dts/broadcom/bcm2711-rpi-cm4-io.dts
> @@ -1,5 +1,6 @@
>   // SPDX-License-Identifier: GPL-2.0
>   /dts-v1/;
> +#include <dt-bindings/leds/common.h>
>   #include "bcm2711-rpi-cm4.dtsi"
>   #include "bcm283x-rpi-led-deprecated.dtsi"
>   #include "bcm283x-rpi-usb-host.dtsi"
> @@ -110,6 +111,27 @@ rtc@51 {
>   	};
>   };
>
> +&phy1 {
> +	leds {
> +		#address-cells =3D <1>;
> +		#size-cells =3D <0>;
> +
> +		leds@1 {
> +			reg =3D <1>;
> +			color =3D <LED_COLOR_ID_GREEN>;
> +			function =3D LED_FUNCTION_LAN;
> +			default-state =3D "keep";
> +		};
> +
> +		leds@2 {
> +			reg =3D <2>;
> +			color =3D <LED_COLOR_ID_AMBER>;
> +			function =3D LED_FUNCTION_LAN;
> +			default-state =3D "keep";
> +		};
> +	};
> +};
> +
>   &led_act {
>   	gpios =3D <&gpio 42 GPIO_ACTIVE_HIGH>;
>   };