Received-SPF: pass (google.com: domain of linux-kernel+bounces-154541-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <ac9cae80-cd9d-4ae0-9f27-b4b424304cbb@web.de>
Date: Tue, 23 Apr 2024 08:15:33 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Daniel Okazaki <dtokazaki@google.com>, kernel-team@android.com,
 linux-i2c@vger.kernel.org, kernel-janitors@vger.kernel.org,
 Arnd Bergmann <arnd@arndb.de>, Bartosz Golaszewski <brgl@bgdev.pl>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>
References: <20240422174337.2487142-1-dtokazaki@google.com>
Subject: Re: [PATCH v3] eeprom: at24: fix memory corruption race condition
Content-Language: en-GB
From: Markus Elfring <Markus.Elfring@web.de>
In-Reply-To: <20240422174337.2487142-1-dtokazaki@google.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:4UEACg2W1e0=;Xo4SzAXl0+sOQrC9KIxB9Mp5BBt
 /M8O5awMH88Oa8RtLXfshSJ6REZ79IZxchV4eATXnuq420jXN5S1zxOOAv3fZJOzkfP7zGN8l
 ENLvrRDOUmfh3x6soqg6sdaJuWj+24BYK80hOAmlHloP5cuy+9rAcZQvIgdKcWwj5MxhEhqRX
 soXe82Kj0zi1Dwlqsfj0PyDeo5z2JaJJ/iNGI1IfQwZ8/ZEZeh9rg8MbLyB3JqG5d75SfsLnO
 dh2ikNGQkDYN0U+oXCp+VwDY58JsezaZVQ2NZwCLfdnUTlfggpZnzg6axK0VKJ4wTXfe6HNcc
 JvgsbrzQJVK2x5EGeVeDqqML2HYh/s99DV+ff2iw8kmlQ879LJhHuDY2IEdNqkfixbxCZSZTc
 x+0lnwrZMEoHUe8ONPqIGuSnRaaRYuCePx0mXshY4sWa8qRckhfogkU4SI3WVqbPeQCtVCleA
 S0dRmDn3bNXzTajU8Y6bMvNJt58kTBdoKManKg/xH/DcGHVyVoShR9C+fKbTRe8qU1Tr9B8Y4
 SqOuezeF0IEUH6gCcvr+FaBBQfPOsWb5CpCHQBOre36+qNjAb93vI4+U+ubwvK936cLoy9UTn
 BCAAvvH2uNKCYhJzBJaE1dQceEUj6qiV1LMQLHIsE5ayrVyuM3nopGw1W2/Fv1xUdyIk5i8Ae
 7PULxdGhPpHu/TdpIJJhRaxemeNm5tKk3YCkTkuc+NJvBnK6wp2k20gr2pPaDQdMrg6wJcPVm
 mKCaYc3RwKDVBg6QpqFnyCNYRoKli1g7cwqdZssuc/sgxLq3LpgGQoe91mhVQDlsotimQwVuu
 BmyZwKIMXSYpp+uFDEEK2Lvv24ylFxlUL7Dyy/LSIvE3E=

How do you think about to increase the version number for your attempt in =
the patch subject?

See also previous contribution:
https://lore.kernel.org/lkml/20240419191200.219548-1-dtokazaki@google.com/
https://lkml.org/lkml/2024/4/19/946


> If the eeprom is not accessible, an nvmem device will be registered, the
> read will fail, and the device will be torn down.
=E2=80=A6

Please present the introduction for failure conditions as an enumeration.


> Move the failure point before registering the nvmem device.
=E2=80=A6

I would interpret the diff data more in the way that a devm_nvmem_register=
() call
should be performed a bit later in the implementation of the function =E2=
=80=9Cat24_probe=E2=80=9D.
How do you think about to mention the affected function also in the summar=
y phrase?


> Changed sha length to 12 in description

A specification was adjusted for a tag.
Please add a version identifier here.
Will version descriptions be extended another bit?


> ---

I suggest to use blank line instead of a duplicate marker line.

Regards,
Markus