Received-SPF: pass (google.com: domain of linux-kernel+bounces-154550-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: Conor Dooley <conor@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>, Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>, Conor Dooley <conor+dt@kernel.org>, Lucas Stach <l.stach@pengutronix.de>, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev
Subject: Re: [PATCH v3 1/1] dt-bindings: interrupt-controller: fsl, irqsteer: Add imx8qxp support
Date: Tue, 23 Apr 2024 08:26:55 +0200
Message-ID: <6041240.lOV4Wx5bFT@steina-w>
Organization: TQ-Systems GmbH
In-Reply-To: <20240422-channel-emission-d485dee6ae48@spud>
References: <20240422064949.70778-1-alexander.stein@ew.tq-group.com> <20240422-channel-emission-d485dee6ae48@spud>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"

Hi Conor,

cc'ed imx@lists.linux.dev

Am Montag, 22. April 2024, 17:48:20 CEST schrieb Conor Dooley:
> On Mon, Apr 22, 2024 at 08:49:49AM +0200, Alexander Stein wrote:
> > Some SoC like i.MX8QXP use a power-domain for this IP. Add a SoC-specif=
ic
> > compatible, which also requires a power-domain.
> >=20
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> > Thanks for the feedback.
> >=20
> > Changes in v3:
> > * Move 'allOf' before 'additionalProperties'
> > * Remove superfluous 'minItems: 1'
> >=20
> >  .../interrupt-controller/fsl,irqsteer.yaml      | 17 ++++++++++++++++-
> >  1 file changed, 16 insertions(+), 1 deletion(-)
> >=20
> > diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl=
,irqsteer.yaml b/Documentation/devicetree/bindings/interrupt-controller/fsl=
,irqsteer.yaml
> > index 20ad4ad82ad64..3d33b75d6ecfa 100644
> > --- a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqste=
er.yaml
> > +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqste=
er.yaml
> > @@ -14,7 +14,9 @@ properties:
> >      oneOf:
> >        - const: fsl,imx-irqsteer
> >        - items:
> > -          - const: fsl,imx8m-irqsteer
> > +          - enum:
> > +              - fsl,imx8m-irqsteer
> > +              - fsl,imx8qxp-irqsteer
> >            - const: fsl,imx-irqsteer
> > =20
> >    reg:
> > @@ -42,6 +44,9 @@ properties:
> >    clock-names:
> >      const: ipg
> > =20
> > +  power-domains:
> > +    maxItems: 1
> > +
> >    interrupt-controller: true
> > =20
> >    "#interrupt-cells":
> > @@ -70,6 +75,16 @@ required:
> >    - fsl,channel
> >    - fsl,num-irqs
> > =20
> > +allOf:
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            const: fsl,imx8qxp-irqsteer
> > +    then:
> > +      required:
> > +        - power-domains
>=20
> Provided the power domains are optional on the existing platforms,
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> otherwise,
> else:
>   properties:
>     power-domains: false

A power-domain is used on imx8mp, but imx8mq does not.

Best regards,
Alexander
=2D-=20
TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht M=FCnchen, HRB 105018
Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider
http://www.tq-group.com/