Received-SPF: pass (google.com: domain of linux-kernel+bounces-154579-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240422213006.505576-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20240422213006.505576-4-prabhakar.mahadev-lad.rj@bp.renesas.com>
In-Reply-To: <20240422213006.505576-4-prabhakar.mahadev-lad.rj@bp.renesas.com>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Tue, 23 Apr 2024 08:53:26 +0200
Message-ID: <CAMuHMdUmSp1JTADtnsTqExssP1h1pQSLDeMd5NkC=uSXC+javA@mail.gmail.com>
Subject: Re: [PATCH 3/6] mmc: renesas_sdhi: Add compatible string for RZ/G2L
 family, RZ/G3S, and RZ/V2M SoCs
To: Prabhakar <prabhakar.csengg@gmail.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>, Rob Herring <robh@kernel.org>, 
	Krzysztof Kozlowski <krzk+dt@kernel.org>, Conor Dooley <conor+dt@kernel.org>, 
	Magnus Damm <magnus.damm@gmail.com>, Wolfram Sang <wsa+renesas@sang-engineering.com>, 
	linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, 
	linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, 
	Biju Das <biju.das.jz@bp.renesas.com>, 
	Fabrizio Castro <fabrizio.castro.jz@renesas.com>, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Prabhakar,

On Mon, Apr 22, 2024 at 11:30=E2=80=AFPM Prabhakar <prabhakar.csengg@gmail.=
com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> - RZ/G2UL and RZ/Five ("r9a07g043")
> - RZ/G2L(C) ("r9a07g044")
> - RZ/V2L ("r9a07g054")
> - RZ/G3S ("r9a08g045")
> - RZ/V2M ("r9a09g011")
>
> The above SoCs have HS400 disabled and use fixed address mode. Add a
> generic compatible 'renesas,rzg2l-sdhi' fallback string for these SoCs,
> where fixed_addr_mode and hs400_disabled quirks are applied.

Thanks for your patch!
>
> Note, 'renesas,sdhi-r9a09g011' is dropped as we will be using
> 'renesas,rzg2l-sdhi' as a fallback string for RZ/V2M SoC.

Doesn't that break backwards compatibility with existing DTBs?

> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
>  drivers/mmc/host/renesas_sdhi_internal_dmac.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/renesas_sdhi_internal_dmac.c b/drivers/mmc/=
host/renesas_sdhi_internal_dmac.c
> index 53d34c3eddce..1828c37e0198 100644
> --- a/drivers/mmc/host/renesas_sdhi_internal_dmac.c
> +++ b/drivers/mmc/host/renesas_sdhi_internal_dmac.c
> @@ -210,7 +210,7 @@ static const struct renesas_sdhi_quirks sdhi_quirks_r=
8a77990 =3D {
>         .manual_tap_correction =3D true,
>  };
>
> -static const struct renesas_sdhi_quirks sdhi_quirks_r9a09g011 =3D {
> +static const struct renesas_sdhi_quirks sdhi_quirks_rzg2l =3D {
>         .fixed_addr_mode =3D true,
>         .hs400_disabled =3D true,
>  };
> @@ -255,9 +255,9 @@ static const struct renesas_sdhi_of_data_with_quirks =
of_r8a77990_compatible =3D {
>         .quirks =3D &sdhi_quirks_r8a77990,
>  };
>
> -static const struct renesas_sdhi_of_data_with_quirks of_r9a09g011_compat=
ible =3D {
> +static const struct renesas_sdhi_of_data_with_quirks of_rzg2l_compatible=
 =3D {
>         .of_data =3D &of_data_rcar_gen3,
> -       .quirks =3D &sdhi_quirks_r9a09g011,
> +       .quirks =3D &sdhi_quirks_rzg2l,
>  };
>
>  static const struct renesas_sdhi_of_data_with_quirks of_rcar_gen3_compat=
ible =3D {
> @@ -283,7 +283,7 @@ static const struct of_device_id renesas_sdhi_interna=
l_dmac_of_match[] =3D {
>         { .compatible =3D "renesas,sdhi-r8a77970", .data =3D &of_r8a77970=
_compatible, },
>         { .compatible =3D "renesas,sdhi-r8a77990", .data =3D &of_r8a77990=
_compatible, },
>         { .compatible =3D "renesas,sdhi-r8a77995", .data =3D &of_rcar_gen=
3_nohs400_compatible, },
> -       { .compatible =3D "renesas,sdhi-r9a09g011", .data =3D &of_r9a09g0=
11_compatible, },

Hence I think the above line should be kept, but changed to point
to &of_rzg2l_compatible.

> +       { .compatible =3D "renesas,rzg2l-sdhi", .data =3D &of_rzg2l_compa=
tible, },
>         { .compatible =3D "renesas,rcar-gen3-sdhi", .data =3D &of_rcar_ge=
n3_compatible, },
>         { .compatible =3D "renesas,rcar-gen4-sdhi", .data =3D &of_rcar_ge=
n3_compatible, },
>         {},

Gr{oetje,eeting}s,

                        Geert

--=20
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k=
org

In personal conversations with technical people, I call myself a hacker. Bu=
t
when I'm talking to journalists I just say "programmer" or something like t=
hat.
                                -- Linus Torvalds