Received-SPF: pass (google.com: domain of linux-kernel+bounces-154585-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <c59348dc-2f14-4d09-9ab9-36d1c25408f4@arinc9.com>
Date: Tue, 23 Apr 2024 10:03:38 +0300
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 0/4] Document ASUS RT-AC3200 and ASUS RT-AC5300 and add
 device trees
To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>,
 Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>,
 Conor Dooley <conor+dt@kernel.org>, Florian Fainelli <f.fainelli@gmail.com>,
 Hauke Mehrtens <hauke@hauke-m.de>,
 Florian Fainelli <florian.fainelli@broadcom.com>,
 Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>
Cc: Tom Brautaset <tbrautaset@gmail.com>, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 Krzysztof Kozlowski <krzk@kernel.org>
References: <20240419-for-soc-asus-rt-ac3200-ac5300-v2-0-f95ff50c2a4d@arinc9.com>
 <0395c3a1-1211-4962-bafd-fbf20be98ce4@gmail.com>
Content-Language: en-US
From: =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= <arinc.unal@arinc9.com>
In-Reply-To: <0395c3a1-1211-4962-bafd-fbf20be98ce4@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 23/04/2024 09:24, Rafał Miłecki wrote:
> Hi,
> 
> On 19.04.2024 09:22, Arınç ÜNAL via B4 Relay wrote:
>> This patch series documents the compatible strings for ASUS RT-AC3200 and
>> ASUS RT-AC5300, and adds the device trees for them.
> 
> I was on holidays and couldn't reply earlier.
> 
> This patchset looks good to me, thanks for your work!
> 
> Bot warnings come from .dtsi so they are not directly caused by your changes.
> 
> Nitpicking:
> Try to put "reg" before "device_type" in future.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/dts-coding-style.rst?h=v6.8#n112

I'll address this in v3, thank you.

Arınç