Received-SPF: pass (google.com: domain of linux-kernel+bounces-154590-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 23 Apr 2024 09:11:07 +0200 (CEST)
From: Julia Lawall <julia.lawall@inria.fr>
To: Shivani Gupta <shivani07g@gmail.com>
cc: "Rafael J . Wysocki" <rafael@kernel.org>, 
    Viresh Kumar <viresh.kumar@linaro.org>, linux-pm@vger.kernel.org, 
    linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, 
    javier.carrasco.cruz@gmail.com
Subject: Re: [PATCH] cpufreq: ti: Implement scope-based cleanup in
 ti_cpufreq_match_node()
In-Reply-To: <20240423020727.776360-1-shivani07g@gmail.com>
Message-ID: <aa2bd3b6-7bb9-98ae-b762-6060f828170@inria.fr>
References: <20240423020727.776360-1-shivani07g@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII


On Tue, 23 Apr 2024, Shivani Gupta wrote:

> This patch modifies the ti_cpufreq_match_node() function to utilize the
> __free() cleanup handler for automatically releasing the device
> node when it goes out of scope.
>
> By moving the declaration to the initialization, the patch ensures that
> the device node is properly managed throughout the function's scope,
> thus eliminating the need for manual invocation of of_node_put().
> This approach reduces the potential for memory leaks.

The code is fine.  The log message is a bit verbose.  Try to avoid
referring to the patch.  It's obvious that you are talking about the
patch.  Try to favor the imperative, so "Modify..." instead of "This patch
modifies".

julia


>
> Suggested-by: Julia Lawall <julia.lawall@inria.fr>
> Signed-off-by: Shivani Gupta <shivani07g@gmail.com>
> ---
>  drivers/cpufreq/ti-cpufreq.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/cpufreq/ti-cpufreq.c b/drivers/cpufreq/ti-cpufreq.c
> index 46c41e2ca727..714ed53753fa 100644
> --- a/drivers/cpufreq/ti-cpufreq.c
> +++ b/drivers/cpufreq/ti-cpufreq.c
> @@ -347,12 +347,10 @@ static const struct of_device_id ti_cpufreq_of_match[] = {
>
>  static const struct of_device_id *ti_cpufreq_match_node(void)
>  {
> -	struct device_node *np;
> +	struct device_node *np __free(device_node) = of_find_node_by_path("/");
>  	const struct of_device_id *match;
>
> -	np = of_find_node_by_path("/");
>  	match = of_match_node(ti_cpufreq_of_match, np);
> -	of_node_put(np);
>
>  	return match;
>  }
> --
> 2.34.1
>
>