Received-SPF: pass (google.com: domain of linux-kernel+bounces-154591-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240422213006.505576-1-prabhakar.mahadev-lad.rj@bp.renesas.com>
 <20240422213006.505576-4-prabhakar.mahadev-lad.rj@bp.renesas.com> <CAMuHMdUmSp1JTADtnsTqExssP1h1pQSLDeMd5NkC=uSXC+javA@mail.gmail.com>
In-Reply-To: <CAMuHMdUmSp1JTADtnsTqExssP1h1pQSLDeMd5NkC=uSXC+javA@mail.gmail.com>
From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Date: Tue, 23 Apr 2024 08:11:19 +0100
Message-ID: <CA+V-a8vq=ehhgQ0QY__ZQb4NOMDZt07P93T+XjreHcGtBWa+Ww@mail.gmail.com>
Subject: Re: [PATCH 3/6] mmc: renesas_sdhi: Add compatible string for RZ/G2L
 family, RZ/G3S, and RZ/V2M SoCs
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>, Rob Herring <robh@kernel.org>, 
	Krzysztof Kozlowski <krzk+dt@kernel.org>, Conor Dooley <conor+dt@kernel.org>, 
	Magnus Damm <magnus.damm@gmail.com>, Wolfram Sang <wsa+renesas@sang-engineering.com>, 
	linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, 
	linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, 
	Biju Das <biju.das.jz@bp.renesas.com>, 
	Fabrizio Castro <fabrizio.castro.jz@renesas.com>, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Geert,

Thank you for the review.

On Tue, Apr 23, 2024 at 7:53=E2=80=AFAM Geert Uytterhoeven <geert@linux-m68=
k.org> wrote:
>
> Hi Prabhakar,
>
> On Mon, Apr 22, 2024 at 11:30=E2=80=AFPM Prabhakar <prabhakar.csengg@gmai=
l.com> wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >
> > - RZ/G2UL and RZ/Five ("r9a07g043")
> > - RZ/G2L(C) ("r9a07g044")
> > - RZ/V2L ("r9a07g054")
> > - RZ/G3S ("r9a08g045")
> > - RZ/V2M ("r9a09g011")
> >
> > The above SoCs have HS400 disabled and use fixed address mode. Add a
> > generic compatible 'renesas,rzg2l-sdhi' fallback string for these SoCs,
> > where fixed_addr_mode and hs400_disabled quirks are applied.
>
> Thanks for your patch!
> >
> > Note, 'renesas,sdhi-r9a09g011' is dropped as we will be using
> > 'renesas,rzg2l-sdhi' as a fallback string for RZ/V2M SoC.
>
> Doesn't that break backwards compatibility with existing DTBs?
>
I was in two minds here, as similarly to the RZ/G2L family the RZ/V2M
has Gen3 compat string as a fallback in the DTSI. So for existing DTBs
this would still work (but with no quirks applied). But as you say
I'll keep this to make sure we dont break anything,

> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > ---
> >  drivers/mmc/host/renesas_sdhi_internal_dmac.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/mmc/host/renesas_sdhi_internal_dmac.c b/drivers/mm=
c/host/renesas_sdhi_internal_dmac.c
> > index 53d34c3eddce..1828c37e0198 100644
> > --- a/drivers/mmc/host/renesas_sdhi_internal_dmac.c
> > +++ b/drivers/mmc/host/renesas_sdhi_internal_dmac.c
> > @@ -210,7 +210,7 @@ static const struct renesas_sdhi_quirks sdhi_quirks=
_r8a77990 =3D {
> >         .manual_tap_correction =3D true,
> >  };
> >
> > -static const struct renesas_sdhi_quirks sdhi_quirks_r9a09g011 =3D {
> > +static const struct renesas_sdhi_quirks sdhi_quirks_rzg2l =3D {
> >         .fixed_addr_mode =3D true,
> >         .hs400_disabled =3D true,
> >  };
> > @@ -255,9 +255,9 @@ static const struct renesas_sdhi_of_data_with_quirk=
s of_r8a77990_compatible =3D {
> >         .quirks =3D &sdhi_quirks_r8a77990,
> >  };
> >
> > -static const struct renesas_sdhi_of_data_with_quirks of_r9a09g011_comp=
atible =3D {
> > +static const struct renesas_sdhi_of_data_with_quirks of_rzg2l_compatib=
le =3D {
> >         .of_data =3D &of_data_rcar_gen3,
> > -       .quirks =3D &sdhi_quirks_r9a09g011,
> > +       .quirks =3D &sdhi_quirks_rzg2l,
> >  };
> >
> >  static const struct renesas_sdhi_of_data_with_quirks of_rcar_gen3_comp=
atible =3D {
> > @@ -283,7 +283,7 @@ static const struct of_device_id renesas_sdhi_inter=
nal_dmac_of_match[] =3D {
> >         { .compatible =3D "renesas,sdhi-r8a77970", .data =3D &of_r8a779=
70_compatible, },
> >         { .compatible =3D "renesas,sdhi-r8a77990", .data =3D &of_r8a779=
90_compatible, },
> >         { .compatible =3D "renesas,sdhi-r8a77995", .data =3D &of_rcar_g=
en3_nohs400_compatible, },
> > -       { .compatible =3D "renesas,sdhi-r9a09g011", .data =3D &of_r9a09=
g011_compatible, },
>
> Hence I think the above line should be kept, but changed to point
> to &of_rzg2l_compatible.
>
OK, will do.

Cheers,
Prabhakar