Received-SPF: pass (google.com: domain of linux-kernel+bounces-154598-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Tue, 23 Apr 2024 12:52:20 +0530
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: Shivani Gupta <shivani07g@gmail.com>,
	"Rafael J . Wysocki" <rafael@kernel.org>, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org, skhan@linuxfoundation.org,
	javier.carrasco.cruz@gmail.com
Subject: Re: [PATCH] cpufreq: ti: Implement scope-based cleanup in
 ti_cpufreq_match_node()
Message-ID: <20240423072220.sx3lrvjtlirmz675@vireshk-i7>
References: <20240423020727.776360-1-shivani07g@gmail.com>
 <aa2bd3b6-7bb9-98ae-b762-6060f828170@inria.fr>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <aa2bd3b6-7bb9-98ae-b762-6060f828170@inria.fr>

On 23-04-24, 09:11, Julia Lawall wrote:
> 
> 
> On Tue, 23 Apr 2024, Shivani Gupta wrote:
> 
> > This patch modifies the ti_cpufreq_match_node() function to utilize the
> > __free() cleanup handler for automatically releasing the device
> > node when it goes out of scope.
> >
> > By moving the declaration to the initialization, the patch ensures that
> > the device node is properly managed throughout the function's scope,
> > thus eliminating the need for manual invocation of of_node_put().
> > This approach reduces the potential for memory leaks.
> 
> The code is fine.  The log message is a bit verbose.  Try to avoid
> referring to the patch.  It's obvious that you are talking about the
> patch.  Try to favor the imperative, so "Modify..." instead of "This patch
> modifies".

Fixed while applying.

-- 
viresh