Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp2775735lqt; Tue, 23 Apr 2024 00:43:43 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUuEnynlH02MvSuAO+8qhd7XB5iVN/6bflY2vO6VwziEgIa+DxyFp4dbxmQNLtuNbeiLuwlw12yZmtJ5iw/UPccHcnxr8eBjzwsrBRHiw== X-Google-Smtp-Source: AGHT+IG7UzbHOL+ZzP9WR7CB4OFaS3OyzWPqnJDDVy39oji6p7LGuoYVbTiNO9CRosdMGOa+lBAM X-Received: by 2002:a05:6a00:80e:b0:6eb:3c34:34bd with SMTP id m14-20020a056a00080e00b006eb3c3434bdmr15390439pfk.3.1713858223602; Tue, 23 Apr 2024 00:43:43 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713858223; cv=pass; d=google.com; s=arc-20160816; b=HWhvTrl8t6rLwOa4q35JSMsX34bIUHTSLmYWDBGYHc/qoRU2minLfi3zc7LqB/3edI /iEezJ3af8eiDQRuaIaGWz7RmeW1b74Ku5D7t6qNRG+MCxSzSE7ncuo7kVLKdWTi8hIa amprBiPGgxuxcPUKooktqUMozod5ty2ut3lOZN8dx0WWKQGAoQ+bDLerkNGMdWZDrvut E0b7awHKQvVlvkxeOIgMxNt6PYaQOeGCcL/nycH+FefKPq/mgVRQuvxmGZxfYUDgoBRt TnFkHz2gF9BlsISC9y09gWtE5474xhrRw8t85uu7/jmHa8Glq2zYf/+/NLnqzrCvUP10 XSAA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=zaPNe9jX9/alEi7eT6J6kZYmn+NM0ylY23dHWqIuCCg=; fh=jPN6NUvZQzqFugf2NYO/sZeB4EWuv73hhbwxuoBAEeM=; b=Ae34XsTrGtm4UI1HETh4aoJPrzH/uBuCLg7SpJP3laSXDh70ne9G80xVcWgDoiLnAl qbfI+WxevAH9d2MC6lHVWVRjH1uSTxNK9NWknfkVMLIBoxWmGCIOWY+pgAZdMWyHdjyO nCSrYvpLUzRVYWUszycaV/WRh7nw+RPTiHqHQs/u8IAxjzW9KZcaOGawjgrk4+kMdIFL Lnu6l/+hHERGrYGgcOxhBjtKSELrsvX5qkx8LwT6QGwom5Xt+zzi7j0S6yeMDZicxVeZ bbowqEKuy49jrRhlEi5dCKI73LgEeWiChhyCivCpsxNyl1mDIk5zmpABJZ3g+oXETvEj q/Xw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-154615-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-154615-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id b17-20020a630c11000000b005fdd11c0871si4077594pgl.284.2024.04.23.00.43.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Apr 2024 00:43:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-154615-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-154615-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-154615-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 00FFB28441D for ; Tue, 23 Apr 2024 07:43:42 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 47938482FA; Tue, 23 Apr 2024 07:43:39 +0000 (UTC) Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0A1347A5D; Tue, 23 Apr 2024 07:43:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713858218; cv=none; b=crupKciJ2tLehGcOcKUEhPkdbWVjvOTmwaikcPFUcH6GBYoj4NvPzQ5CE6/yqcfKcroj4j3USjXUUk5BOQZIemsoLZd0GW4W6A8wtD8SN8mn9giUcJnIFdmQk1h9KOH0DVLfoEdbwPiG9vu3Np6S73JvLrEc6rdvHXQJYT5VKAI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713858218; c=relaxed/simple; bh=zpqXzeN1h9+yujdqercMpcnT15Uwq0O3FUcKIyg2OOs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=f0cwPgC/aZhjYjDSe+x2IeWRuwgnIDPcIY/XcBtDSF7HQJrmbe5jmOJ/bJaPYhW/gV+dwjkIsLYxaBolHXz3RmZBH8CZX3gdWluOfC25CdifWzSJjdZ1Y6xCMxTURT969jlCeWsZNEfEX7YMjhXKHXGA566QYpeRbcxlki+WwbY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 896E0C116B1; Tue, 23 Apr 2024 07:43:35 +0000 (UTC) From: Huacai Chen To: Arnd Bergmann , Huacai Chen Cc: loongarch@lists.linux.dev, linux-arch@vger.kernel.org, Xuefeng Li , Guo Ren , Xuerui Wang , Jiaxun Yang , linux-kernel@vger.kernel.org, loongson-kernel@lists.loongnix.cn, Huacai Chen , Youling Tang Subject: [PATCH] LoongArch: Fix callchain parse error with kernel tracepoint events Date: Tue, 23 Apr 2024 15:43:22 +0800 Message-ID: <20240423074322.2480319-1-chenhuacai@loongson.cn> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In order to fix perf's callchain parse error for LoongArch, we implement perf_arch_fetch_caller_regs() which fills several necessary registers used for callchain unwinding, including sp, fp, and era. This is similar to the following commits. commit b3eac0265bf6: ("arm: perf: Fix callchain parse error with kernel tracepoint events") commit 5b09a094f2fb: ("arm64: perf: Fix callchain parse error with kernel tracepoint events") commit 9a7e8ec0d4cc: ("riscv: perf: Fix callchain parse error with kernel tracepoint events") Test with commands: perf record -e sched:sched_switch -g --call-graph dwarf perf report Without this patch: Children Self Command Shared Object Symbol ........ ........ ............. ................. .................... 43.41% 43.41% swapper [unknown] [k] 0000000000000000 10.94% 10.94% loong-container [unknown] [k] 0000000000000000 | |--5.98%--0x12006ba38 | |--2.56%--0x12006bb84 | --2.40%--0x12006b6b8 With this patch, callchain can be parsed correctly: Children Self Command Shared Object Symbol ........ ........ ............. ................. .................... 47.57% 47.57% swapper [kernel.vmlinux] [k] __schedule | ---__schedule 26.76% 26.76% loong-container [kernel.vmlinux] [k] __schedule | |--13.78%--0x12006ba38 | | | |--9.19%--__schedule | | | --4.59%--handle_syscall | do_syscall | sys_futex | do_futex | futex_wait | futex_wait_queue_me | hrtimer_start_range_ns | __schedule | |--8.38%--0x12006bb84 | handle_syscall | do_syscall | sys_epoll_pwait | do_epoll_wait | schedule_hrtimeout_range_clock | hrtimer_start_range_ns | __schedule | --4.59%--0x12006b6b8 handle_syscall do_syscall sys_nanosleep hrtimer_nanosleep do_nanosleep hrtimer_start_range_ns __schedule Reported-by: Youling Tang Suggested-by: Youling Tang Signed-off-by: Huacai Chen --- arch/loongarch/include/asm/perf_event.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/loongarch/include/asm/perf_event.h b/arch/loongarch/include/asm/perf_event.h index 2a35a0bc2aaa..157c4ace69d0 100644 --- a/arch/loongarch/include/asm/perf_event.h +++ b/arch/loongarch/include/asm/perf_event.h @@ -9,4 +9,10 @@ #define perf_arch_bpf_user_pt_regs(regs) (struct user_pt_regs *)regs +#define perf_arch_fetch_caller_regs(regs, __ip) { \ + (regs)->csr_era = (__ip); \ + (regs)->regs[3] = current_stack_pointer; \ + (regs)->regs[22] = (unsigned long) __builtin_frame_address(0); \ +} + #endif /* __LOONGARCH_PERF_EVENT_H__ */ -- 2.43.0