Received-SPF: pass (google.com: domain of linux-kernel+bounces-154618-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Tue, 23 Apr 2024 09:45:10 +0200
From: Robert Richter <rrichter@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@intel.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	linux-kernel@vger.kernel.org, jgross@suse.com, tglx@linutronix.de,
	x86@kernel.org, Kim Phillips <kim.phillips@amd.com>,
	Robert Richter <rric@kernel.org>
Subject: Re: [PATCH 2/4] perf/x86/ibs: Use CPUID region helper
Message-ID: <ZidnBlWbCaMg-UDi@rric.localdomain>
References: <20240403153511.75CB9DA0@davehans-spike.ostc.intel.com>
 <20240416151242.GGZh6VaiO2gC4ej2BT@fat_crate.local>
 <f142e9c4-4829-4ace-8757-485246ad3572@intel.com>
 <20240416174850.GEZh66AmnDjrLxoXaw@fat_crate.local>
 <ZiEMnWaHkn99_oyW@rric.localdomain>
 <20240422172055.GAZiacdxkQU0XAbybW@fat_crate.local>
 <ZibEFZ6DoxDeBxxp@rric.localdomain>
 <20240422204146.GCZibLiqZhbY1J4qFJ@fat_crate.local>
 <ZibW8D9-CTd8G-_v@rric.localdomain>
 <20240422214503.GDZibaX4G2HWQgZuvH@fat_crate.local>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240422214503.GDZibaX4G2HWQgZuvH@fat_crate.local>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?IoOOZyfB6vsJ04tPR5xlTcXHk0eRL7MJ47wpt1XaCbkCpzJeND3nP52Wlsiq?=
 =?us-ascii?Q?cWe0MwinWynWG22QcHaRE8J2ypqZF6RD0Mz45fDkIcvnZxObRWMe1z56TrSH?=
 =?us-ascii?Q?g6JzkmycIgOp58TjYkgy35+NX7Z1b5O4ew9jiE2zW5WGdZJoe95s2Yd/118j?=
 =?us-ascii?Q?8Sp/fpDXM8B8bcYSi7P/kRLk/p7RE50A2noqe1EBtLrG++ytpZil0tWrtJE6?=
 =?us-ascii?Q?9zMRWlHhsZ42DTHEiHhATQj/Ob8drddxXpqmprJnTsvfEYwvBhjoVFK8H54L?=
 =?us-ascii?Q?/MhSZwv82Z6yrzcC/nIeEbFQuEtMUabU/HE4YMlgPaqH7H0D/kZ8AvFKVhDt?=
 =?us-ascii?Q?HpDEBKrliONG+KouA+5Rek+7LyILmr7cMRprwlM0e7Hx+R30xTXC5zv+RrIH?=
 =?us-ascii?Q?3ZuSlJEojq1hlvFKA3Ztk1UZmwkmzQu7DVc0vM1HvTVbnINZq1AbXOAOX3S1?=
 =?us-ascii?Q?gLHar2SddEZltHRIeSDdfz9GBB+osqV0cxAUlJrYDIWAd2qyTsUinjDWoQP4?=
 =?us-ascii?Q?LiC7DbzVA0cMFFJGA/EVTmJVrj/3KMFUPGjW7S2RJjbdI0w4jg95HPtfZrgq?=
 =?us-ascii?Q?aOb5f+IY5WkqEAja7gZza6+oitb1OMbQiAZmUMJ8NXn/ix6Q7WbNAex09nP9?=
 =?us-ascii?Q?iac7D4LCAY1fquadEWpIkq0IiMGO6cM6fgxVXRfN+qoqqnl33lb2HZjLnYM6?=
 =?us-ascii?Q?Dvrag+vbI61Z6lLjl8ZWlIU9mhh2DlSGhOYlfgqbFbm8V6Bqlr0aCxrorcgN?=
 =?us-ascii?Q?421WymdzbCZe8du+Wm1yFySrg5a1Kqb42jIiP3mOmIf90P7JDFksNNhk6DgK?=
 =?us-ascii?Q?sn0VyzBcTkArB6KVQj3it0KqJ5UNMS6FIMMa4vkgP9CoNn7VIPRtw9oRcg+o?=
 =?us-ascii?Q?jNl40tRKcc2gkLFrIoM5/O50JI1rAXq/8mnjpc2jNtj6yiQkNqOfxvxhFCXK?=
 =?us-ascii?Q?5wpPvT86byHAnC6KSA2A9LUlKbQS+rKFtg8MyAfvjmn1V1mFSJo8iREOfP4l?=
 =?us-ascii?Q?zjLdMQAy/HdM43YLgtlsluWcgx3O9lVzAUIuS5tZW+xC/jgZMSdySUfsrPKV?=
 =?us-ascii?Q?5ODO3hNJQAVH5OKUetokzwLnOXBTXQMPPhJRJ713vjTt0rlpBDT7uKnAQ2Mn?=
 =?us-ascii?Q?wU7HyqqdrDaVkbyJS7ckJ+2NGTX/BLtXXGFSC9W5iDb7nfv2VqnYzPu1wGVE?=
 =?us-ascii?Q?mlEspOvZDxABU8lsaSANwAr1WpjsFPmKdgT96eeiAcM4YB3xzIFzotWyODu2?=
 =?us-ascii?Q?VaQR98bLxIOwfo6Dl/i1sxcEoVW8kEpYG75iPCsiO4M/59J39DZOKEeL1a74?=
 =?us-ascii?Q?EMunYvPgai7ZoiZA/NV9ZkXQucu+n9zZ716dBBKClRTerECtQc91aT8umDKw?=
 =?us-ascii?Q?2pRT+jtRmzFjNyvKXxW6w9nWI5eqEaAXsZ7XsH7MH3dCrZ15SAuePGwuvNdU?=
 =?us-ascii?Q?FZOzlwhgVqPAy+X1tBVWaDDHX5xaeKyfCrXa3hWyqhX6A3Krhj9Xb3XJCLFL?=
 =?us-ascii?Q?j78VtppqIfRyq5GGE/cEZl1zh/aQepjqIU7v3hztBHTxOCQTypSNjRA0i4h4?=
 =?us-ascii?Q?GIeogZjxohcyDklC+zHF57QgghuW/P5AO7js7gia?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3b4e9762-e0d5-422f-8d20-08dc636950fc
X-MS-Exchange-CrossTenant-AuthSource: CYYPR12MB8750.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2024 07:45:16.2355
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2brqRCG5o/K/S9ihkUsYWCq7kQBixN/1kLFcArNkBGc0KN4FkXQ4QNHwJ+Tu4qdmuUM+mRtI4VSofMzdeaUWIQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4418

On 22.04.24 23:45:03, Borislav Petkov wrote:
> On Mon, Apr 22, 2024 at 11:30:24PM +0200, Robert Richter wrote:
> > I mean the case where the cpuid leaf exists but IBS_CAPS_AVAIL is
> > clear. That could be possible with some cpuid override e.g. in virt
> > envs.
> 
> Until there is a valid use case, I don't care.
> 
> > Not on real hardware and if future systems not decide to enable IBS
> > feature bit and clear IBS_CAPS_AVAIL, which could be a valid case IMO.
> 
> Then they get what they ordered and get to keep the pieces.
> 
> We don't support every insane configuration virt comes up with.

I think we can assume/agree that max cpuid leaf will not decrease.
That is, future implementations will contain the IBS leaf (offset
1Bh). Second, if IBS feature bit is cleared, IBS is switched
off. Third, use IBS_CAPS_DEFAULT if the IBS leaf is missing.

Now, we just need to decide one of those for the case where the IBS
cpuid leaf exists and IBS_CAPS_AVAIL is cleared:

1) Apply 0 to caps and entirely disable IBS (my proposal).

2) Apply IBS_CAPS_DEFAULT (originally intended for GH revB) and
   enable IBS with the limited feature set for GH revB (current
   kernel implementation).

I prefer 1) as this applies IBS_CAPS_DEFAULT only if the leaf is
missing which was the original intention of IBS_CAPS_DEFAULT but can
live with 2) as it is implemented now.

Thanks,

-Robert