Received-SPF: pass (google.com: domain of linux-kernel+bounces-154632-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <a97420fc-1fc3-4e85-9539-e1a74c711be0@gmail.com>
Date: Tue, 23 Apr 2024 13:24:52 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Betterbird (Linux)
Subject: Re: [PATCH v3] dt-bindings: usb: uhci: convert to dt schema
To: Krzysztof Kozlowski <krzk@kernel.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>,
 Conor Dooley <conor+dt@kernel.org>
Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <20240422122125.455781-1-sheharyaar48@gmail.com>
 <7a43b05c-ca2e-4fa6-b1f9-cb1a12778da7@kernel.org>
Content-Language: en-US
From: Mohammad Shehar Yaar Tausif <sheharyaar48@gmail.com>
In-Reply-To: <7a43b05c-ca2e-4fa6-b1f9-cb1a12778da7@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 4/23/24 12:24 PM, Krzysztof Kozlowski wrote:
> On 22/04/2024 14:21, Mohammad Shehar Yaar Tausif wrote:
>> Convert USB UHCI bindings to DT schema. Documenting aspeed compatibles
>> and missing properties. Adding aspeed/generic-uhci example and fix previous
>> incorrect example.
>>
>> Signed-off-by: Mohammad Shehar Yaar Tausif <sheharyaar48@gmail.com>
> 
>> +required:
>> +  - compatible
>> +  - reg
>> +  - interrupts
>> +
>> +allOf:
>> +  - if:
>> +      properties:
>> +        compatible:
>> +          contains:
>> +            const: generic-uhci
>> +    then:
>> +      $ref: usb-hcd.yaml
> 
> Nothing improved here.

Sorry, I could not understand this, please guide me about the correction 
required here.
I added $ref inside the if-then block because it was raising errors when 
tested against
dts files that used "platform-uhci" as the compatible. Putting it above 
the if block did
not work.

When I ref the usb-hcd.yaml, it also includes usb.yaml which requires 
the nodename to start with usb*,
but the dtsi that use the deprecated compatible 
(arch/arm/boot/dts/vt8500/wm8505.dtsi) have their nodename with
uhci*, which causes the tests to fail.

>> +      required:
>> +        - clocks
> 
> And this was not tested.
>> +
>> +unevaluatedProperties: false
>> +
>> +examples:
>> +  - |
>> +    uhci@d8007b00 {
>> +        compatible = "platform-uhci";
> 
> What happened here? This is deprecated!

The original example has the nodename as uhci* which causes the schema 
to fail as mentioned earlier.
Should I just remove the example or should I rename the node here and 
add clock field to the original example ?

Best Regards,
Shehar