Received-SPF: pass (google.com: domain of linux-kernel+bounces-154658-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 23 Apr 2024 09:53:51 +0200
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Frank Li <Frank.Li@nxp.com>
Cc: Rob Herring <robh@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, 
	Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, devicetree@vger.kernel.org, 
	linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev
Subject: Re: [PATCH v3 07/10] arm64: dts: imx8qm-mek: add flexcan support
Message-ID: <20240423-savvy-straight-shellfish-ac1c64-mkl@pengutronix.de>
References: <20240422-dts_8qm_audio-v3-0-680cee731ced@nxp.com>
 <20240422-dts_8qm_audio-v3-7-680cee731ced@nxp.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="tics6yqmbhuzwzxy"
Content-Disposition: inline
In-Reply-To: <20240422-dts_8qm_audio-v3-7-680cee731ced@nxp.com>


--tics6yqmbhuzwzxy
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 22.04.2024 15:50:09, Frank Li wrote:
> Add flexcan[1,2,3] support for imx8qm-mek board.
>=20
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8qm-mek.dts | 80 ++++++++++++++++++++++=
++++++
>  1 file changed, 80 insertions(+)
>=20
> diff --git a/arch/arm64/boot/dts/freescale/imx8qm-mek.dts b/arch/arm64/bo=
ot/dts/freescale/imx8qm-mek.dts
> index 3ab2fab7f7fa3..62ea3efd1ee2c 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qm-mek.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8qm-mek.dts
[...]
> @@ -433,6 +492,27 @@ IMX8QM_QSPI0B_SS1_B_LSIO_QSPI0B_SS1_B     0x06000021
>  		>;
>  	};
> =20
> +	pinctrl_flexcan1: flexcan0grp {
> +		fsl,pins =3D <
> +			IMX8QM_FLEXCAN0_TX_DMA_FLEXCAN0_TX			0x21
> +			IMX8QM_FLEXCAN0_RX_DMA_FLEXCAN0_RX			0x21
> +		>;
> +	};
> +
> +	pinctrl_flexcan2: flexcan1grp {
> +		fsl,pins =3D <
> +			IMX8QM_FLEXCAN1_TX_DMA_FLEXCAN1_TX			0x21
> +			IMX8QM_FLEXCAN1_RX_DMA_FLEXCAN1_RX			0x21
> +			>;

The indention of the closing ">" looks strange.

> +	};
> +
> +	pinctrl_flexcan3: flexcan3grp {
> +		fsl,pins =3D <
> +			IMX8QM_FLEXCAN2_TX_DMA_FLEXCAN2_TX			0x21
> +			IMX8QM_FLEXCAN2_RX_DMA_FLEXCAN2_RX			0x21
> +			>;

Same here.

> +	};
> +
>  	pinctrl_lpuart0: lpuart0grp {
>  		fsl,pins =3D <
>  			IMX8QM_UART0_RX_DMA_UART0_RX				0x06000020
>=20
> --=20
> 2.34.1
>=20
>=20
>

regards,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung N=C3=BCrnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

--tics6yqmbhuzwzxy
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEUEC6huC2BN0pvD5fKDiiPnotvG8FAmYnaQwACgkQKDiiPnot
vG+uXwf/ZHhRwk/bowRcZWxqTLDKiPbKvuLEbsGITuh4y6PkYYF2mPGF/MgcJPGC
Qad5zoD5VfrziHtjbnRNCBNz2r6KZ24waVXE0p8NDfcSYjr3sPYgsgxHPWCpyGxQ
DeCiJ4m8prwHyPioC1bapLI60Td6Df0VlM2l7LxO7MA+psF9bncGYWNdWCSRP1J0
PLi0I2w99Y75+aPy07U+huVlldIHhPjJGmLyq9KW5VuE29PspApRT1wMwx+ZvthO
Lv5R0d3aTxIQBGtRlMQvX9aTIKMtgMs+Qhbgu+xgQw0AC3L6TfMskIGBxoUzPUKl
YqcMaIGLEhWOM5QicIPtaOdUa9oYyg==
=PR7J
-----END PGP SIGNATURE-----

--tics6yqmbhuzwzxy--