Received-SPF: pass (google.com: domain of linux-kernel+bounces-154701-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Lance Yang <ioworker0@gmail.com>
To: baolin.wang@linux.alibaba.com
Cc: 21cnbao@gmail.com,
	akpm@linux-foundation.org,
	david@redhat.com,
	hughd@google.com,
	linux-kernel@vger.kernel.org,
	linux-mm@kvack.org,
	ryan.roberts@arm.com,
	shy828301@gmail.com,
	wangkefeng.wang@huawei.com,
	willy@infradead.org,
	ying.huang@intel.com,
	ziy@nvidia.com
Subject: Re: [RFC PATCH 1/5] mm: memory: extend finish_fault() to support large folio
Date: Tue, 23 Apr 2024 16:39:51 +0800
Message-Id: <20240423083951.1380-1-ioworker0@gmail.com>
In-Reply-To: <358aefb1858b63164894d7d8504f3dae0b495366.1713755580.git.baolin.wang@linux.alibaba.com>
References: <358aefb1858b63164894d7d8504f3dae0b495366.1713755580.git.baolin.wang@linux.alibaba.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Hey Baolin,

[...]
@@ -4727,9 +4725,11 @@ vm_fault_t finish_fault(struct vm_fault *vmf)
[...]

The mm counters have been moved from updating out of set_pte_range(), so we
we may need to rebase against Kefeng's patch[1].

+	int type = is_cow ? MM_ANONPAGES : mm_counter_file(folio);
	set_pte_range(vmf, folio, &folio->page, nr_pages, addr);
+	add_mm_counter(vma->vm_mm, type, nr_pages);
[...]

[1] https://lore.kernel.org/all/20240412064751.119015-1-wangkefeng.wang@huawei.com/T/#me2827c26ff453c0fa86f2af9f68f245978b08774

Thanks,
Lance