Received-SPF: pass (google.com: domain of linux-kernel+bounces-154736-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <78f5ee9a-084f-4a8a-9a22-be031f9baafa@collabora.com>
Date: Tue, 23 Apr 2024 13:55:07 +0500
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Cc: Muhammad Usama Anjum <usama.anjum@collabora.com>, shuah@kernel.org,
 linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org,
 linux-kernel@vger.kernel.org, Anshuman.Khandual@arm.com,
 suzuki.poulose@arm.com, ryan.roberts@arm.com, rob.herring@arm.com,
 Catalin.Marinas@arm.com, broonie@kernel.org, mark.rutland@arm.com,
 linux@armlinux.org.uk
Subject: Re: [PATCH v2 0/4] A new selftests/ directory for arm compatibility
 testing
To: Will Deacon <will@kernel.org>, Dev Jain <dev.jain@arm.com>
References: <20240422070717.2194201-1-dev.jain@arm.com>
 <20240422172108.GD6223@willie-the-truck>
Content-Language: en-US
From: Muhammad Usama Anjum <usama.anjum@collabora.com>
In-Reply-To: <20240422172108.GD6223@willie-the-truck>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 4/22/24 10:21 PM, Will Deacon wrote:
> On Mon, Apr 22, 2024 at 12:37:13PM +0530, Dev Jain wrote:
>> This series introduces the selftests/arm directory, which tests 32 and 64-bit
>> kernel compatibility with 32-bit ELFs running on the Aarch platform.
>> The need for this bucket of tests is that 32 bit applications built on legacy
>> ARM architecture must not break on the new Aarch64 platforms and the 64-bit
>> kernel. The kernel must emulate the data structures, system calls and the
>> registers according to Aarch32, when running a 32-bit process; this directory
>> fills that testing requirement.
>>
>> One may find similarity between this directory and selftests/arm64; it is
>> advisable to refer to that since a lot has been copied from there itself.
> 
> Isn't this going to be difficult to maintain if we have two divergent copies
> of the same stuff? From a very quick skim, a bunch of the signals stuff is
> idential to what we have on arm64...
Agreed.

Why don't we follow what x86 suite has been doing? Compile tests for both
arm and arm64, and add conditionals in the tests based on architecture.

If someone has objection that the suite name is arm64, just rename it to
arm which would be a generic name.


> 
> Will
> 

-- 
BR,
Muhammad Usama Anjum