Received-SPF: pass (google.com: domain of linux-kernel+bounces-154749-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: "Tian, Kevin" <kevin.tian@intel.com>
To: Lu Baolu <baolu.lu@linux.intel.com>, Joerg Roedel <joro@8bytes.org>, "Will
 Deacon" <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>, "Jason
 Gunthorpe" <jgg@ziepe.ca>
CC: "Zhang, Tina" <tina.zhang@intel.com>, "Liu, Yi L" <yi.l.liu@intel.com>,
	"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v3 01/12] iommu/vt-d: Add cache tag assignment interface
Thread-Topic: [PATCH v3 01/12] iommu/vt-d: Add cache tag assignment interface
Thread-Index: AQHaj9VBHEr21xvfHkeP18PDMfcoLLF1mcCQ
Date: Tue, 23 Apr 2024 09:01:17 +0000
Message-ID: <BN9PR11MB5276A1920E24BE91CF1FD2098C112@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20240416080656.60968-1-baolu.lu@linux.intel.com>
 <20240416080656.60968-2-baolu.lu@linux.intel.com>
In-Reply-To: <20240416080656.60968-2-baolu.lu@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?oBg+FDixIvTtxkg8II1nbeHsHWDJIm0uAI3yC1HmEFtuR7y7+K0WO7NpE/a8?=
 =?us-ascii?Q?Zl/xDwJcOqH686u0WJ++y5y9/NhU/7RHIPLG50sZ9M9emo7iV0MbczSzCQzB?=
 =?us-ascii?Q?+hN6O3hjpZ4koRCKf0VUkSm5gdvS60LNLmC1HYZW8gE3nte8M7LBV/LI7qIn?=
 =?us-ascii?Q?0XBJDSo4Akyt01O/Ni90atwRBWOqlxqPejSBuyBTnULWM4dHxlF7DJFnz+5I?=
 =?us-ascii?Q?VgfwdE1f4WmC7oAwG2uWScE3g3hDDz9Idvzzfv/FlgmHLxC4ehB6m9jiZh4E?=
 =?us-ascii?Q?aTeC+l8nnpZLChb27IujNp1GbR/5uD5XpfMDZ6FYs9Xo+8CkR0FqdNGFngQG?=
 =?us-ascii?Q?Xxp14zY7+9Y15vrOnvERfPjePvnvPtpXJLguOi52Y23esuZR+Aza8eVZk/EX?=
 =?us-ascii?Q?PJlV/LMA3hcNRazq8HMDD5UtqeArdiwCsPQSniSpmMbZIArF60z7Bm0tKDWt?=
 =?us-ascii?Q?T3yAaVSoiZ6oO+cOyQn7wIR1LdtLbAk4FMgd9RC2d9fKN1TpIEuJu96dX//f?=
 =?us-ascii?Q?fiHc3BPvd528akP5dBuso3SVxKYTogN6Sa8cipX1WZmx5/P6LDDofG8WKuJf?=
 =?us-ascii?Q?ts9Zig9qar7wN34ktto76Y9bfTqs77MkEVCTZbIxEdwxiFbs/30WKX5q9eM6?=
 =?us-ascii?Q?lpCE+7TvUMF9VfbUlZBSa6H51YQdB6vFTLALzE8IyUKKy9x391pAV1CH+MAH?=
 =?us-ascii?Q?TI+Xc6BdO+KGj9u6gvEGg1si3VvDvy7GSFad12x3sSwK1hPCEOrOz/7d2ORf?=
 =?us-ascii?Q?TpsKOjLRFlEO9bfNTMYI2IvzWbiqDnfD2KLAH/M4ZFmS4Gg4usHfZ3wLQ8pM?=
 =?us-ascii?Q?Ix5gFAvJO5NQfI28KufpZXXiKYGOuTqdTCSFfykaJN5GdQP0MCMMg7Za1+/P?=
 =?us-ascii?Q?W22+gxsTBneiWpzI2SRF13Z059+yr1Yh4Bm8YmEhks8TPioWqaOc4UbiN1eX?=
 =?us-ascii?Q?2+GWr/PovwZ2u3YjSlL+HmGkzW292WWFuADPZ0oDEa3tkt5UYltqF/lpTxnA?=
 =?us-ascii?Q?u3RhVj3b+kW7ibuV/3IMtEXUj+w4X4owTPAOPtZKnWXYCbxsGEizil1unYix?=
 =?us-ascii?Q?vbRXLeljME5nUBT19/xYS8lU3Tm3xd827KOexDC5qEs4w4sNhKQE5XzqoSL+?=
 =?us-ascii?Q?7vKHTWREB7G5r+OZUOu8O5Xqgmci/+kSVPdUHLgXF9ze9jUG41AV0fTy7rVa?=
 =?us-ascii?Q?XdCfCqKSfVMV29g6oSo+hnXTypQUJhQ5MBoTU1uhCEJ+wtrgEhhI4SNTop05?=
 =?us-ascii?Q?syVBioddyXXZRN27vjww5MIHnJah2HQStnIbl0Ym0L6K7Wkkig0iMtPZWf+C?=
 =?us-ascii?Q?cnd0spTRrMLjtcc/ukinBWJRBpR+ZmOIIybK3/4CSorEPG8arRYpdl3kigqL?=
 =?us-ascii?Q?XhUR/p50q2+fWdRzTBJCltJjw/po1f/DgDHYECdrVclg2n4o6xLzVJFIYUpR?=
 =?us-ascii?Q?vLjIo0A8ev4xbJxgQAe8z1jpmwVswuQa+f1Gsej0fukFXoPG1Xat8NJBXQNJ?=
 =?us-ascii?Q?wY88IHgc8QQPStcs2uzxhkF0kQt1yNvUPlX5UY/EMgZfGZ3UwGQ87j7BaiEi?=
 =?us-ascii?Q?cYXD2OiZyCBIzR7R2YKi4imBIw9TSyQ6at6hZEbd?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 893b4c9b-0a04-4537-e744-08dc6373efea
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Apr 2024 09:01:17.6769
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: a8L3NXzFSfMWpK3XYr/OWu8IexSf+CxsT6jU0Mz1qbWwlwOVgokQpU5n7Hm1cs7V2p7quJfyvZWLcyi3mO3t7A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5197
X-OriginatorOrg: intel.com

> From: Lu Baolu <baolu.lu@linux.intel.com>
> Sent: Tuesday, April 16, 2024 4:07 PM
>
> @@ -1757,6 +1759,9 @@ int domain_attach_iommu(struct dmar_domain
> *domain, struct intel_iommu *iommu)
>  	unsigned long ndomains;
>  	int num, ret =3D -ENOSPC;
>=20
> +	if (domain->domain.type =3D=3D IOMMU_DOMAIN_SVA)
> +		return 0;
> +
>  	info =3D kzalloc(sizeof(*info), GFP_KERNEL);
>  	if (!info)
>  		return -ENOMEM;
> @@ -1804,6 +1809,9 @@ void domain_detach_iommu(struct dmar_domain
> *domain, struct intel_iommu *iommu)
>  {
>  	struct iommu_domain_info *info;
>=20
> +	if (domain->domain.type =3D=3D IOMMU_DOMAIN_SVA)
> +		return;
> +
>  	spin_lock(&iommu->lock);
>  	info =3D xa_load(&domain->iommu_array, iommu->seq_id);
>  	if (--info->refcnt =3D=3D 0) {

above two are not called for SVA. Why do they start checking
SVA type now?