Received-SPF: pass (google.com: domain of linux-kernel+bounces-154757-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: "Tian, Kevin" <kevin.tian@intel.com>
To: Lu Baolu <baolu.lu@linux.intel.com>, Joerg Roedel <joro@8bytes.org>, "Will
 Deacon" <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>, "Jason
 Gunthorpe" <jgg@ziepe.ca>
CC: "Zhang, Tina" <tina.zhang@intel.com>, "Liu, Yi L" <yi.l.liu@intel.com>,
	"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v3 00/12] Consolidate domain cache invalidation
Thread-Topic: [PATCH v3 00/12] Consolidate domain cache invalidation
Thread-Index: AQHaj9VAILsDRhFBN02eOZFRgygSFLF1mx7w
Date: Tue, 23 Apr 2024 09:06:33 +0000
Message-ID: <BN9PR11MB52765F34E1168B538C7CEDFD8C112@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20240416080656.60968-1-baolu.lu@linux.intel.com>
In-Reply-To: <20240416080656.60968-1-baolu.lu@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/a8CHntON1kJEYvO3FA/ML969mj+tu+0N4jaLJmEdiFMWdbla1bskvSDFrIB?=
 =?us-ascii?Q?o0Q7alwhtdTldSGhLPAwWAdFNbCh7p49IjW6dX0pNBYOAyP0pp5LaU+BsSg5?=
 =?us-ascii?Q?F9jyOfvFHIekrKTP6cYH9fB+nS8dSr0RWTOeonTJjSXokBPfUwI17bAZvgjH?=
 =?us-ascii?Q?gqLj/5C3y0nVqkTO9kGxYp/RPCN+UlVlM8d7DVFkFWMTIBsgruBIrrEOJ3Qs?=
 =?us-ascii?Q?cXhmgJAKD/h2Pm21Ab3b4G/d1XUZIRjZyZGkSbivH0lwxiy2uBBJcodfa2KR?=
 =?us-ascii?Q?svNHro1givpJFxPrT649LDs+OdCeSV9PJQLaM4zzofLCQerZCCoTBwpab1/d?=
 =?us-ascii?Q?sCg/G66HydWmGVREj0D3T3LWAFIZJL1lwqgDCQEgJ5WAPOe1z+60HM/z+qW7?=
 =?us-ascii?Q?TYPNm/pCMgwkqxYRzTt97kqSv/T+YTNz5n/FoGTyAdbuA1ZjCJepHQ62+DjN?=
 =?us-ascii?Q?Ix48nJtWgRYyWCZjNhgUDoDBamB4qcFXgnh2PYKfVea2Hvg0gsuBhR9mCPZh?=
 =?us-ascii?Q?Fvgn9BOSeeEmbeLXbdy+9qkQyCSSV0TWD6Emql4TbUkorXLgR6YEwsjhXXST?=
 =?us-ascii?Q?Hza2RMY3d23HXLqBurYm13mg6guNBZTdFFyjvMP2ffwmA0chLj/+mvA1CXAD?=
 =?us-ascii?Q?zDFgfGHVXMkPnmSLxO4+5/pFvah5Q0prKYs7LfxtFpA7Pai4eH6hiv3aft1T?=
 =?us-ascii?Q?EFu5V9pLqIfV8IVYOaMm/ckxfya/rOXBlRLtJyWz3dOGR0GlnBOFLEposR+4?=
 =?us-ascii?Q?v1LCBwa5kiBWHAbKPOG8JHbqKULSbfxGqgYkOAy957TzjdL9OVSJdqnGnJv0?=
 =?us-ascii?Q?o5ToonXcEpMbQX0bdVZv7EKiuCRxI26o/oieAkR70p8D+MUSgTl6u7614FJP?=
 =?us-ascii?Q?o0XOsKwSacXko+P6SxQCkxoeMHqlgOxszWhgNunihPUiUsU6yiBK3y078CqP?=
 =?us-ascii?Q?kDumAhQR4ZfP2tUU5z4qPbqR5cdvUyA8zZw/6jQzRhyNOeNuKPWnr6w5M30o?=
 =?us-ascii?Q?TWA8IYFq4njhmO7hG0j0blj82ARyLlIenbnxjEp7VUOSO52nB96190HUyE12?=
 =?us-ascii?Q?8lSzg+gIFU7Dv5HJI1IGLOKitGPoJnwB7ZGbewonYDRbItUDGQr2ibnM3dry?=
 =?us-ascii?Q?3mn3k6YYrSTfqXh66Cxf4PrP3CM+7YqG193dYDKUY1H+3MPZtJ7/RfnVuEu6?=
 =?us-ascii?Q?ql0Ch87qTmUp0eIUKSCFE6FVmjq4iKA+K/EPxKv6tSNCnc2es+Qvym1Kuoac?=
 =?us-ascii?Q?D7NeFWt+cJ0gnuPTH0biITYKX1LqZUGKuqy2L18RvSb+LvM+RlSVTpD9ZX+w?=
 =?us-ascii?Q?2+POJRvfy/EaE/VcbC6XuGTcd5D5WH/+L/4J4fqtwqeMz3jc/3oqcLP7s30L?=
 =?us-ascii?Q?f/6F8aCtvCjTWy6U9KRhaBUmCIsFLdRXk246do60LetTcvah58DyhO4sm3Ex?=
 =?us-ascii?Q?cJO/xpCIDnA8O9Gg7TfJZFBjKSUrNPcfr1YzdDFQMAk2fPPxBc6fGFcWoKiF?=
 =?us-ascii?Q?cu107LTpvGWzvkqDtlHniH9pbewakktiTUs5V6qnrU8jqZqna9xiY+OQ2j5R?=
 =?us-ascii?Q?0R8Bv5k2+jmRbIQ+xV7JpZqmifgwTuQ7Mn/aSSkb?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cc4f29ac-5851-4326-2b2f-08dc6374ac40
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Apr 2024 09:06:33.6430
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: diuGkVWVCzA42gQlcXfQ0B4BxJli6AM6/QeMjo6xl0b9EPSgFTcddjfw+oNKHkKYrI2fH0llLPpOJYUWhDPe2Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5197
X-OriginatorOrg: intel.com

> From: Lu Baolu <baolu.lu@linux.intel.com>
> Sent: Tuesday, April 16, 2024 4:07 PM
>=20
> The IOMMU hardware cache needs to be invalidated whenever the
> mappings
> in the domain are changed. Currently, domain cache invalidation is
> scattered across different places, causing several issues:
>=20
> - IOMMU IOTLB Invalidation: This is done by iterating through the domain
>   IDs of each domain using the following code:
>=20
>         xa_for_each(&dmar_domain->iommu_array, i, info)
>                 iommu_flush_iotlb_psi(info->iommu, dmar_domain,
>                                       start_pfn, nrpages,
>                                       list_empty(&gather->freelist), 0);
>=20
>   This code could theoretically cause a use-after-free problem because
>   there's no lock to protect the "info" pointer within the loop.
>=20
> - Inconsistent Invalidation Methods: Different domain types implement
>   their own cache invalidation methods, making the code difficult to
>   maintain. For example, the DMA domain, SVA domain, and nested domain
>   have similar cache invalidation code scattered across different files.
>=20
> - SVA Domain Inconsistency: The SVA domain implementation uses a
>   completely different data structure to track attached devices compared
>   to other domains. This creates unnecessary differences and, even
>   worse, leads to duplicate IOTLB invalidation when an SVA domain is
>   attached to devices belonging to a same IOMMU.
>=20
> - Nested Domain Dependency: The special overlap between a nested domain
>   and its parent domain requires a dedicated parent_domain_flush()
>   helper function to be called everywhere the parent domain's mapping
>   changes.
>=20
> - Limited Debugging Support: There are currently no debugging aids
>   available for domain cache invalidation.
>=20
> By consolidating domain cache invalidation into a common location, we
> can address the issues mentioned above and improve the code's
> maintainability and debuggability.
>=20

There are several small nits but overall this series looks good to me:

Reviewed-by: Kevin Tian <kevin.tian@intel.com>