Received-SPF: pass (google.com: domain of linux-kernel+bounces-154781-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <6e9d6af5-74bc-4e97-84c0-2ba8a6499da9@bytedance.com>
Date: Tue, 23 Apr 2024 17:21:48 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Re: [PATCH v3 2/4] virtio_balloon: introduce oom-kill invocations
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
 virtualization@lists.linux.dev, david@redhat.com, jasowang@redhat.com,
 xuanzhuo@linux.alibaba.com, akpm@linux-foundation.org
References: <20240423034109.1552866-1-pizhenwei@bytedance.com>
 <20240423034109.1552866-3-pizhenwei@bytedance.com>
 <20240423051151-mutt-send-email-mst@kernel.org>
Content-Language: en-US
From: zhenwei pi <pizhenwei@bytedance.com>
In-Reply-To: <20240423051151-mutt-send-email-mst@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 4/23/24 17:13, Michael S. Tsirkin wrote:
> On Tue, Apr 23, 2024 at 11:41:07AM +0800, zhenwei pi wrote:

[snip]
>>   #define VIRTIO_BALLOON_S_NAMES_WITH_PREFIX(VIRTIO_BALLOON_S_NAMES_prefix) { \
>>   	VIRTIO_BALLOON_S_NAMES_prefix "swap-in", \
> 
> Looks like a useful extension. But
> any UAPI extension has to go to virtio spec first.
> 

Sure, I'll send related virtio spec changes once virtio comment mail 
list gets ready.

>> @@ -83,7 +84,8 @@ struct virtio_balloon_config {
>>   	VIRTIO_BALLOON_S_NAMES_prefix "available-memory", \
>>   	VIRTIO_BALLOON_S_NAMES_prefix "disk-caches", \
>>   	VIRTIO_BALLOON_S_NAMES_prefix "hugetlb-allocations", \
>> -	VIRTIO_BALLOON_S_NAMES_prefix "hugetlb-failures" \
>> +	VIRTIO_BALLOON_S_NAMES_prefix "hugetlb-failures", \
>> +	VIRTIO_BALLOON_S_NAMES_prefix "oom-kills" \
>>   }
>>   
>>   #define VIRTIO_BALLOON_S_NAMES VIRTIO_BALLOON_S_NAMES_WITH_PREFIX("")
>> -- 
>> 2.34.1
> 

-- 
zhenwei pi