Received-SPF: pass (google.com: domain of linux-kernel+bounces-154851-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Tue, 23 Apr 2024 18:22:58 +0800
From: Huang Rui <ray.huang@amd.com>
To: "Yuan, Perry" <Perry.Yuan@amd.com>
Cc: "rafael.j.wysocki@intel.com" <rafael.j.wysocki@intel.com>,
	"Limonciello, Mario" <Mario.Limonciello@amd.com>,
	"viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
	"Shenoy, Gautham Ranjal" <gautham.shenoy@amd.com>,
	"Petkov, Borislav" <Borislav.Petkov@amd.com>,
	"Deucher, Alexander" <Alexander.Deucher@amd.com>,
	"Huang, Shimmer" <Shimmer.Huang@amd.com>,
	"oleksandr@natalenko.name" <oleksandr@natalenko.name>,
	"Du, Xiaojian" <Xiaojian.Du@amd.com>,
	"Meng, Li (Jassmine)" <Li.Meng@amd.com>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v11 1/8] cpufreq: amd-pstate: Document *_limit_* fields
 in struct amd_cpudata
Message-ID: <ZieMAr//Ofu1ZE0G@amd.com>
References: <cover.1713858800.git.perry.yuan@amd.com>
 <c50374885172571e1c25d95552dec8467c37ea24.1713858800.git.perry.yuan@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <c50374885172571e1c25d95552dec8467c37ea24.1713858800.git.perry.yuan@amd.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?K4vRKJ4Gl3UwveKIA1rrmpwJU/JKAJzxP7iefiQQIBKMTd0BPi8iO+SUeq3b?=
 =?us-ascii?Q?kZ5FbzcOoriBokPSkGpoISp8iMps6EsGBpetphKBls7zMnFi8aTxdQ00wCT8?=
 =?us-ascii?Q?PEH2hhLN6aLGomSTLK7kaNrHg6LhNBnQ/r7qM03QmjwMxLG6n5wAxxZh88S5?=
 =?us-ascii?Q?K0xZK73CckYI91svw7GU9ioCrT5T3flQjSdH2npEXd/FQnsvh9IUNeHM+kvs?=
 =?us-ascii?Q?mLV+vx1J0TyuxRmfplEcrJ2ruH/g76ts+YXZ0ojTxqlRuxkQvfjdTMUWSNok?=
 =?us-ascii?Q?xDVBKiA1wrvwk4WaqedFKmc8OlmdfMDNnZMc/oi7YcdPtJ9g3AS+Z4tg+x81?=
 =?us-ascii?Q?RCbcWMReismNO1HUGJJGhFNsVpcTQZha9nu0pqVgb9EY6Bq2Ct/E+dy/GXSf?=
 =?us-ascii?Q?iPzECaBaOWqshnvZvG/2/puiYAEiRJvO7hVyg6vzb8TEVnpEt/77zRVmu+zX?=
 =?us-ascii?Q?VEG+x5CwKQlv72EMEJsElSN+FYoKWh8GD7VXMGBnWHsSCJXK5RkW61VwUakO?=
 =?us-ascii?Q?BO73emd7BUqpcs3+bkZaf2IJcLGapUUCwTVjBAhXBDg49OwuU0eQpGP/DweW?=
 =?us-ascii?Q?qeUZqK32A4CUcHA3dFijFwnNKwaTnDoDI2g47lkPg7i4FB3AxGCl1AJAljnB?=
 =?us-ascii?Q?mxlt16yhQG+gpRxm3YhFE1zRml/486izQ38IePfj/Yj0kkZtxrW8dgILq1dE?=
 =?us-ascii?Q?9m58/lAFPvEcBTN12bWNDlbWDUHBsmVl1L1ES4iABUvtFjxfQlWye/ARHAB+?=
 =?us-ascii?Q?DPsgh/UFxXd7ARSeYTeODqXOOXN9l3bEnhd5Lqop3i49nq3jXfwiqF9JHcDS?=
 =?us-ascii?Q?RkO5QV8L2wWYb/pDeeZ+J/xDxdOm17JHuxTCfonmyOE+C6geaTteoXO0uhfA?=
 =?us-ascii?Q?3zCOmBabZf/GVugkKauG0TjuDTh1ShmgHvtrslOIujk73dyRV0Z/qb6LXbNL?=
 =?us-ascii?Q?Yq2266XBlFFLFLLvkcfm1fd0zWo1Byw6rXeHj8HYZrXKk7ZZbZZP9tmZv3Bl?=
 =?us-ascii?Q?0FAExCh2yCseR9N7cHfnS45QNgozNz2rKlUoE8Cl00CdsqioQ1NOX2kBRmKp?=
 =?us-ascii?Q?2FIEK6rVFbvPdMp/bKYUoHUtTRSrSxTUA8V8DqCLbIf2K+aQ39EL94L00QIW?=
 =?us-ascii?Q?Wvh9lVEftbdH/AX1qQQMHyFZ/JL8TIixqo5nqSZKGYRCrFisWXFVHqaV9HJ7?=
 =?us-ascii?Q?tcUGza6fC4havm4jeXkn8zrqXh8RpTl5dRyqRGRgsF8dKUdhpP//BPI7Q7+5?=
 =?us-ascii?Q?kG4VkAbGDN6GW01K5pMMZotxXd8yfYDwkeGMtkdI9ZVLiQ8cHBnpC7Sc06Kh?=
 =?us-ascii?Q?H5aqRqbt9Fqq+1ZiTrjl0JEhaQX2jogBY57TMd7fwE5A2/MRo6as4Qu13MBi?=
 =?us-ascii?Q?rdtlrPV4nDIZm76GIEFPzYxp49KSFY83qVCTDgIacTSiwAuVq8QEoyytieby?=
 =?us-ascii?Q?EwD4o2//MFSFAC9B+EAbIF8c6nhNjaF8/NYjtqDsle31R9yUmkLckibavA90?=
 =?us-ascii?Q?0MH/nKSqRdctyoo1FBu1b3MHRtvoDEJYBwYTdMTZ8/RT1cl2VAIY/G0FlR63?=
 =?us-ascii?Q?gqCA2hBsunsrrylF4pFhv7mpQ/3XBAiEkuKcFnAU?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8fb79681-59c3-4f5a-47d7-08dc637f6705
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8690.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2024 10:23:22.3198
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hg3Swx2MNewCymE5/U4t5UWzaqMX5myPjmBveCJqZMakGQ+pubBJcC8EmjQbbcejQ8KpreRWA2votvjxSu66aA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4336

On Tue, Apr 23, 2024 at 03:58:17PM +0800, Yuan, Perry wrote:
> From: "Gautham R. Shenoy" <gautham.shenoy@amd.com>
> 
> The four fields of struct cpudata namely min_limit_perf,
> max_limit_perf, min_limit_freq, max_limit_freq introduced in the
> commit febab20caeba("cpufreq/amd-pstate: Fix scaling_min_freq and
> scaling_max_freq update") are currently undocumented
> 
> Add comments describing these fields
> 
> Acked-by: Huang Rui <ray.huang@amd.com>
> Fixes: febab20caeba("cpufreq/amd-pstate: Fix scaling_min_freq and scaling_max_freq update")
> Reviewed-by: Li Meng <li.meng@amd.com>
> Tested-by: Dhananjay Ugwekar <Dhananjay.Ugwekar@amd.com>
> Signed-off-by: Gautham R. Shenoy <gautham.shenoy@amd.com>
> Signed-off-by: Perry Yuan <perry.yuan@amd.com>
> ---
>  include/linux/amd-pstate.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/linux/amd-pstate.h b/include/linux/amd-pstate.h
> index d21838835abd..212f377d615b 100644
> --- a/include/linux/amd-pstate.h
> +++ b/include/linux/amd-pstate.h
> @@ -49,6 +49,10 @@ struct amd_aperf_mperf {
>   * @lowest_perf: the absolute lowest performance level of the processor
>   * @prefcore_ranking: the preferred core ranking, the higher value indicates a higher
>   * 		  priority.
> + * @min_limit_perf: Cached value of the perf corresponding to policy->min
> + * @max_limit_perf: Cached value of the perf corresponding to policy->max

Perry, you didn't address the comment in the latest version.

https://lore.kernel.org/lkml/ZhyEwE3Hr8Waf620@amd.com/

Thanks,
Ray

> + * @min_limit_freq: Cached value of policy->min
> + * @max_limit_freq: Cached value of policy->max
>   * @max_freq: the frequency that mapped to highest_perf
>   * @min_freq: the frequency that mapped to lowest_perf
>   * @nominal_freq: the frequency that mapped to nominal_perf
> -- 
> 2.34.1
>