Received-SPF: pass (google.com: domain of linux-kernel+bounces-154858-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240416-bcachefs-fix-format-specifier-validate_bset_keys-v1-1-3ea2cdf28b12@kernel.org>
 <xznpzlnjcf3goexunm6azwercgwz7ikgum3i4gpdyxwykb4e4l@ascd3uztphq3>
 <CAMuHMdV9wMO2E=xNezs5FiDK_F3XKaVPaFbhh9+7djd26KkgMA@mail.gmail.com> <omczcaeo74gwmsnysol6m7wwrh4rcdonmcn3fwp64pkavczqcp@enobbzrlpymb>
In-Reply-To: <omczcaeo74gwmsnysol6m7wwrh4rcdonmcn3fwp64pkavczqcp@enobbzrlpymb>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Tue, 23 Apr 2024 12:24:56 +0200
Message-ID: <CAMuHMdX04q-af8BVWqGgeG5gkZrrDJWsnrJh5j=XG97vrdTQrg@mail.gmail.com>
Subject: bcachefs broken in next (was: Re: [PATCH] bcachefs: Fix format
 specifier in validate_bset_keys())
To: Kent Overstreet <kent.overstreet@linux.dev>
Cc: Nathan Chancellor <nathan@kernel.org>, bfoster@redhat.com, linux-bcachefs@vger.kernel.org, 
	linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>, 
	Stephen Rothwell <sfr@canb.auug.org.au>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Kent,

On Mon, Apr 22, 2024 at 9:32=E2=80=AFPM Kent Overstreet
<kent.overstreet@linux.dev> wrote:
> On Mon, Apr 22, 2024 at 02:47:32PM +0200, Geert Uytterhoeven wrote:
> > On Wed, Apr 17, 2024 at 12:09=E2=80=AFAM Kent Overstreet
> > <kent.overstreet@linux.dev> wrote:
> > > On Tue, Apr 16, 2024 at 08:16:02AM -0700, Nathan Chancellor wrote:
> > > > When building for 32-bit platforms, for which size_t is 'unsigned i=
nt',
> > > > there is a warning from a format string in validate_bset_keys():
> > > >
> > > >   fs/bcachefs/btree_io.c: In function 'validate_bset_keys':
> > > >   fs/bcachefs/btree_io.c:891:34: error: format '%lu' expects argume=
nt of type 'long unsigned int', but argument 12 has type 'unsigned int' [-W=
error=3Dformat=3D]
> > > >     891 |                                  "bad k->u64s %u (min %u =
max %lu)", k->u64s,
> > > >         |                                  ^~~~~~~~~~~~~~~~~~~~~~~~=
~~~~~~~~~
> > > >   fs/bcachefs/btree_io.c:603:32: note: in definition of macro 'btre=
e_err'
> > > >     603 |                                msg, ##__VA_ARGS__);      =
               \
> > > >         |                                ^~~
> > > >   fs/bcachefs/btree_io.c:887:21: note: in expansion of macro 'btree=
_err_on'
> > > >     887 |                 if (btree_err_on(!bkeyp_u64s_valid(&b->fo=
rmat, k),
> > > >         |                     ^~~~~~~~~~~~
> > > >   fs/bcachefs/btree_io.c:891:64: note: format string is defined her=
e
> > > >     891 |                                  "bad k->u64s %u (min %u =
max %lu)", k->u64s,
> > > >         |                                                          =
    ~~^
> > > >         |                                                          =
      |
> > > >         |                                                          =
      long unsigned int
> > > >         |                                                          =
    %u
> > > >   cc1: all warnings being treated as errors
> > > >
> > > > BKEY_U64s is size_t so the entire expression is promoted to size_t.=
 Use
> > > > the '%zu' specifier so that there is no warning regardless of the w=
idth
> > > > of size_t.
> > > >
> > > > Fixes: 031ad9e7dbd1 ("bcachefs: Check for packed bkeys that are too=
 big")
> > > > Reported-by: kernel test robot <lkp@intel.com>
> > > > Closes: https://lore.kernel.org/oe-kbuild-all/202404130747.wH6Dd23p=
-lkp@intel.com/
> > > > Closes: https://lore.kernel.org/oe-kbuild-all/202404131536.HdAMBOVc=
-lkp@intel.com/
> > > > Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> > >
> > > Thanks, applied
> >
> > This is still not fixed in today's linux-next, while the issue is now
> > causing breakage on several 32-bit defconfs in v6.9-rc5.
>
> Apologies, I just neglected to update my for-next branch, it's in now.

Thank you, I can confirm it is there.

However, linux-next is broken again on lots of configs
http://kisskb.ellerman.id.au/kisskb/head/a59668a9397e7245b26e9be85d23f242ff=
757ae8/

fs/bcachefs/btree_key_cache.c:1057:64: error: 'struct srcu_struct' has
no member named 'srcu_sup'; did you mean 'srcu_idx'?

I have bisected this to commit f2d47ec26af5b235 ("bcachefs: Btree key
cache instrumentation"), but I cannot find that patch on any mailing list
archived on lore.

Please do not include untested and/or unreviewed patches in any branches
included in linux-next.

Thank you!

Gr{oetje,eeting}s,

                        Geert

--=20
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k=
org

In personal conversations with technical people, I call myself a hacker. Bu=
t
when I'm talking to journalists I just say "programmer" or something like t=
hat.
                                -- Linus Torvalds